From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 16 04:47:48 2017 Received: (at 28673-done) by debbugs.gnu.org; 16 Nov 2017 09:47:48 +0000 Received: from localhost ([127.0.0.1]:42592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFGls-0000IV-HR for submit@debbugs.gnu.org; Thu, 16 Nov 2017 04:47:48 -0500 Received: from hera.aquilenet.fr ([141.255.128.1]:45475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFGlm-0000IH-HU for 28673-done@debbugs.gnu.org; Thu, 16 Nov 2017 04:47:42 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 14557C2D9; Thu, 16 Nov 2017 10:47:40 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I5Tb5_V4vBHz; Thu, 16 Nov 2017 10:47:37 +0100 (CET) Received: from ribbon (unknown [193.50.110.175]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 819079A5E; Thu, 16 Nov 2017 10:47:37 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Dave Love Subject: Re: [bug#28673] [PATCH 5/6] gnu: libunwind: Merge update and test changes. References: <20171002204848.23646-1-fx@gnu.org> <20171002204848.23646-5-fx@gnu.org> <87vajw47cz.fsf@gnu.org> Date: Thu, 16 Nov 2017 10:47:35 +0100 In-Reply-To: <87vajw47cz.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 03 Oct 2017 16:46:20 +0200") Message-ID: <87lgj6imh4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 28673-done Cc: 28673-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Dave, ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Dave Love skribis: > >> * gnu/packages/patches/libunwind-known_test_failure_to_XFAIL_TESTS.patch: >> New file. >> * gnu/packages/patches/libunwind-ppc_lib64.patch: New file. >> * gnu/packages/libunwind.scm (libunwind)[source]: Use them. >> (libunwind)(native-inputs): Add autotools. >> (libunwind)(arguments): Enable tests; run autoreconf. >> * gnu/local.mk: Update dependencies. > > [...] > >> +++ b/gnu/packages/patches/libunwind-known_test_failure_to_XFAIL_TESTS.p= atch >> @@ -0,0 +1,11 @@ >> +--- libunwind-1.2.1/tests/Makefile.am~ 1970-01-01 01:00:00.000000000 +0= 100 >> ++++ libunwind-1.2.1/tests/Makefile.am 2017-09-06 13:32:52.331888031 +01= 00 >> +@@ -97,7 +97,7 @@ >> + XFAIL_TESTS =3D >> +=20 >> + if !ARCH_IA64 >> +-XFAIL_TESTS +=3D Gtest-dyn1 Ltest-dyn1 >> ++XFAIL_TESTS +=3D Gtest-dyn1 Ltest-dyn1 test-ptrace >> + endif >> +=20 >> + # Use if arch defines but does not support PTRACE_SINGLESTEP >> diff --git a/gnu/packages/patches/libunwind-ppc_lib64.patch b/gnu/packag= es/patches/libunwind-ppc_lib64.patch >> new file mode 100644 >> index 000000000..9ab0108ae >> --- /dev/null >> +++ b/gnu/packages/patches/libunwind-ppc_lib64.patch >> @@ -0,0 +1,17 @@ >> +Index: pkg-libunwind/configure.ac >> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> +--- pkg-libunwind.orig/configure.ac 2014-05-07 15:13:28.247711669 +0900 >> ++++ pkg-libunwind/configure.ac 2014-05-07 15:14:25.924958386 +0900 >> +@@ -164,12 +164,6 @@ >> + AM_CONDITIONAL(USE_DWARF, [test x$use_dwarf =3D xyes]) >> + AC_MSG_RESULT([$use_dwarf]) >> +=20 >> +-if test x$target_arch =3D xppc64; then >> +- libdir=3D'${exec_prefix}/lib64' >> +- AC_MSG_NOTICE([PowerPC64 detected, lib will be installed ${lib= dir}]); >> +- AC_SUBST([libdir]) >> +-fi > > Could you avoid this patch and instead use =E2=80=98substitute*=E2=80=99 = on =E2=80=98configure=E2=80=99 > and =E2=80=98tests/Makefile.in=E2=80=99 such that we don=E2=80=99t need t= he extra dependency on > the autotools? > > Please make sure to add a comment explaining why we=E2=80=99re doing this= (the > Makefile.am bit is not obvious to me.) Since these libunwind changes do not seem to relate to the rest of this PAPI series (which has been applied), I=E2=80=99m closing it now. Feel fre= e to resubmit separately if you think it=E2=80=99s still relevant! Thanks, Ludo=E2=80=99.