From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 04:30:24 2019 Received: (at 28128) by debbugs.gnu.org; 13 May 2019 08:30:24 +0000 Received: from localhost ([127.0.0.1]:44021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ6Lk-00053Y-Ns for submit@debbugs.gnu.org; Mon, 13 May 2019 04:30:24 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:33528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hQ6Li-00053O-BY for 28128@debbugs.gnu.org; Mon, 13 May 2019 04:30:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=q67onk/eT+iUc5WPLN1CZxL+32pXLXx6YlVEQOYX1V8=; b=C7dcpXPXAaLHMmK+Eo8oWbQn7 NAtLMmbTytQE/rt6zyCerRe3og/C0qw3xwUGWLfIEz8PowNSVpRReYszUAlVO9qxc9UORZ8D7pRJl g3S+fPJ8xRWzA8Lt16iHD4rGG7yT1s8tzxgu/QTHYZHDKqaTXEE+duGljH19KuqokKErQ=; Received: from [14.139.128.10] (helo=steel) by systemreboot.net with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hQ6Le-0001Pp-Un; Mon, 13 May 2019 14:00:15 +0530 From: Arun Isaac To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH 2/2] scripts: system: Support container network sharing. In-Reply-To: <87imuftlin.fsf@gnu.org> References: <20190313093610.1071-1-arunisaac@systemreboot.net> <20190313093610.1071-3-arunisaac@systemreboot.net> <87va0n80u5.fsf@gnu.org> <874l80tw60.fsf@gnu.org> <871s2y7r71.fsf@inria.fr> <87imuftlin.fsf@gnu.org> Date: Mon, 13 May 2019 14:00:05 +0530 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 28128 Cc: Christopher Baines , 28128@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain >> Should I add any documentation about this new -N option to the >> manual? > > Yes, please. Please find attached the updated patch. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-linux-container-Support-container-network-sharing.patch Content-Transfer-Encoding: quoted-printable From=2053fc5d548d8c2bb772dd6f26df80809ba2707a20 Mon Sep 17 00:00:00 2001 From: Arun Isaac Date: Fri, 10 May 2019 16:56:16 +0530 Subject: [PATCH] linux-container: Support container network sharing. * gnu/system/linux-container.scm (container-essential-services): If network= is to be shared with the host, remove network configuration files from etc service. (containerized-operating-system): If network is to be shared with the host, remove nscd service and map host's /var/run/nscd if it exists. (container-script): If network is to be shared with the host, do not create network namespace. * guix/scripts/system.scm (system-derivation-for-action): Add #:container-shared-network? argument. (perform-action): Add #:container-shared-network? argument. (show-help): Add "-N, --network" help information. (%options): Add network option. (process-action): Call perform-action with #container-shared-network? argum= ent. * doc/guix.texi (Invoking guix system): Document the "-N, --network" option. Co-authored-by: Christopher Baines =2D-- doc/guix.texi | 5 +++ gnu/system/linux-container.scm | 63 ++++++++++++++++++++++++++++------ guix/scripts/system.scm | 20 +++++++++-- 3 files changed, 75 insertions(+), 13 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index b6d00ec176..aa4888da73 100644 =2D-- a/doc/guix.texi +++ b/doc/guix.texi @@ -24586,6 +24586,11 @@ When this option is omitted, @command{guix system}= computes an estimate of the image size as a function of the size of the system declared in @var{file}. =20 +@item --network +@itemx -N +For the @code{container} action, allow containers to access the host netwo= rk, +that is, do not create a network namespace. + @item --root=3D@var{file} @itemx -r @var{file} Make @var{file} a symlink to the result, and register it as a garbage diff --git a/gnu/system/linux-container.scm b/gnu/system/linux-container.scm index ded5f279fe..ce786e39b2 100644 =2D-- a/gnu/system/linux-container.scm +++ b/gnu/system/linux-container.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2015 David Thompson ;;; Copyright =C2=A9 2016, 2017, 2019 Ludovic Court=C3=A8s +;;; Copyright =C2=A9 2019 Arun Isaac ;;; ;;; This file is part of GNU Guix. ;;; @@ -35,7 +36,7 @@ containerized-operating-system container-script)) =20 =2D(define (container-essential-services os) +(define* (container-essential-services os #:key shared-network?) "Return a list of essential services corresponding to OS, a non-containerized OS. This procedure essentially strips essential services from OS that are needed on the bare metal and not in a container." @@ -51,9 +52,20 @@ from OS that are needed on the bare metal and not in a c= ontainer." (let ((locale (operating-system-locale-directory os))) (with-monad %store-monad (return `(("locale" ,locale)))))) =2D base)) + ;; If network is to be shared with the host, remove network + ;; configuration files from etc-service. + (if shared-network? + (modify-services base + (etc-service-type + files =3D> (remove + (match-lambda + ((filename _) + (member filename + (map basename %network-configuration-f= iles)))) + files))) + base))) =20 =2D(define (containerized-operating-system os mappings) +(define* (containerized-operating-system os mappings #:key shared-network?) "Return an operating system based on OS for use in a Linux container environment. MAPPINGS is a list of to realize in the containerized OS." @@ -76,27 +88,53 @@ containerized OS." (define useless-services ;; Services that make no sense in a container. Those that attempt to ;; access /dev/tty[0-9] in particular cannot work in a container. =2D (list console-font-service-type =2D mingetty-service-type =2D agetty-service-type)) + (append (list console-font-service-type + mingetty-service-type + agetty-service-type) + ;; Remove nscd service if network is shared with the host. + (if shared-network? + (list nscd-service-type) + (list)))) + + (define shared-network-file-mappings + ;; Files to map if network is to be shared with the host + (append %network-file-mappings + (let ((nscd-run-directory "/var/run/nscd")) + (if (file-exists? nscd-run-directory) + (list (file-system-mapping + (source nscd-run-directory) + (target nscd-run-directory))) + (list))))) + + ;; (write shared-network-file-mappings) + ;; (newline) =20 (operating-system (inherit os) (swap-devices '()) ; disable swap =2D (essential-services (container-essential-services os)) + (essential-services (container-essential-services + os #:shared-network? shared-network?)) (services (remove (lambda (service) (memq (service-kind service) useless-services)) (operating-system-user-services os))) =2D (file-systems (append (map mapping->fs (cons %store-mapping mappings= )) + (file-systems (append (map mapping->fs + (cons %store-mapping + (append mappings + (if shared-network? + shared-network-file-mappi= ngs + (list))))) %container-file-systems user-file-systems)))) =20 =2D(define* (container-script os #:key (mappings '())) +(define* (container-script os #:key (mappings '()) shared-network?) "Return a derivation of a script that runs OS as a Linux container. MAPPINGS is a list of objects that specify the files/directo= ries that will be shared with the host system." =2D (let* ((os (containerized-operating-system os mappings)) + (let* ((os (containerized-operating-system + os + mappings + #:shared-network? shared-network?)) (file-systems (filter file-system-needed-for-boot? (operating-system-file-systems os))) (specs (map file-system->spec file-systems))) @@ -121,6 +159,9 @@ that will be shared with the host system." ;; users and groups, which is sufficient for most cases. ;; ;; See: http://www.freedesktop.org/software/systemd/man/syst= emd-nspawn.html#--private-users=3D =2D #:host-uids 65536)))) + #:host-uids 65536 + #:namespaces (if #$shared-network? + (delq 'net %namespaces) + %namespaces))))) =20 (gexp->script "run-container" script))) diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm index 3c3d6cbd5f..cf4418f981 100644 =2D-- a/guix/scripts/system.scm +++ b/guix/scripts/system.scm @@ -4,6 +4,7 @@ ;;; Copyright =C2=A9 2016, 2017, 2018 Chris Marusich ;;; Copyright =C2=A9 2017 Mathieu Othacehe ;;; Copyright =C2=A9 2018 Ricardo Wurmus +;;; Copyright =C2=A9 2019 Christopher Baines ;;; ;;; This file is part of GNU Guix. ;;; @@ -756,13 +757,17 @@ checking this by themselves in their 'check' procedur= e." =20 (define* (system-derivation-for-action os action #:key image-size file-system-type =2D full-boot? mappings) + full-boot? container-shared-network? + mappings) "Return as a monadic value the derivation for OS according to ACTION." (case action ((build init reconfigure) (operating-system-derivation os)) ((container) =2D (container-script os #:mappings mappings)) + (container-script + os + #:mappings mappings + #:shared-network? container-shared-network?)) ((vm-image) (system-qemu-image os #:disk-image-size image-size)) ((vm) @@ -826,6 +831,7 @@ and TARGET arguments." dry-run? derivations-only? use-substitutes? bootloader-target target image-size file-system-type full-boot? + container-shared-network? (mappings '()) (gc-root #f)) "Perform ACTION for OS. INSTALL-BOOTLOADER? specifies whether to install @@ -834,6 +840,8 @@ target root directory; IMAGE-SIZE is the size of the im= age to be built, for the 'vm-image' and 'disk-image' actions. The root file system is created = as a FILE-SYSTEM-TYPE file system. FULL-BOOT? is used for the 'vm' action; it determines whether to boot directly to the kernel or to the bootloader. +CONTAINER-SHARED-NETWORK? determines if the container will use a separate +network namespace. =20 When DERIVATIONS-ONLY? is true, print the derivation file name(s) without building anything. @@ -883,6 +891,7 @@ static checks." #:file-system-type file-sy= stem-type #:image-size image-size #:full-boot? full-boot? + #:container-shared-network= ? container-shared-network? #:mappings mappings)) =20 ;; For 'init' and 'reconfigure', always build BOOTCFG, even if @@ -1020,6 +1029,8 @@ Some ACTIONS support additional ARGS.\n")) (display (G_ " --share=3DSPEC for 'vm', share host file system according to S= PEC")) (display (G_ " + -N, --network for 'container', allow containers to access the n= etwork")) + (display (G_ " -r, --root=3DFILE for 'vm', 'vm-image', 'disk-image', 'container', and 'build', make FILE a symlink to the result, a= nd register it as a garbage collector root")) @@ -1066,6 +1077,9 @@ Some ACTIONS support additional ARGS.\n")) (lambda (opt name arg result) (alist-cons 'image-size (size->number arg) result))) + (option '(#\N "network") #f #f + (lambda (opt name arg result) + (alist-cons 'container-shared-network? #t result))) (option '("no-bootloader" "no-grub") #f #f (lambda (opt name arg result) (alist-cons 'install-bootloader? #f result))) @@ -1182,6 +1196,8 @@ resulting from command-line parsing." #:file-system-type (assoc-ref opts 'file-syst= em-type) #:image-size (assoc-ref opts 'image-size) #:full-boot? (assoc-ref opts 'full-boot?) + #:container-shared-network? + (assoc-ref opts 'container-shared-network?) #:mappings (filter-map (match-lambda (('file-system-mappi= ng . m) m) =2D-=20 2.21.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAlzZKw0ACgkQLiXui2GA K7PRCwgAvO315y5Wr+DOJ8gHOjcIahhvhWccipHwAPXD2R9h1W3YaRHOT+L+vYGa lh9IzSm/izMzI2SGJKbqJB2Z7Q1DfY8Zu3BXzHYe/QeVOfVXbVa0WslZZ97nPVup W/GX4CFINYW0W8R1mprXCvUefdxMiruPokoHBKPUuDeRnv6/lcEYUhtkPFH20syR AjkBnCDEaZqAD87GzVjKnHJg+2/06Hzm6Y49ZBc4/C8LruBx+FtFzE5+/Z2j5zsZ YSzFiFBOqLUcuCp28G0679U+UystYYgbpfJfWH0hQCnjcDDfbBChlRGLYMK0QC9l iPRoNiwCrhg2zWYxikj59dxZownYaQ== =Ku3F -----END PGP SIGNATURE----- --==-=-=--