Subject: Re: bug#27284: [PATCH 1/8] build: Factorize module compilation in (guix build compile).

From: Maxim Cournoyer <[email-masked]>
Date: Sun, 22 Oct 2017 17:22:37 -0400

Hello,

Ludovic Courtès <[email-masked]> writes:

> * guix/build/compile.scm: New file.
> * Makefile.am (MODULES): Add it.
> * build-aux/compile-all.scm: Use it.
> (warnings, file->module, load-module-file)
> (%default-optimizations, %lightweight-optimizations)
> (optimization-options, compile-file*): Remove.
> <top level>: Use 'compile-files'.
> * guix/build/pull.scm (%default-optimizations)
> (%lightweight-optimizations, optimization-options): Remove.
> (build-guix): Rewrite as a call to 'compile-files'.
> * guix/discovery.scm (file-name->module-name): Export.
> ---
>  Makefile.am               |   1 +
>  build-aux/compile-all.scm |  92 ++++----------------------
>  guix/build/compile.scm    | 165 ++++++++++++++++++++++++++++++++++++++++++++++
>  guix/build/pull.scm       | 105 ++++++++---------------------
>  guix/discovery.scm        |   4 +-
>  5 files changed, 209 insertions(+), 158 deletions(-)
>  create mode 100644 guix/build/compile.scm

[...]

This and the other patches in this series look fine to me. Maybe the
change log items could be a bit more precise about what got moved rather
than removed, but given the amount of refactoring this might be too
verbose to be worth it?

Maxim