From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 24 10:52:53 2017 Received: (at 26625) by debbugs.gnu.org; 24 Apr 2017 14:52:53 +0000 Received: from localhost ([127.0.0.1]:38134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2fMC-0000oO-Oz for submit@debbugs.gnu.org; Mon, 24 Apr 2017 10:52:52 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2fMB-0000oG-3F for 26625@debbugs.gnu.org; Mon, 24 Apr 2017 10:52:51 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 989FD20BFB; Mon, 24 Apr 2017 10:52:50 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Mon, 24 Apr 2017 10:52:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=/VslbJ2l+15fzC72OVu6qASXjxHJAgEyrKWo21NmN NM=; b=h3SF72sQJev1Kxjc2mX7IRcb2gF1cTdol9bMdoFbTLGFw9LgR9b3Zh1Q4 lOZLlFR7F7bGwJgXEBANNbXcBJraubJkKhJv87Gh5U2h97pB8O/pCRZVDp51vaau RElEEboCfWksRUYLry0xCcCbtMw2JPKeS/yPwrgd6IM34IkTCpcm7NNkjj8Vl8Ff Gt7Fo03UjV11wO0LmKKWEbTP/AbXQpU8JHg5kkLnIk8+X3j8KVQGe51qBknY8XVC K+bOJBAX0DGtoS1+t9lC6QtyJw1qcNKUY4JcGRcpFp6Irz7JKxze5GmZe+Dt+0u7 H8WoQEDXvTugRPwRio3CugeLrM79g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=/VslbJ2l+15fzC72OV u6qASXjxHJAgEyrKWo21NmNNM=; b=UFEyNxsikxflUSeXIPilEknLBberL2Kkfm Cgr45tfYKha7itKCJsKnLiqKsRe0VS8Ya9rpW0SHBXmSVS3efxiN1NNCGeHy/+La acFASOl2nfltr6ARCXnWfOD+c/nySuF5RsxxHFPp2rgpJp6MTaIvADQuEsQjCubp ceuACLMjNxxbdY0B7vV8hA/cPGJsoZKwBAh05hf6140hJBKbB2F7vbWGdK0brhrw LRxS7tnWPL5VxdYMWba1aOHaLm9PcDXje6csd03fqBdNX7QASLGfhwVISz9ITKEb Fq9WHGyFfrT2c4KMMMe3wVVTtbpRUdPL2cd9vVfPMOGY6Jdp6K9A== X-ME-Sender: X-Sasl-enc: STRF6kk8YhrTMk0HYtGVzz71h9cQG1Hdxu0noaf7F6vb 1493045570 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 210027E70C; Mon, 24 Apr 2017 10:52:50 -0400 (EDT) From: Marius Bakke To: manolis837@gmail.com, 26625@debbugs.gnu.org Subject: Re: bug#26625: [PATCH] gnu : Add unshield. In-Reply-To: <20170423172345.9116-1-manolis837@gmail.com> References: <20170423172345.9116-1-manolis837@gmail.com> User-Agent: Notmuch/0.24.1 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Mon, 24 Apr 2017 16:52:48 +0200 Message-ID: <87zif5zwlb.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26625 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable manolis837@gmail.com writes: > * gnu/packages/compression.scm (unshield): New variable. [...] > @@ -40,6 +41,7 @@ > #:use-module (guix build-system gnu) > #:use-module (guix build-system perl) > #:use-module (guix build-system python) > + #:use-module (guix build-system cmake) > #:use-module (gnu packages) > #:use-module (gnu packages assembly) > #:use-module (gnu packages autotools) > @@ -50,6 +52,7 @@ > #:use-module (gnu packages pkg-config) > #:use-module (gnu packages python) > #:use-module (gnu packages valgrind) > + #:use-module (gnu packages tls) Please try to keep module imports, inputs, etc alphabetically sorted, when they are so from before. =20=20 > +(define-public unshield > + (package > + (name "unshield") > + (version "1.4.2") > + (source > + (origin (method url-fetch) > + (uri (string-append "http://github.com/twogood/unshield/arc= hive/" > + version ".tar.gz")) > + (sha256 > + (base32 > + "0x7ps644yp5dka2zhb8w0ifqmw3d255jafpzfwv8xbcpgq6fmm2x")))) > + (build-system cmake-build-system) > + (inputs > + `(("zlib" ,zlib) > + ("openssl" ,openssl))) > + (arguments > + `(#:tests? #f)) ; no test target There is a test script shipped with the source, can you try replacing the "check" phase with code that executes "./run_tests"? > + (home-page "https://github.com/twogood/unshield") > + (synopsis "Tool to extract CAB files.") > + (description "Extracts CAB files from InstallShield installers") So synopses should not end with punctuations, but descriptions do. `guix lint` should warn about this. It would be good to have a little more information here as well. Maybe something like this (minimal variant): (synopsis "Extract CAB files from InstallShield installers") (description "@command{unshield} is a tool and library for extracting @file{.cab} archives from InstallShield installers.") If this software works with the "normal" .cab files commonly found in MS Windows systems, it would be good to encapsulate that information too. Otherwise LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlj+EUAACgkQoqBt8qM6 VPphpgf7BXdaTgGljU2tuKzD+zMpZDNXretrdh+rHoAjjBRllGKA70q5mNJ5DfPN CQVJ5rupsAOy4b6RSpnbXoZn7E3AX5e+BcWuZ4g24/GeJJKHRVWx2spUA0+yfLv1 +zlK6p3cjBXEGFm6J7N567a1qMnoGmxgDU9yHD25vgHX1LIxETy/TfEyHHXjuHve +aoxY4RyQCq3P5KJVkjPjNG2uR6vX9IIQ8vs0cuumyynIq2Pg4A0TNAhqFqqVNaW zYmD8AxAIGHJTGk8ZPcBSALk7Ca6L4jUjwmqpy7wX0J/xdWlZGMh4jZRp9GYty7d DOKZ/qREUBF0i6WXbhTQyWgffN1CDg== =SBGn -----END PGP SIGNATURE----- --=-=-=--