From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 16:19:11 2017 Received: (at 26173) by debbugs.gnu.org; 20 Mar 2017 20:19:11 +0000 Received: from localhost ([127.0.0.1]:36722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cq3ln-0000xj-5f for submit@debbugs.gnu.org; Mon, 20 Mar 2017 16:19:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51975) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cq3ll-0000xX-AO for 26173@debbugs.gnu.org; Mon, 20 Mar 2017 16:19:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cq3lb-0003Pu-BZ for 26173@debbugs.gnu.org; Mon, 20 Mar 2017 16:19:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cq3lb-0003Po-8X; Mon, 20 Mar 2017 16:18:59 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:58886 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cq3la-0002hO-M1; Mon, 20 Mar 2017 16:18:59 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur Subject: Re: bug#26173: [PATCH 2/4] services: openssh: Add 'subsystems' option. References: <20170319163507.3583-1-clement@lassieur.org> <20170319163507.3583-2-clement@lassieur.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 =?utf-8?Q?Vent=C3=B4se?= an 225 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Mon, 20 Mar 2017 21:18:56 +0100 In-Reply-To: <20170319163507.3583-2-clement@lassieur.org> (=?utf-8?Q?=22Cl?= =?utf-8?Q?=C3=A9ment?= Lassieur"'s message of "Sun, 19 Mar 2017 17:35:05 +0100") Message-ID: <87r31ru2fj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26173 Cc: 26173@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Cl=C3=A9ment Lassieur skribis: > * gnu/services/ssh.scm (openssh-config-file): Add it. > ()[subsystems]: Add it. > * doc/guix.texi (Networking Services): Document it. [...] > +@item @code{subsystems} (default: @code{'(("sftp" "internal-sftp"))}) > +Configures external subsystems (e.g. file transfer daemon). > + > +This is a list of two-element lists, each of which containing the > +subsystem name and a command (with optional arguments) to execute upon > +subsystem request. > + > +The command @command{internal-sftp} implements an in-process SFTP server. Maybe you can add an @example for the external SFTP server, just to show what the syntax is like. Otherwise LGTM, thanks! Ludo=E2=80=99.