From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 15:55:44 2017 Received: (at 26173) by debbugs.gnu.org; 21 Mar 2017 19:55:44 +0000 Received: from localhost ([127.0.0.1]:38311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqPsc-0005Gp-FA for submit@debbugs.gnu.org; Tue, 21 Mar 2017 15:55:42 -0400 Received: from mail.lassieur.org ([83.152.10.219]:49812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cqPsa-0005Gg-Rs for 26173@debbugs.gnu.org; Tue, 21 Mar 2017 15:55:41 -0400 Received: from rodion (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 22ed5a1d (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Tue, 21 Mar 2017 19:55:38 +0000 (UTC) References: <87pohb7ayv.fsf@lassieur.org> <20170321000445.23129-1-clement@lassieur.org> <20170321000445.23129-2-clement@lassieur.org> <87a88e1zeq.fsf@gnu.org> User-agent: mu4e 0.9.18; emacs 25.2.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#26173: [PATCH 2/4] services: openssh: Add 'subsystems' option. In-reply-to: <87a88e1zeq.fsf@gnu.org> Date: Tue, 21 Mar 2017 20:55:37 +0100 Message-ID: <87zigeieva.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26173 Cc: 26173@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Ludovic Courtès writes: > Clément Lassieur skribis: > >> * gnu/services/ssh.scm (openssh-config-file): Add it. >> ()[subsystems]: Add it. >> * doc/guix.texi (Networking Services): Document it. > > [...] > >> +The command @command{internal-sftp} implements an in-process SFTP >> +server. Alternately, one can specify the @command{sftp-server} command: >> +@example >> +(service openssh-service-type >> + (openssh-configuration >> + (subsystems >> + '(("sftp" "/run/current-system/profile/libexec/sftp-server"))))) >> +@end example > > Maybe the example should use: > > `(("sftp" ,(file-append openssh "/libexec/sftp-server"))) > > which looks better IMO (assuming it works, but I think it does.) It works, done. > OK for you to push the whole series. Pushed! Clément