From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 28 02:50:12 2022 Received: (at 25957) by debbugs.gnu.org; 28 Mar 2022 06:50:12 +0000 Received: from localhost ([127.0.0.1]:57010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYjCe-0003am-Jq for submit@debbugs.gnu.org; Mon, 28 Mar 2022 02:50:12 -0400 Received: from flashner.co.il ([178.62.234.194]:51016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nYjCd-0003aX-05 for 25957@debbugs.gnu.org; Mon, 28 Mar 2022 02:50:11 -0400 Received: from localhost (unknown [5.102.239.82]) by flashner.co.il (Postfix) with ESMTPSA id A74AC40D0D; Mon, 28 Mar 2022 06:50:02 +0000 (UTC) Date: Mon, 28 Mar 2022 09:49:29 +0300 From: Efraim Flashner To: Maxime Devos Subject: Re: bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks Message-ID: Mail-Followup-To: Efraim Flashner , Maxime Devos , zimoun , 25957@debbugs.gnu.org References: <20170303215819.bttmrfsbhlxyipmy@abyayala> <20170303222743.wf777eedaauuof3f@abyayala> <20170304133242.towlmzdcm6x43hvi@abyayala> <86k0ff9has.fsf_-_@gmail.com> <8635l01x7a.fsf@gmail.com> <86lex10wwr.fsf@gmail.com> <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TzPdF/YzzWOLJluu" Content-Disposition: inline In-Reply-To: <6a325301e7cc55ee08652c67e49c3eb8a0802baa.camel@telenet.be> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25957 Cc: 25957@debbugs.gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --TzPdF/YzzWOLJluu Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 23, 2022 at 01:44:29PM +0100, Maxime Devos wrote: > zimoun schreef op wo 23-03-2022 om 11:45 [+0100]: > > > On Wed, 12 Jan 2022 at 20:07, Efraim Flashner > > > wrote: > > >=20 > > > > > =E2=80=A6the package redis is not a dependency of gitolite.=C2=A0= Therefore, > > > > > the > > > > > question is: is our Gitolite package working with Redis?=C2=A0 Ev= en > > > > > using the > > > > > /usr/bin one?=C2=A0 Idem for SVN. > > > > >=20 > > > > > Otherwise, I am favor to remove the 2 =E2=80=9Cproblematic=E2=80= =9D > > > > > references.=C2=A0=C2=A0 WDYT? > > > >=20 > > > > Or change it to search the $PATH for the binary, so it would just > > > > be > > > > 'redis-server' or 'svnserve' > > >=20 > > > Is our Gitolite package working with Redis?=C2=A0 If not, why try to > > > fix. ;-) > >=20 > > What is the status of this old bug [1]?=C2=A0 Is it actionable?=C2=A0 I= f yes, > > what > > is the action?=C2=A0 If no, let close it. :-)=C2=A0 WDYT? >=20 > Seems like all we have to do is 'substitute*' a '/usr/bin/svnserve' > into a '/gnu/store/...' (untested), so seems actionable to me. > Alternatively, as Efraim wrote, let it search the $PATH (that might be > useful if adding svnserve would increase the closure too much and it is > an optional dependency in practice?). I spent some time looking at gitolite and the service. As I understand it, with the exception of svnserve, it searches $PATH for a number of different binaries, including git-annex. I believe that this would only work if git-annex (and potentially other packages) are installed globally. In addition, git (not git-minimal) and openssh are propagated inputs AND wrapped. I haven't tested to see if wrapping only is enough. I think the best choice is to: A: Replace /usr/bin/svnserve with svnserve so it will just search $PATH, like it does with the other helpers. B: Adjust the service so that it automatically creates a variant (or just a wrapped version) of the package which is wrapped with a list of additional packages so that they can be in gitolite's path. If I were deploying this to an arm device I wouldn't want it wrapped with git-annex since it doesn't build, but would definitely want it for an x86_64 machine. I suppose we should try to find someone who is using the gitolite service and see if they can be our test subject for wrapping the package with optional addons. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --TzPdF/YzzWOLJluu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmJBWnIACgkQQarn3Mo9 g1F36A//TNGr5K6tptHG5aR4e6/StBJM5qrUJb/ldVQZ8yr0LpHQZF+PgHsdOX3S /thtlEwQuqVTnaBptF+9w8R35IowpDc1fwwQgy5zgKpFdH1r90ufFaNFm2YJ6Pep dLxpRyr3hxc3bOk6/B7cEfyBbD2A56qh4pLcGUrSbmfOH1VYZDKWNonBz1zZd4PC oyViPxFLWdXxblaSLo2CCxfKcsM0jmBV7VHgfOYaTrSvr+UStiKLf1Doib4Hfz2V ZnPq2oTv+tTr4gI7dSF5eOu4UtK45KcFLwuPWDNBw3s9dDeGcZ8ly6snbPFRhevU mAHo7rqkn1rpQLxAUYSZv35eZnpj2953TtekdCacHtrw+I9AhhBNwLhWJg3FF5By KkG9jbLp1d64UdTDCrxCte5XacS3mailiW0Oh2wzr/R5W42CntrVGPK1PSduyCe1 EzbkdnGd3lLpmk6IDhTrjh6vGq07QdsyH+i9vfEsTboM2sbAUeT4IQagYAYL4Q0H WFatKL4I00BUYI/cGfaxIO6Cc1566CI4YNkTCGf0Y6nOKMMjllZdOGXsQ3D/cm3T nyBDsIZc2PPSkC63CN9KNz3XWFiRqw4i9pmLe0KLTOsL8i+goYkSYxkWlI8rdqad HP75zsuJ8+uK/06SpwPRbodCr1CzGzMtCnXZjFhFAdL8K3zIF90= =KBfr -----END PGP SIGNATURE----- --TzPdF/YzzWOLJluu--