From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 04 15:18:20 2017 Received: (at 25879) by debbugs.gnu.org; 4 Mar 2017 20:18:20 +0000 Received: from localhost ([127.0.0.1]:40269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckG8C-00063n-Eh for submit@debbugs.gnu.org; Sat, 04 Mar 2017 15:18:20 -0500 Received: from mail-wr0-f175.google.com ([209.85.128.175]:33227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckG8A-00063Z-EV for 25879@debbugs.gnu.org; Sat, 04 Mar 2017 15:18:18 -0500 Received: by mail-wr0-f175.google.com with SMTP id u48so93353376wrc.0 for <25879@debbugs.gnu.org>; Sat, 04 Mar 2017 12:18:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Cztor7yibj60RA/Dls0wEFzqMCMIww/pfPuzzFNDcyU=; b=a46AxrQMiOIg5Kjm25H5zyf6kRZV6LUmANSM5wdJzs7Pp3YiV9PXHqXy2/L5RznBkn UAjd2Iqlk+EWdK+RsfcwQ1/fngSBVcr2xoLm52Y9lLX0hDW9cVwxlyV8o1jzadNyLJnU kePKl9IYvyc8LWNYzdf9Qfvf4Yi0AyagMWP+DcwTEbOLltNLtFN403Z/5Ixy0OnGJf+C XGAxHoZ+qPnAvRceIjKtoCbS+Rb5VvOGEl4Lt2+RXR8EdXDWTZ1AAjkA3jjzBdC0IRLh NlmO2dYWgWmeEQ7qRojZTDPu9eRjcYa3O2yMrtbDl1pnaOGbGNE4q4iHN92NME6+q1MH UrZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Cztor7yibj60RA/Dls0wEFzqMCMIww/pfPuzzFNDcyU=; b=G09pnmhrwlJsncz9HMxOxshUJp3rFLn+DSgccgKbci+1aMnAnXpORatjuTrgVgAE+Q ButqFzxcl01ZDVKr9929y2ojcnA4baI6hs33YDjf/AJy4a6J0fmGmdMikj1+UHufoc0c EoUHTkXhspJJCQE0+9w3mFDp2RkapadhV+IPe1f8cYnrT/J8FdtHv0ipOJijRdpg8UMi 8/3IQQisRV0C8OxI32M2mfgkDfRQfCFCkcfuorQntVcNPwxs9rKi5rFEqWV1EnTfCfv+ GDdv7ibpgn+plloHPqqK2p9wcOCF8p4gRnVJlaiuWPj6Wo0S+U5wX0Q0o9RqUK7n7xAI JljQ== X-Gm-Message-State: AMke39lxfRp6XyUgOmowvF6bvIDkur09d4+LTuE2jEcJX9DrZrjGfvTarv5ABQmDBjti6eRhANcxjW+F4HyD+w== X-Received: by 10.223.151.217 with SMTP id t25mr8961206wrb.95.1488658692806; Sat, 04 Mar 2017 12:18:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.192.23 with HTTP; Sat, 4 Mar 2017 12:18:12 -0800 (PST) In-Reply-To: <87shn12p2i.fsf@gnu.org> References: <87shn12p2i.fsf@gnu.org> From: Catonano Date: Sat, 4 Mar 2017 21:18:12 +0100 Message-ID: Subject: Re: bug#25879: [PATCH] gnu: Add LLVM and CLANG 3.9.1. To: Roel Janssen Content-Type: multipart/alternative; boundary=94eb2c1b45dc93a28e0549ed5ca8 X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 25879 Cc: 25879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --94eb2c1b45dc93a28e0549ed5ca8 Content-Type: text/plain; charset=UTF-8 2017-02-26 12:01 GMT+01:00 Roel Janssen : > Dear Guix, > > Here's a patch to add LLVM and CLANG 3.9.1. I need these to add > Darktable. It could be that I messed up the commit message. If I did, > please let me know the correct form. > > Thanks! > > Kind regards, > Roel Janssen > Ok, this has been sitting here or 6 days now, so even though I'm a beginner, I'll attempt an answer I consulted the gnu standard, here https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs and based on that, I would say that the lines * gnu/packages/llvm.scm (llvm-3.9.1): New variable. * gnu/packages/llvm.scm (clang-3.9.1): New variable. * gnu/packages/llvm.scm (clang-runtime-3.9.1): New variable. are ok What leaves me dubious is the "and" in the subject line The gnu standard doesn't mention anything about it but in the guix git repo log I can't see a single occurrence of an "and", probably because the habit is one patch per package So I would suggest you to break this into a patchset of 2 parts: one with llvm-3.9.1 with subject "[PATCH] gnu: Add LLVM" * gnu/packages/llvm.scm (llvm-3.9.1): New variable. and another one with subect Subject: [PATCH] gnu: Add CLANG 3.9.1 * gnu/packages/llvm.scm (clang-3.9.1): New variable. * gnu/packages/llvm.scm (clang-runtime-3.9.1): New variable. the sencond one will have clang-runtime-3.9.1 and clang-3.9.1 in it That should do As for if it builds and run, I'd leave that to someone else. My laptop overheats easily HTH ! --94eb2c1b45dc93a28e0549ed5ca8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
2017-02-26 12:01 GMT+01:00 = Roel Janssen <roel@gnu.org>:
Dear Guix,

Here's a patch to add LLVM and CLANG 3.9.1.=C2=A0 I need these to add Darktable.=C2=A0 It could be that I messed up the commit message.=C2=A0 If = I did,
please let me know the correct form.

Thanks!

Kind regards,
Roel Janssen


Ok, this has been sitting here or 6 days now, so even tho= ugh I'm a beginner, I'll attempt an answer

I consulted the gnu standard, = here

and based on that, I would say that the =C2=A0lines
* gnu/packages/llvm.scm (l= lvm-3.9.1): New variable.
* gnu/packages/ll= vm.scm (clang-3.9.1): New variable.
* gnu/p= ackages/llvm.scm (clang-runtime-3.9.1): New variable.

are ok

What leaves me= dubious is the "and" in the subject line

The gnu standard doesn&= #39;t mention anything about it but in the guix git repo log I can't se= e a single occurrence of an "and", probably because the habit is = one patch per package

So I would suggest you to break this into a patchset = of 2 parts: one with =C2=A0llvm-3.9.1 with subject=C2=A0
"[PATCH] gnu: Add LLVM"

* gnu/packages/llvm.scm = (llvm-3.9.1): New variable.=C2=A0=C2=A0
=
and another one with subect=C2=A0
Subject: [PATCH] gnu: Add CLANG 3.9.1

* gnu/packages/llvm.scm= (clang-3.9.1): New variable.
* gnu/packages/llvm.scm (clang-runt= ime-3.9.1): New variable.

the sencond one will have =C2=A0clang-runti= me-3.9.1 and clang-3.9.1 in it

That should do

As for if it builds and run, = I'd leave that to someone else. My laptop overheats easily

HTH !
<= /div>
--94eb2c1b45dc93a28e0549ed5ca8--