From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 20 09:23:04 2017 Received: (at 25787) by debbugs.gnu.org; 20 Feb 2017 14:23:04 +0000 Received: from localhost ([127.0.0.1]:46955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cforn-0002gn-JE for submit@debbugs.gnu.org; Mon, 20 Feb 2017 09:23:04 -0500 Received: from s01-out.spamexperts.axc.nl ([185.175.203.25]:40829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfork-0002g1-MN for 25787@debbugs.gnu.org; Mon, 20 Feb 2017 09:23:01 -0500 Received: from vserver42.axc.nl ([159.253.0.80]) by s01.spamexperts.axc.nl with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86) (envelope-from ) id 1cfore-0002d4-DG; Mon, 20 Feb 2017 15:22:54 +0100 Received: from mail.axc.nl ([159.253.0.157]:37680) by vserver42.axc.nl with esmtp (Exim 4.87) (envelope-from ) id 1cforb-0007yU-8A; Mon, 20 Feb 2017 15:22:51 +0100 Date: Mon, 20 Feb 2017 15:22:44 +0100 (CET) Message-Id: <20170220.152244.881122869261660698.post@thomasdanckaert.be> To: Pierre Langlois , 25787@debbugs.gnu.org Subject: Re: bug#25787: [PATCH 6/6] From: Thomas Danckaert X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit PrimaryMX: Accepted email from trusted host. Hint: This skips spam scanning so make sure other host is not vulnerable X-Relay-Host: 159.253.0.157 X-Spam-Score: 0.0 (/) X-Spam-Report: Spam detection software, running on the system "vserver42.axc.nl", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, thanks for the patch, I'd like to use clementine on Guix! I managed to build and run the program, but experienced some stability issues. Importing music into the library seemed to work fine, but I couldn't really play back files: [...] Content analysis details: (0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- SpamTally: Final spam score: 0 X-Originating-IP: 159.253.0.80 X-SpamExperts-Domain: vserver42.axc.nl X-SpamExperts-Username: 159.253.0.80 Authentication-Results: spamexperts.axc.nl; auth=pass smtp.auth=159.253.0.80@vserver42.axc.nl X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.05) X-Recommended-Action: accept X-Filter-ID: s0sct1PQhAABKnZB5plbIaExX4b9HB97Y0LqBeziPXa8B5kabb+8+DRlCqSxA333/bPom7IVowNb jNmNSGjlJADpxEq2QWue0NVTi1XPmXej1KRrf1Y8eevl1lZRQAkHO76XSTAwtV4mg4i2ouCDa4AU hvIWAV5xUW/+gAh4vXq3Bb+ZmrYvRFMMrncX61pQRcOb18WfxGyg6Om6u4YYm30ENGS07y4VJEAx 2DzoEMfEJmXb7Ar/H99E7t+JzjZEexI6JliONwAnIAZqFP/xQOWBOXp8nHKe0R+FkIqN7hkbx4Px vydb/x32mhLBChw5NNMPtXItjLG4t9x0O63zbyLpQCk9LN96ieg5guM8uFge9Gory97ytKcl8m2v CNJ8q16AUQgygDMMJTOfrbMny5ng/mkk3DMPbl3g5zFC4FfJ+LDk+6c65WNHYJFrd5FIBZ6++Dfk TVlBWsR5QGkluYsktHOcNcA7Yit+vIPIFAQmEqN5fXoI0ArDZbumk3L6kihXO2fRb8rpv65HbpOd qmjDv/9lZWhS1i8CvLmhSHJulq+YCc1Jf9I1b2AZYErcjxqVInDtyLKdhpFYlh+5i0pJkzvQFD0n 4ZCeWWj00iQamUdylUIKhf3z2GAHxH7IDucbqyPscDcg4YAFlcEg0Tzlt0qfM+8esN3hLUMHrXGv tIwVwtG3DC5ZfBJgPeIovZ1lzptptgCaKD2vAjUZLPpf6gRpr0cy1Rs9Y+3TGPm4JB1ks2EvBGu0 XnP7uzX+39Uh4ttSsZc8acEN4bpATlENVoJ7y9+G5+4XqiQ6ETamLQZxMhK2cg2102x6FacTl/p1 35YnYBday6MobZugOrNZxe01GfYTRQ24ZSOg6qs= X-Report-Abuse-To: spam@s01.spamexperts.axc.nl X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25787 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, thanks for the patch, I'd like to use clementine on Guix! I managed to build and run the program, but experienced some stability issues. Importing music into the library seemed to work fine, but I couldn't really play back files: - The first few times, the program segfaulted when I tried to play files (I tried mp3 and ogg). - Then I ran it in the debugger and it didn't segfault anymore. - Then I tried it again without the debugger, and it didn't segfault, but now my desktop (Gnome on GuixSD) froze (while the music kept playing). I had switch to a tty and restart xorg-server. Are you not experiencing stability issues? > gnu: Add qjson. > > * gnu/packages/qt.scm (qjson): New variable. > [...] > + ;; The tests require a X server > + ;; #:configure-flags '("-DQJSON_BUILD_TESTS=ON") > + `(#:tests? #f)) Have you tried (setenv "QT_QPA_PLATFORM" "offscreen") to try running the tests anyway? Another approach that is sometimes used is starting an X server with (system (format #f "~a/bin/Xvfb :1 &" xorg-server)) (setenv "DISPLAY" ":1") The rest of the patches look good to me. Hopefully someone else can comment on the cryptopp issue (I don't necessarily see why it is necessary to exclude it). cheers, Thomas