From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 07:13:52 2017 Received: (at 25733) by debbugs.gnu.org; 18 Feb 2017 12:13:52 +0000 Received: from localhost ([127.0.0.1]:44280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf3tg-0007nv-1w for submit@debbugs.gnu.org; Sat, 18 Feb 2017 07:13:52 -0500 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf3td-0007nn-Bg for 25733@debbugs.gnu.org; Sat, 18 Feb 2017 07:13:50 -0500 Received: from localhost (xd933e48a.dyn.telefonica.de [217.51.228.138]) by mx.zohomail.com with SMTPS id 1487420027559319.2715159444997; Sat, 18 Feb 2017 04:13:47 -0800 (PST) References: <20170214201602.10864-1-contact.ng0@cryptolab.net> <20170214201602.10864-7-contact.ng0@cryptolab.net> User-agent: mu4e 0.9.18; emacs 25.1.1 From: Ricardo Wurmus To: contact.ng0@cryptolab.net Subject: Re: bug#25733: [PATCH 07/18] gnu: Add python-repoze-lru. In-reply-to: <20170214201602.10864-7-contact.ng0@cryptolab.net> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Sat, 18 Feb 2017 13:13:44 +0100 Message-ID: <87poifsnlz.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 25733 Cc: ng0 , 25733@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) contact.ng0@cryptolab.net writes: > From: ng0 > > * gnu/packages/python.scm (python-repoze-lru): New variable. > --- > gnu/packages/python.scm | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > index c603d0778..fb296e712 100644 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -2030,6 +2030,31 @@ result back.") > (define-public python2-pytest-xdist > (package-with-python2 python-pytest-xdist)) > > +(define-public python-repoze-lru > + (package > + (name "python-repoze-lru") > + (version "0.6") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "repoze.lru" version)) > + (sha256 > + (base32 > + "0cdx3fq67qfcdrb3h9rjjcvks2zfrgyd834indncplqnywxk4yhg")))) > + (build-system python-build-system) > + (home-page "http://www.repoze.org") > + (synopsis "Tiny LRU cache implementation and decorator") Please expand “LRU”. > + (description > + "Repoze integrates Zope technologies with WSGI and reusable > Python middleware.") Both synopsis and description could be improved. The synopsis is better than the description. The fact that “Zope technologies” are used does not describe the package. > + (properties `((python2-variant . ,(delay python2-repoze-lru)))) I don’t think this is needed. > + (license license:repoze))) There is no such license. You could use “license:non-copyleft” here with “http://repoze.org/license.html” as the argument. > + > +(define-public python2-repoze-lru > + (let ((base (package-with-python2 > + (strip-python2-variant python-repoze-lru)))) > + (package > + (inherit base)))) > + This is really convoluted for no obvious gain. Why did you choose this over: (define-public python2-repoze-lru (package-with-python2 python-repoze-lru)) ? -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net