From debbugs-submit-bounces@debbugs.gnu.org Mon May 27 10:48:55 2019 Received: (at 24450) by debbugs.gnu.org; 27 May 2019 14:48:55 +0000 Received: from localhost ([127.0.0.1]:53766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVGvm-00082i-QW for submit@debbugs.gnu.org; Mon, 27 May 2019 10:48:54 -0400 Received: from b2062.mx.srv.dfn.de ([194.95.234.172]:40455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVGvk-00082X-HD for 24450@debbugs.gnu.org; Mon, 27 May 2019 10:48:53 -0400 Received: from localhost (localhost [127.0.0.1]) by b2062.mx.srv.dfn.de (Postfix) with ESMTP id 2890E16004F; Mon, 27 May 2019 16:48:44 +0200 (CEST) Received: from b2062.mx.srv.dfn.de ([127.0.0.1]) by localhost (mgw4-tub.srv.dfn.de [127.0.0.1]) (amavisd-new, port 20134) with ESMTP id l5IAVsJaufWg; Mon, 27 May 2019 16:48:43 +0200 (CEST) Received: from SW-IT-P-CAS4.mdc-berlin.net (mgw10-4.mdc-berlin.de [141.80.113.59]) by b2062.mx.srv.dfn.de (Postfix) with ESMTPS; Mon, 27 May 2019 16:48:43 +0200 (CEST) Received: from localhost (141.80.113.103) by SW-IT-P-CAS4.mdc-berlin.net (141.80.113.59) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 27 May 2019 16:48:43 +0200 References: <87pnod7ot4.fsf@gmail.com> User-agent: mu4e 1.2.0; emacs 26.2 From: Ricardo Wurmus To: Maxim Cournoyer Subject: Re: [PATCHv2] Re: pypi importer outputs strange character series in optional dependency case. In-Reply-To: <87pnod7ot4.fsf@gmail.com> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Mon, 27 May 2019 16:48:43 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [141.80.113.103] X-TM-AS-Product-Ver: SMEX-12.5.0.1684-8.5.1010-24642.000 X-TM-AS-Result: No-9.524500-8.000000-10 X-TMASE-MatchedRID: 9zTThWtzIms4HKI/yaqRm5VRzPxemJL0APiR4btCEeYGmHr1eMxt2XJ4 YYfr3pskNGN2QO49D7NirfDD/q34cbSmTEY5EtKkEhGH3CRdKUX17lAMINbrD5LBwsVwuMFlkUC 9nJY4BcKF1UGHNi9w/j3lvbv1AogjTI7bsVk48a9LJhhSkbJGJ84Vo5svdK3bmyiLZetSf8kir3 kOMJmHTBQabjOuIvShC24oEZ6SpSk6XEE7Yhw4FrVm+A+BcDL0F+M75rJrk5gkD9hASP4Qsl3Xp BUNWtS3oE3DXDY2aZJDDKa3G4nrLQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--9.524500-8.000000 X-TMASE-Version: SMEX-12.5.0.1684-8.5.1010-24642.000 X-TM-SNTS-SMTP: DFA70782A3E73A861C7CF5C64837616B73341718A1CCA009E2AC5C10C0B911142000:9 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24450 Cc: 24450@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, > Subject: [PATCH 1/9] import: pypi: Do not consider requirements.txt files. > > * guix/import/pypi.scm (guess-requirements): Update comment. > [guess-requirements-from-source]: Do not attempt to parse the file > requirements.txt. Streamline logic. Why remove the handling of the requirements.txt? Is it no longer popular enough to expect its availability in the source archives? Please also mention in the commit message that and how you adjusted the tests. You removed the comments from the example requires.txt =E2=80=94 are comments no longer permitted in these files? If they are, please don=E2=80= =99t include those changes. -- Ricardo