Hi Maxim, T460s laptop skribis: > From 37e499d5d5d5f690aa0a065c730e13f6a31dd30d Mon Sep 17 00:00:00 2001 > From: Maxim Cournoyer > Date: Thu, 28 Mar 2019 23:12:26 -0400 > Subject: [PATCH] import: pypi: Include optional test inputs as native-inputs. > > * guix/import/pypi.scm (maybe-inputs): Add INPUT-TYPE argument, and use it. > (test-section?): New predicate. > (parse-requires.txt): Collect the optional test inputs, and return them as the > second element of the returned list. > (parse-wheel-metadata): Likewise. > (guess-requirements): Adapt, and hide unzip output. > (make-pypi-sexp): Likewise, and include the test inputs requirements as native > inputs in the returned package expression. > > * tests/pypi.scm (test-requires.txt): Include a test section in the > test-requires.txt data. > (test-requires.txt-beaker): New variable. > ("parse-requires.txt"): Adapt. > ("parse-requires.txt - Beaker"): New test. > ("parse-wheel-metadata, with extras"): Adapt. > ("parse-wheel-metadata, with extras - Jedi"): Adapt. > ("pypi->guix-package, no wheel"): Re-indent, and add the expected > native-inputs. > ("pypi->guix-package, wheels"): Likewise. > ("pypi->guix-package, no usable requirement file."): New test. It seems that the patch does several unrelated things, such as silencing ‘unzip’, improving docstrings, handling inputs other than ‘propagated-inputs’, and correctly parsing wheels. Could you try to separate these as much as possible to simplify review? Thank you! Ludo’.