From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 06 15:13:12 2017 Received: (at 20272) by debbugs.gnu.org; 6 Mar 2017 20:13:12 +0000 Received: from localhost ([127.0.0.1]:43237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckz0J-0001xn-Mq for submit@debbugs.gnu.org; Mon, 06 Mar 2017 15:13:12 -0500 Received: from pb-sasl1.pobox.com ([64.147.108.66]:62937 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckz0H-0001xf-RM for 20272@debbugs.gnu.org; Mon, 06 Mar 2017 15:13:10 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id 38C2E7300F; Mon, 6 Mar 2017 15:13:09 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=OVrb6oS4tESm IsXdarFsaXsd5PU=; b=fELI/1n18JayuOFzNSuT4VUXD0/gZjUmp0+TwLTYrl+z LilJKu0chCcUbZ3svxYKSIJENEM0nz99FSGj/hhS3pEMsB0KRicwYZBVr4IHKmrG Suxry7iDHF65rNGVPgX1DWdOoQ1I8S3vHSqWjZZda/9wyALhrGztS6SvPuEySXg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=Lqda6I RRW5x6YfFOnBAnhSp5IgJeQQU9O5Qw6/SCB5jMEA4V3xMIGWB78LFfLmNuCMKq+B PeoHCBAIAWEb6H46uJqyNBDxLQwsAGBk2mhciECIEOO+aJGxxV62V/yColc0Jfxw yrmZDX/5FfYuyOHH0sy2Yc3JeKzKfGSoqMZYI= Received: from pb-sasl1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id 315067300E; Mon, 6 Mar 2017 15:13:09 -0500 (EST) Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id 5D4DD7300D; Mon, 6 Mar 2017 15:13:07 -0500 (EST) From: Andy Wingo To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: bug#20272: Support reproducible builds References: <87bmxxnjd7.fsf@gnu.org> <87shqtwxcb.fsf@gnu.org> <87twa6iikd.fsf@gnu.org> <87vaumgk80.fsf@gnu.org> <87mvfygjs1.fsf@gnu.org> <87eg12fbog.fsf@gnu.org> <871sx0vnyn.fsf@gnu.org> <87efyio399.fsf@pobox.com> <8737er5tzd.fsf@gnu.org> Date: Mon, 06 Mar 2017 21:13:00 +0100 In-Reply-To: <8737er5tzd.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 05 Mar 2017 21:49:58 +0100") Message-ID: <87varm9nar.fsf@pobox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: 50BFA772-02A9-11E7-84DF-B667064AB293-02397024!pb-sasl1.pobox.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 20272 Cc: 20272@debbugs.gnu.org, Mark H Weaver , Jan Nieuwenhuizen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Hi, On Sun 05 Mar 2017 21:49, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Andy Wingo skribis: > >> On Thu 22 Dec 2016 00:53, ludo@gnu.org (Ludovic Court=C3=A8s) writes: >> >>> +(define (module-generate-unique-id! m) >>> + (let ((i (module-next-unique-id m))) >>> + (set-module-next-unique-id! m (+ i 1)) >>> + i)) >> >> This introduces a race condition when expanding from multiple threads at >> once. Any plan here? > > Good point! We could grab a per-module mutex for that, though that=E2=80= =99s > again a fat mutex. > > Thoughts? I would use atomic boxes if possible, but they are in another module :/ Even mutexes aren't directly available in boot-9 any more... Alternately we can make a new primitive for module-generate-unique-id! which can obviously use C. That's probably the easiest option, sadly! Andy