[PATCH emacs-team 00/45] Test emacs packages by default

Open

Details

2 participants

Morgan Smith
Liliana Marie Prikler

Owner: unassigned

Submitted by: Liliana Marie Prikler

Severity: normal

Debbugs page

Liliana Marie Prikler wrote 2 weeks ago

Recipients:(address . guix-patches@gnu.org)

Message-ID:cover.1740925543.git.liliana.prikler@gmail.com

Hi folks,

this patch adds code – similar to what we have in other ecosystems – to
make an educated guess on what test framework is used and use it.  Newly
packaged Emacs libraries should thus expect to be tested with tests
needing to be explicitly disabled otherwise; just like in the rest of
Guix.

Cheers

Liliana Marie Prikler (45):
  build-system: emacs: Enable tests when not cross-compiling.
  build-system: emacs: Guess test framework.
  gnu: emacs-el-mock: Add missing inputs.
  gnu: emacs-epl: Add missing input.
  gnu: emacs-list-utils: Provide test command.
  gnu: emacs-helpful: Fix build.
  gnu: emacs-helpful: Use implicit “ert-runner”.
  gnu: emacs-popup: Fix build.
  gnu: emacs-auto-complete: Fix build.
  gnu: emacs-shrink-path: Add missing input.
  gnu: emacs-yasnippet: Fix build.
  gnu: emacs-elpy: Record failing tests for Emacs 30.
  gnu: emacs-elpy: Use implicit “ert-runner”.
  gnu: emacs-ac-php: Use implicit “ert-runner”.
  gnu: emacs-pug-mode: Use implicit “ert-runner”.
  gnu: emacs-graphql: Use implicit “ert-runner”.
  gnu: emacs-relative-buffers: Use implicit “ert-runner”.
  gnu: emacs-go-mode: Use implicit “ert-runner”.
  gnu: emacs-string-inflection: Use implicit “ert-runner”.
  gnu: emacs-elquery: Use implicit “ert-runner”.
  gnu: emacs-cov: Use implicit “ert-runner”.
  gnu: emacs-skeletor: Use implicit “ert-runner”.
  gnu: emacs-mocker: Use implicit “ert-runner”.
  gnu: emacs-pyvenv: Use implicit “ert-runner”.
  gnu: emacs-islisp-mode: Use implicit “ert-runner”.
  gnu: emacs-ht: Use implicit “ert-runner”.
  gnu: emacs-json-reformat: Use implicit “ert-runner”.
  gnu: emacs-browse-at-remote: Use implicit “ert-runner”.
  gnu: emacs-groovy-modes: Use implicit “ert-runner”.
  gnu: emacs-loop: Use implicit “ert-runner”.
  gnu: emacs-elisp-refs: Use implicit “ert-runner”.
  gnu: emacs-suggest: Use implicit “ert-runner”.
  gnu: emacs-dumb-jump: Use implicit “ert-runner”.
  gnu: emacs-helm-company: Use implicit “ert-runner”.
  gnu: emacs-deadgrep: Use implicit “ert-runner”.
  gnu: emacs-racer: Use implicit “ert-runner”.
  gnu: emacs-libmpdel: Use implicit “ert-runner”.
  gnu: emacs-navigel: Use implicit “ert-runner”.
  gnu: emacs-detached: Use implicit “ert-runner”.
  gnu: emacs-bfuture: Use implicit “ert-runner”.
  gnu: emacs-tco-el: Use implicit “ert-runner”.
  gnu: emacs-dash-docs: Use implicit “ert-runner”.
  gnu: emacs-doom-themes: Use implicit “ert-runner”.
  gnu: emacs-doom-modeline: Use implicit “ert-runner”.
  gnu: emacs-org-cliplink: Use implicit “ert-runner”.

 gnu/local.mk                                  |   1 +
 gnu/packages/emacs-xyz.scm                    | 409 +++++-------------
 .../patches/emacs-helpful-fix-signature.patch |  34 ++
 .../patches/emacs-helpful-fix-tests.patch     |  20 +-
 guix/build-system/emacs.scm                   |   4 +-
 guix/build/emacs-build-system.scm             |  35 +-
 6 files changed, 186 insertions(+), 317 deletions(-)
 create mode 100644 gnu/packages/patches/emacs-helpful-fix-signature.patch


base-commit: 725917beddf8454f92d01de7a3cfcc283100f43b
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 02/45] build-system: emacs: Guess test framework.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:fb1c9146c2f0ef5f7b6eee843cc48ba749685b73.1740925543.git.liliana.prikler@gmail.com

* guix/build/emacs-build-system (check-command): New variable.
(check): Use it.
* guix/build-system/emacs.scm (emacs-build)[test-command]: Set to #f.
---
 guix/build-system/emacs.scm       |  2 +-
 guix/build/emacs-build-system.scm | 35 ++++++++++++++++++++-----------
 2 files changed, 24 insertions(+), 13 deletions(-)

Toggle diff (66 lines)diff --git a/guix/build-system/emacs.scm b/guix/build-system/emacs.scm
index 2ec08fe8783..fc165c21d78 100644
--- a/guix/build-system/emacs.scm
+++ b/guix/build-system/emacs.scm
@@ -84,7 +84,7 @@ (define* (emacs-build name inputs
                       #:key source
                       (tests? (not (%current-target-system)))
                       (parallel-tests? #t)
-                      (test-command ''("make" "check"))
+                      (test-command #f) ; inferred in emacs-build-system
                       (phases '%standard-phases)
                       (outputs '("out"))
                       (include (quote %default-include))
diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-system.scm
index aa083c64094..ff35547968b 100644
--- a/guix/build/emacs-build-system.scm
+++ b/guix/build/emacs-build-system.scm
@@ -223,23 +223,34 @@ (define* (ensure-package-description #:key outputs #:allow-other-keys)
   (let ((name (store-directory->elpa-name-version (assoc-ref outputs "out"))))
     (and=> (find-root-library-file name) write-pkg-file)))
 
-(define* (check #:key tests? (test-command '("make" "check"))
+(define (check-command test-command)
+  (cond
+   (test-command test-command)
+   ((which "buttercup") '("buttercup" "-L" "."))
+   ((which "ert-runner") '("ert-runner"))
+   ((file-exists? "Makefile") '("make" "check"))
+   (else #f)))
+
+(define* (check #:key tests? test-command
                 (parallel-tests? #t) #:allow-other-keys)
   "Run the tests by invoking TEST-COMMAND.
 
 When TEST-COMMAND uses make and PARALLEL-TESTS is #t, the tests are run in
 parallel. PARALLEL-TESTS? is ignored when using a non-make TEST-COMMAND."
-  (match-let (((test-program . args) test-command))
-    (let ((using-make? (string=? test-program "make")))
-      (if tests?
-          (apply invoke test-program
-                 `(,@args
-                   ,@(if (and using-make? parallel-tests?)
-                         `("-j" ,(number->string (parallel-job-count)))
-                         '())))
-          (begin
-            (format #t "test suite not run~%")
-            #t)))))
+  (match (and tests? (check-command test-command))
+    ((test-program . args)
+     (let ((using-make? (string=? test-program "make")))
+       (apply invoke test-program
+              `(,@args
+                ,@(if (and using-make? parallel-tests?)
+                      `("-j" ,(number->string (parallel-job-count)))
+                      '())))))
+    (#f
+     (if tests?
+         (begin
+           (display "warning: test system not found.\n")
+           (display "note: this will be an error in the future.\n"))
+         (display "test suite not run\n")))))
 
 (define* (install #:key outputs
                   (include %default-include)
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 03/45] gnu: emacs-el-mock: Add missing inputs.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:3fab610e1fd89397f92afe43372bc3552198c872.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-el-mock)[native-inptus]: Add
emacs-ert-runner, emacs-ert-expectations, and emacs-undercover.
---
 gnu/packages/emacs-xyz.scm | 3 +++
 1 file changed, 3 insertions(+)

Toggle diff (16 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d7e28d7aa44..2923f25f962 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7532,6 +7532,9 @@ (define-public emacs-el-mock
          (sha256
           (base32 "09c3a1771v6kliwj0bn953pxxyjlk6q9kp31cxcr0nraik7d0mhk"))))
       (build-system emacs-build-system)
+      (native-inputs (list emacs-ert-runner
+                           emacs-ert-expectations
+                           emacs-undercover))
       (home-page "https://github.com/rejeep/el-mock.el")
       (synopsis "Tiny mock and stub framework in Emacs Lisp")
       (description
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 04/45] gnu: emacs-epl: Add missing input.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:2c47ef1dfa299f15fc8b63ea2a2c922ee8270e59.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-epl)[native-inptus]: Add emacs-ert-runner.

---

gnu/packages/emacs-xyz.scm | 1 +

1 file changed, 1 insertion(+)

Toggle diff (14 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2923f25f962..81351838e1c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15016,6 +15016,7 @@ (define-public emacs-epl
        (sha256
         (base32 "0d3z5z90ln8ipk1yds1n1p8fj9yyh2kpspqjs7agl38indra3nb4"))))
     (build-system emacs-build-system)
+    (native-inputs (list emacs-ert-runner))
     (home-page "https://github.com/cask/epl")
     (synopsis "Emacs Package Library")
     (description
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 01/45] build-system: emacs: Enable tests when not cross-compiling.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:c99635f1113a4c9224d465e59cd1d45abe033691.1740925543.git.liliana.prikler@gmail.com

This is a first effort towards making emacs-build-system more suitable for
cross-compilation.

* guix/build-system/emacs.scm (emacs-build)[#:tests?]: Enable when not
cross-compiling.
* gnu/packages/emacs-xyz.scm (emacs-ac-php, emacs-inspector)
(emacs-tree-inspector, emacs-pug-mode, emacs-llama, emacs-magit)
(emacs-speed-type, emacs-graphql, emacs-fb2-reader, emacas-ample-regexps)
(emacs-relative-buffers, emacs-aio, emacs-async, emacs-latex-extra)
(emacs-auto-themer, emacs-bm, emacs-varuga, emacs-org-fc, emacs-go-mode)
(emacs-dash, emacs-undo-fu-session, emacs-s, emacs-lemon, emacs-fringe-helper)
(emacs-git-link, emacs-explain-pause-mode, emacs-calc-currency)
(emacs-string-inflection, emacs-ob-go, emacs-robot-log, emacs-rspec)
(emacs-sqlite3-api, emacs-shx, emacs-el-job, emacs-elisp-demos)
(emacs-sudo-edit, emacs-subed, emacs-deferred, emacs-company-lsp, emacs-jack)
(emacs-elquery, emacs-cov, emacs-god-mode, emacs-org-pomodoro)
(emacs-eglot-tempel, emacs-dumbparens, emacs-perspective, emacs-realgud)
(emacs-hydra, emacs-avy,emacs-lispy, emacs-clojure-mode, emacs-qt-pro-mode)
(emacs-sphinx-doc, emacs-julia-mode, emacs-js2-mode, emacs-nodejs-repl)
(emacs-projectile, emacs-skeletor, emacs-elfeed, emacs-elfeed-org)
(emacs-mocker, emacs-find-file-in-project, emacs-pyvenv, emacs-elpy)
(emacs-rainbow-delimiters, emacs-visual-replace, emacs-wucuo, emacs-yaml)
(emacs-wgrep, emacs-islisp-mode, emacs-lua-mode, emacs-evil-collection)
(emacs-evil-owl, emacs-evil-exchange, emacs-evil-lion, emacs-evil-expat)
(emacs-monky, emacs-org, emacs-ht, emacs-yasnippet, emacs-memoize)
(emacs-use-package, emacs-xmlgen, emacs-cc-mode, emacs-php-mode)
(emacs-evil-surround, emacs-org-transclusion, emacs-json-reformat)
(emacs-display-wttr, emacs-git-messenger, emacs-enh-ruby-mode)
(emacs-browse-at-remote, emacs-tiny, emacs-unidecode, emacs-circe)
(emacs-evil-quickscope, emacs-groovy-modes, emacs-kotlin-mode, emacs-kv)
(emacs-auth-source-pass, emacs-emacsql, emacs-org-recur)
(emacs-org-super-agenda, emacs-ts, emacs-circadian, emacs-eldev, emacs-citar)
(emacs-loop, emacs-elisp-refs, emacs-esup, emacs-macrostep, emacs-parent-mode)
(emacs-helpful, emacs-suggest, emacs-auto-yasnippet)
(emacs-git-auto-commit-mode, emacs-devil, emacs-devil-multiedit)
(emacs-go-translate, emacs-langtool, emacs-helm-company, emacs-picpocket)
(emacs-srht, emacs-github-review, emacs-deadgrep, emacs-adoc-mode)
(emacs-racer, emacs-sesman, emacs-buttercup, emacs-cort, emacs-annalist)
(emacs-general, emacs-libmpdel, emacs-navigel, emacs-eat, emacs-detached)
(emacs-repology, emacs-bfuture, emacs-undo-propose-el, emacs-tco-el)
(emacs-vdiff, emacs-exwm-firefox, emacs-rjsx-mode, emacs-dash-docs)
(emacs-casual-lib, emacs-evil-numbers, emacs-evil-traces, emacs-ox-tufte)
(emacs-org-jira, emacs-systemd-mode, emacs-doom-themes, emacs-exiftool)
(emacs-qrencode, emacs-org-journal, emacs-weblorg, emacs-execline)
(emacs-webpaste, emacs-keystore-mode, emacs-ein, emacs-straight-el)
(emacs-org-cliplink, emacs-x509-mode)[arguments]: Remove #:tests?.
(emacs-f, emacs-shut-up, emacs-ansi, emacs-commander)
(emacs-ert-runner)[arguments]: Add #:tests? #f.
(emacs-el-x, emacs-pkg-info, emacs-helm, emacs-tablist, emacs-ghub)
(emacs-with-editor, emacs-repo): Likewise.
---
 gnu/packages/emacs-xyz.scm  | 330 ++++++++++--------------------------
 guix/build-system/emacs.scm |   2 +-
 2 files changed, 89 insertions(+), 243 deletions(-)

Toggle diff (419 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 272be3a275d..d7e28d7aa44 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -365,7 +365,6 @@ (define-public emacs-ac-php
     (build-system emacs-build-system)
     (arguments
      (list
-      #:tests? #true
       #:test-command #~(list "ert-runner")))
     (inputs
      (list emacs-auto-complete
@@ -955,7 +954,6 @@ (define-public emacs-inspector
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #t
         #:test-command #~(list "emacs" "-Q" "--batch"
                                "-l" "inspector.el"
                                "-l" "inspector-tests.el"
@@ -1013,7 +1011,6 @@ (define-public emacs-tree-inspector
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #true
         #:test-command #~(list "emacs" "-Q" "--batch"
                                "-L" "."
                                "-l" "tree-inspector-tests.el"
@@ -1374,7 +1371,6 @@ (define-public emacs-pug-mode
     (build-system emacs-build-system)
     (arguments
      (list
-      #:tests? #t
       #:test-command #~(list "ert-runner")))
     (home-page "https://github.com/hlissner/emacs-pug-mode")
     (synopsis "Pug support for Emacs")
@@ -1703,6 +1699,7 @@ (define-public emacs-with-editor
     (build-system emacs-build-system)
     (arguments
      (list
+      #:tests? #f                       ; no test suite
       #:phases
       #~(modify-phases %standard-phases
           (add-before 'install 'enter-lisp-directory
@@ -1830,8 +1827,7 @@ (define-public emacs-llama
                 "0f2v1fw5iahlh0ypbwxfpav48h43h0zqqmicgs2hg7r251ss2j8j"))))
     (build-system emacs-build-system)
     (arguments
-     (list #:tests? #true
-           #:test-command #~(list "emacs" "-Q" "--batch"
+     (list #:test-command #~(list "emacs" "-Q" "--batch"
                                   "-l" "llama.el"
                                   "-f" "ert-run-tests-batch-and-exit")))
     (propagated-inputs (list emacs-compat))
@@ -1883,7 +1879,6 @@ (define-public emacs-magit
     (build-system emacs-build-system)
     (arguments
      (list
-      #:tests? #t
       #:test-command #~(list "make" "test")
       #:exclude #~(cons* "magit-libgit.el"
                          "magit-libgit-pkg.el"
@@ -2541,7 +2536,6 @@ (define-public emacs-speed-type
     (build-system emacs-build-system)
     (arguments
      (list
-      #:tests? #true
       #:test-command
       #~(list "emacs" "-Q" "--batch" "-L" "."
               "-l" "test-speed-type.el"
@@ -2581,7 +2575,6 @@ (define-public emacs-graphql
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #true
         #:test-command #~(list "ert-runner")
         #:phases
         #~(modify-phases %standard-phases
@@ -2679,6 +2672,7 @@ (define-public emacs-ghub
     (build-system emacs-build-system)
     (arguments
      (list
+      #:tests? #f                       ; no test suite
       #:phases
       #~(modify-phases %standard-phases
           (add-before 'install 'make-info
@@ -3094,7 +3088,6 @@ (define-public emacs-fb2-reader
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #t
         #:test-command
         #~(list "buttercup" "-L" ".")
         #:phases
@@ -3570,8 +3563,7 @@ (define-public emacs-ample-regexps
       (native-inputs
        (list emacs-ert-runner))
       (arguments
-       `(#:tests? #t
-         #:test-command '("ert-runner" "-l" "ample-regexps")))
+       `(#:test-command '("ert-runner" "-l" "ample-regexps")))
       (home-page "https://github.com/immerrr/ample-regexps.el")
       (synopsis "Compose and reuse Emacs regexps")
       (description
@@ -3736,7 +3728,6 @@ (define-public emacs-relative-buffers
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #t
         #:test-command #~(list "ert-runner")))
       (native-inputs
        (list emacs-ert-runner))
@@ -4899,8 +4890,7 @@ (define-public emacs-aio
                 "1y7j10j74r3fy0rcb8g3cm9nlls34qb0pz9xkia7psp77syrlz54"))))
     (build-system emacs-build-system)
     (arguments
-     `(#:tests? #t
-       #:test-command '("emacs" "--batch"
+     `(#:test-command '("emacs" "--batch"
                         "-l" "aio-test.el"
                         "-f" "ert-run-tests-batch-and-exit")))
     (propagated-inputs
@@ -4929,8 +4919,7 @@ (define-public emacs-async
                 "0krg7n8l3yv1fnixnx6j5imdh10jpfabm6ym9s1s610hp47gpfaz"))))
     (build-system emacs-build-system)
     (arguments
-     `(#:tests? #t
-       #:test-command '("buttercup" "-L" ".")))
+     `(#:test-command '("buttercup" "-L" ".")))
     (native-inputs
      (list emacs-buttercup))
     (synopsis "Asynchronous processing in Emacs")
@@ -5012,7 +5001,6 @@ (define-public emacs-latex-extra
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #true
         #:test-command
         #~(list "emacs" "-Q" "--batch"
                 "--eval=(cd \"tests/\")"
@@ -5077,7 +5065,6 @@ (define-public emacs-autothemer
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #true
         #:test-command #~(list "emacs" "-Q" "--batch"
                                "-l" "tests/autothemer-tests.el"
                                "-f" "ert-run-tests-batch-and-exit")))
@@ -5161,7 +5148,6 @@ (define-public emacs-bm
     (build-system emacs-build-system)
     (arguments
      (list
-      #:tests? #true
       #:test-command #~(list "emacs" "-Q" "--batch"
                              "-l" "bm-tests.el"
                              "-f" "ert-run-tests-batch-and-exit")))
@@ -5210,7 +5196,6 @@ (define-public emacs-varuga
         (base32
          "01hlnhqhys8qzfwhza1ypc436zg5lhlkx5yy71bhmrbmyfzfh0fr"))))
     (build-system emacs-build-system)
-    (arguments (list #:tests? #t))
     (home-page "https://git.systemreboot.net/varuga/about/")
     (synopsis "Send iCal calendar invites by email")
     (description
@@ -5659,7 +5644,6 @@ (define-public emacs-org-fc
      (list
       #:include #~(cons* "\\.awk$" "\\.org$" %default-include)
       #:exclude #~(cons "^tests/" %default-exclude)
-      #:tests? #t
       #:test-command #~(list "emacs" "--batch"
                              "-L" "."
                              "-L" "tests/"
@@ -5903,7 +5887,6 @@ (define-public emacs-go-mode
                   "00qzn136d8cl3szbi44xf3iiv75r6n1m7wwgldmzn4i5mpz8dbq7"))))
       (arguments
        (list
-        #:tests? #t
         #:test-command #~(list "ert-runner")
         #:phases
         #~(modify-phases %standard-phases
@@ -6191,6 +6174,7 @@ (define-public emacs-tablist
                (base32
                 "11vmvrhmsxy97bfj7jndpc58bik7177i3wvc45mlyldxwyirs962"))))
     (build-system emacs-build-system)
+    (arguments (list #:tests? #f))      ; no test suite
     (home-page "https://github.com/politza/tablist")
     (synopsis "Extension for @code{tabulated-list-mode}")
     (description "Tablist is the Emacs package that provides several
@@ -6513,8 +6497,7 @@ (define-public emacs-dash
                 "0z6f8y1m9amhg427iz1d4xcyr6n0kj5w7kmiz134p320ixsdnzd8"))))
     (build-system emacs-build-system)
     (arguments
-     (list #:tests? #t
-           #:phases
+     (list #:phases
            #~(modify-phases %standard-phases
                (add-after 'unpack 'disable-byte-compile-error-on-warn
                  (lambda _
@@ -6969,7 +6952,6 @@ (define-public emacs-undo-fu-session
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #t
         ;; The tests require temp files handling which a recent change disabled
         ;; by default. We re-enable it here to make tests work again.
         #:test-command #~(list "emacs" "--batch" "--eval"
@@ -7002,8 +6984,7 @@ (define-public emacs-s
         (base32 "010i92kagqbfis46n1ffa28fgkdkjp55n13b6f4izar5r7ixm6wx"))))
     (build-system emacs-build-system)
     (arguments
-     `(#:tests? #t
-       #:test-command '("./run-tests.sh")))
+     `(#:test-command '("./run-tests.sh")))
     (home-page "https://github.com/magnars/s.el")
     (synopsis "Emacs string manipulation library")
     (description "This package provides an Emacs library for manipulating
@@ -7105,8 +7086,6 @@ (define-public emacs-lemon
     (build-system emacs-build-system)
     (arguments
      (list
-      #:tests? #true
-
       ;; Only one test out of the four passes
       #:test-command #~(list "emacs" "-Q" "--batch" "-L" "."
                              ;; "-l" "lemon--test.el"
@@ -7259,6 +7238,7 @@ (define-public emacs-f
                (base32
                 "0ccrcfhqfbv9qff38sfym69mai7k7z89yndi6nip8wi5hpd2addc"))))
     (build-system emacs-build-system)
+    (arguments (list #:tests? #f))      ; circular dependency on ert-runner
     (propagated-inputs
      (list emacs-s emacs-dash))
     (home-page "https://github.com/rejeep/f.el")
@@ -7310,8 +7290,7 @@ (define-public emacs-fringe-helper
           (base32 "0ra9rc53l1gvkqank8apasl3r7wz2yfjrcvmfk3wpxhh24ppxv9d"))))
       (build-system emacs-build-system)
       (arguments
-       `(#:tests? #t
-         #:test-command '("emacs" "--batch"
+       `(#:test-command '("emacs" "--batch"
                           "-l" "tests.el"
                           "-f" "ert-run-tests-batch-and-exit")))
       (home-page "https://github.com/nschum/fringe-helper.el")
@@ -7388,7 +7367,6 @@ (define-public emacs-git-link
     (build-system emacs-build-system)
     (arguments
      (list
-      #:tests? #t
       #:test-command #~(list "make" "test")))
     (home-page "https://github.com/sshaw/git-link")
     (synopsis "Create links for files and commits in GitHub/GitLab/etc. repos")
@@ -7777,8 +7755,7 @@ (define-public emacs-explain-pause-mode
       (native-inputs
        (list emacs-buttercup))
       (arguments
-       '(#:tests? #t
-         #:phases
+       '(#:phases
          (modify-phases %standard-phases
            ;; This causes the byte-compilation before unit-tests to fail.
            (add-after 'unpack 'remove-error-on-warn
@@ -8082,7 +8059,6 @@ (define-public emacs-zig-mode
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #t
         #:emacs emacs
         #:test-command #~(list "emacs" "--batch"
                                "-l" "zig-mode.el"
@@ -8195,6 +8171,7 @@ (define-public emacs-shut-up
        (sha256
         (base32 "1bnmrwrhra6cpc3jjgwwzrydj5ps7q2dlkh2ag4j7rkyv4dlk351"))))
     (build-system emacs-build-system)
+    (arguments (list #:tests? #f))      ; circular dependency on ert-runner
     (home-page "https://github.com/cask/shut-up")
     (synopsis "Silence Emacs")
     (description "This package silences most output of Emacs when running an
@@ -8380,7 +8357,6 @@ (define-public emacs-calc-currency
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #t
         #:test-command #~(list "emacs" "--batch"
                                "-L" "."
                                "-l" "test/calc-currency-init.el"
@@ -8484,8 +8460,7 @@ (define-public emacs-string-inflection
     (native-inputs
      (list emacs-ert-runner))
     (arguments
-     `(#:tests? #t
-       #:test-command '("ert-runner")))
+     `(#:test-command '("ert-runner")))
     (home-page "https://github.com/akicho8/string-inflection")
     (synopsis "Convert symbol names between different naming conventions")
     (description
@@ -8792,7 +8767,6 @@ (define-public emacs-ob-go
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #t
         #:test-command #~(list "emacs" "--batch" "-L" "."
                                "--eval=(require 'ob-go)"
                                "-l" "test-ob-go.el"
@@ -8980,7 +8954,6 @@ (define-public emacs-robot-log
                 "1l9yxryrhvylh2x17cczd8v8978w1nv8173d4l9hv0cr26kp5b68"))))
     (build-system emacs-build-system)
     (native-inputs (list python-robotframework))
-    (arguments (list #:tests? #t))
     (home-page "https://sr.ht/~apteryx/emacs-robot-log/")
     (synopsis "Emacs major mode for viewing RobotFramework debug log files")
     (description "@code{robot-log} is an Emacs major mode that allows more
@@ -9060,7 +9033,6 @@ (define-public emacs-rspec
       (build-system emacs-build-system)
       (arguments
        `(#:include (cons "^snippets\\/rspec-mode\\/" %default-include)
-         #:tests? #t
          #:test-command '("make" "test")))
       (home-page "https://github.com/pezra/rspec-mode")
       (synopsis "Provides a rspec mode for working with RSpec")
@@ -9241,7 +9213,6 @@ (define-public emacs-sqlite3-api
     (build-system emacs-build-system)
     (arguments
      (list
-      #:tests? (not (%current-target-system))
       #:test-command #~(list "make" "test" "EMACS=emacs")
       #:modules '((guix build emacs-build-system)
                   (guix build emacs-utils)
@@ -9394,7 +9365,6 @@ (define-public emacs-shx
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #t
         #:test-command
         #~(list "emacs" "--batch" "--quiet" "--script" "test/script.el")
         #:phases
@@ -9799,8 +9769,7 @@ (define-public emacs-el-job
                 "0mj92dsd169ij2g3vmq626vdh5aqc9zbc43yjip7dl1qy4lh34sk"))))
     (build-system emacs-build-system)
     (arguments
-     (list #:tests? #true
-           #:test-command #~(list "emacs" "-Q" "--batch"
+     (list #:test-command #~(list "emacs" "-Q" "--batch"
                                   "-l" "el-job-test.el"
                                   "-f" "ert-run-tests-batch-and-exit")))
     (propagated-inputs (list emacs-compat))
@@ -9832,7 +9801,6 @@ (define-public emacs-elisp-demos
     (arguments
      (list
       #:include #~(cons* "\\.org$" %default-include)
-      #:tests? #t
       #:test-command #~(list "make" "test")))
     (home-page "https://github.com/xuchunyang/elisp-demos/")
     (synopsis "Enhance @code{*Help*} buffers with additional examples")
@@ -9943,7 +9911,6 @@ (define-public emacs-sudo-edit
             (lambda _
               (substitute* "Makefile"
                 (("\\$\\(CASK\\) exec ") "")))))
-      #:tests? #t
       #:test-command #~(list "make" "test")))
     (home-page "https://github.com/nflath/sudo-edit/")
     (synopsis "Open files as another user")
@@ -9965,7 +9932,6 @@ (define-public emacs-subed
                 "0bvsv688mqhga8dffy3841wxs5pkw0vish15dgligll47cj98mzp"))))
     (arguments
      (list
-      #:tests? #t
       #:test-command #~(list "buttercup" "-L" ".")))
     (native-inputs (list emacs-buttercup))
     (inputs (list ffmpeg))
@@ -10217,7 +10183,6 @@ (define-public emacs-deferred
            (lambda _
              (substitute* "Makefile"
                (("\\$\\(CASK\\) exec ") "")))))
-       #:tests? #t
        #:test-command '("make" "test")))
     (native-inputs
      (list emacs-ert-expectations emacs-ert-runner emacs-undercover))
@@ -11095,8 +11060,7 @@ (define-public emacs-company-lsp
     (native-inputs
      (list emacs-buttercup))
     (arguments
-     `(#:tests? #t
-       #:test-command '("buttercup" "-L" ".")))
+     `(#:test-command '("buttercup" "-L" ".")))
     (home-page "https://github.com/tigersoldier/company-lsp")
     (synopsis "Completion for @code{lsp-mode}")
     (description
@@ -11746,7 +11710,6 @@ (define-public emacs-jack
       (build-system emacs-build-system)
       (arguments
        (list
-        #:tests? #t
         #:test-command #~(list "emacs"
                                "--batch"
                                "-l"
@@ -11857,7 +11820,6 @@ (define-public emacs-elquery
     (arguments
      (list
       #:emacs emacs-no-x
-      #:tests? #t
       #:test-command #~(list "ert-runner")
       #:phases #~(modify-phases %standard-phases
                    (add-after 'unpack 'fix-native-compilation
@@ -11903,7 +11865,6 @@ (define-public emacs-cov
       (arguments
        (list
         #:emacs emacs-no-x              ;for libxml
-        #:tests? #t
         #:test-command #~(list "ert-runner")
         #:phases
         #~(modify-phases %standard-phases
@@ -12019,8 +11980,7 @@ (define-public emacs-god-mode
          "1njln47w25ix9w0xjv02110ngr8d8ma3w7db0x4xcxhihbl65zly"))))
     (build-system emacs-build-system)
     (arguments
-     (list #:tests? #true
-           #:test-command
+     (list #:test-command
            #~(list "emacs" "--no-init-file"

This message was truncated. Download the full message here.

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 05/45] gnu: emacs-list-utils: Provide test command.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:dd74733c3501b9441d93a0ed6c81cf5fa1afbee2.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-list-utils)[arguments]: Add #:test-command.

---

gnu/packages/emacs-xyz.scm | 7 +++++++

1 file changed, 7 insertions(+)

Toggle diff (20 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 81351838e1c..1feab918362 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -25977,6 +25977,13 @@ (define-public emacs-list-utils
                (base32
                 "0rc7ql78qraa35lv6igkd81j5ap9zgn6ri9rp9cajp86s2b46dg6"))))
     (build-system emacs-build-system)
+    (arguments (list #:test-command
+                     #~(list "emacs" "--batch" "-L" "." "-L" "ert-tests"
+                             "-l" "cl-macs" "-l" "ert" "-l" "list-utils-test"
+                             "--eval"
+                             "(progn (fset 'ert--print-backtrace 'ignore)
+                                     (ert-run-tests-batch-and-exit
+                                        '(not (tag :interactive))))")))
     (home-page "https://github.com/rolandwalker/list-utils")
     (synopsis "List-manipulation utility functions")
     (description
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 06/45] gnu: emacs-helpful: Fix build.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:fb9311a59822fb820b0672f63319618dfb28e7c9.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/patches/emacs-helpful-fix-tests.patch: Squash a test fix for
Emacs 30.
* gnu/packages/patches/emacs-helpful-fix-signature.patch: New file.
* gnu/local.mk (dist_patch_DATA): Register it here.
* gnu/packages/emacs-xyz.scm (emacs-helpful)[patches]: Use it here.
---
 gnu/local.mk                                  |  1 +
 gnu/packages/emacs-xyz.scm                    |  4 ++-
 .../patches/emacs-helpful-fix-signature.patch | 34 +++++++++++++++++++
 .../patches/emacs-helpful-fix-tests.patch     | 20 ++++++-----
 4 files changed, 49 insertions(+), 10 deletions(-)
 create mode 100644 gnu/packages/patches/emacs-helpful-fix-signature.patch

Toggle diff (102 lines)diff --git a/gnu/local.mk b/gnu/local.mk
index 97e26b8468a..3b1c784ddc0 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1219,6 +1219,7 @@ dist_patch_DATA =						\
   %D%/packages/patches/emacs-eglot-x-fix-apply-text-edits.patch			\
   %D%/packages/patches/emacs-exec-path.patch			\
   %D%/packages/patches/emacs-fix-scheme-indent-function.patch	\
+  %D%/packages/patches/emacs-helpful-fix-signature.patch	\
   %D%/packages/patches/emacs-helpful-fix-tests.patch	\
   %D%/packages/patches/emacs-highlight-stages-add-gexp.patch	\
   %D%/packages/patches/emacs-json-reformat-fix-tests.patch	\
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 1feab918362..80abd3f1ccf 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27437,7 +27437,9 @@ (define-public emacs-helpful
        (file-name (git-file-name name version))
        (sha256
         (base32 "03afgdbs5nmhw833svrqky7fmfs1zlvqzcj7j5g29sakivs60xqc"))
-       (patches (search-patches "emacs-helpful-fix-tests.patch"))))
+       (patches (search-patches
+                 "emacs-helpful-fix-signature.patch"
+                 "emacs-helpful-fix-tests.patch"))))
     (build-system emacs-build-system)
     (propagated-inputs
      (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
diff --git a/gnu/packages/patches/emacs-helpful-fix-signature.patch b/gnu/packages/patches/emacs-helpful-fix-signature.patch
new file mode 100644
index 00000000000..867df443cbe
--- /dev/null
+++ b/gnu/packages/patches/emacs-helpful-fix-signature.patch
@@ -0,0 +1,34 @@
+From 3794389ef685b6a59b3a487d0492c3add3c42c2f Mon Sep 17 00:00:00 2001
+From: Xiyue Deng <manphiz@gmail.com>
+Date: Wed, 26 Feb 2025 15:39:42 -0800
+Subject: [PATCH] Check for interpreted-function-p
+
+Emacs 30.x added interpreted-function which is different from
+byte-code-function, and hence helpful--signature will try to treat it
+like a lambda which will fail with
+
+,----
+| (wrong-type-argument listp #[(x) (x) (t) nil "Foo"])
+`----
+
+This patch adds tests for such case using interpreted-function-p when
+it's available.
+---
+ helpful.el | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/helpful.el b/helpful.el
+index b100816..331ece8 100644
+--- a/helpful.el
++++ b/helpful.el
+@@ -2570,7 +2570,9 @@ For example, \"(some-func FOO &optional BAR)\"."
+             (cond
+              ((symbolp sym)
+               (help-function-arglist sym))
+-             ((byte-code-function-p sym)
++             ((or (byte-code-function-p sym)
++                  (if (fboundp 'interpreted-function-p)
++                      (interpreted-function-p sym)))
+               ;; argdesc can be a list of arguments or an integer
+               ;; encoding the min/max number of arguments. See
+               ;; Byte-Code Function Objects in the elisp manual.
\ No newline at end of file
diff --git a/gnu/packages/patches/emacs-helpful-fix-tests.patch b/gnu/packages/patches/emacs-helpful-fix-tests.patch
index 61ed0671a47..f788a7dee64 100644
--- a/gnu/packages/patches/emacs-helpful-fix-tests.patch
+++ b/gnu/packages/patches/emacs-helpful-fix-tests.patch
@@ -1,16 +1,18 @@
-From 233e254bbe44f70ca899a506b3706af489228fda Mon Sep 17 00:00:00 2001
-From: aagon <aymeric.agon@hotmail.fr>
-Date: Thu, 10 Aug 2023 20:03:52 +0200
-Subject: [PATCH] Repair helpful--display-implementations test for emacs 29.1
-
----
- test/helpful-unit-test.el | 8 ++++++--
- 1 file changed, 6 insertions(+), 2 deletions(-)
-
 diff --git a/test/helpful-unit-test.el b/test/helpful-unit-test.el
 index 0f5177b..0716b0d 100644
 --- a/test/helpful-unit-test.el
 +++ b/test/helpful-unit-test.el
+@@ -734,7 +734,9 @@ associated a lambda with a keybinding."
+   (should
+    (equal
+     (length (helpful--keymaps-containing #'helpful--dummy-command))
+-    2))
++    (if (< emacs-major-version 30)
++        2
++      3)))
+ 
+   ;; Undo keybinding.
+   (global-set-key (kbd "C-c M-S-c") nil)
 @@ -1089,8 +1089,12 @@ find the source code."
    (require 'xref)
    (helpful-function 'xref-location-marker)
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 07/45] gnu: emacs-helpful: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:20b34b64c4d30e5c2c0773968345e0cd611090f2.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-helpful): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 2 --

1 file changed, 2 deletions(-)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 80abd3f1ccf..c9cb388d06f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27445,8 +27445,6 @@ (define-public emacs-helpful
      (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
     (native-inputs
      (list emacs-ert-runner emacs-undercover))
-    (arguments
-     `(#:test-command '("ert-runner")))
     (home-page "https://github.com/Wilfred/helpful")
     (synopsis "More contextual information in Emacs help")
     (description "@code{helpful} is an alternative to the built-in Emacs help
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 08/45] gnu: emacs-popup: Fix build.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:725c65a565dbfd122c87222fdea396bf2b8add1b.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-popup)[arguments]: Add #:test-command.
[native-inputs]: Add emacs-ert-runner.
---
 gnu/packages/emacs-xyz.scm | 2 ++
 1 file changed, 2 insertions(+)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c9cb388d06f..2d392ae50c6 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11468,6 +11468,8 @@ (define-public emacs-popup
        (sha256
         (base32 "13ww7hld5pa32myj9krr6prmc99s7hnpsw8mw9krpxffykkblj2f"))))
     (build-system emacs-build-system)
+    (arguments (list #:test-command #~(list "ert-runner" "tests")))
+    (native-inputs (list emacs-ert-runner))
     (home-page "https://github.com/auto-complete/popup-el")
     (synopsis "Visual Popup User Interface for Emacs")
     (description
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 09/45] gnu: emacs-auto-complete: Fix build.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:bcfadc63de512e3db5ad6c835ff51a620f3cae61.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-auto-complete)[arguments]:
Add #:test-command.
[native-inputs]: Add emacs-ert-runner.
---
 gnu/packages/emacs-xyz.scm | 2 ++
 1 file changed, 2 insertions(+)

Toggle diff (17 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 2d392ae50c6..dd3e832ea3a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -18885,8 +18885,10 @@ (define-public emacs-auto-complete
          "04i9b11iksg6acn885wl3qgi5xpsm3yszlqmd2x21yhprndlz7gb"))
        (file-name (git-file-name name version))))
     (build-system emacs-build-system)
+    (arguments (list #:test-command #~(list "ert-runner" "tests")))
     (propagated-inputs
      (list emacs-popup))
+    (native-inputs (list emacs-ert-runner))
     (home-page "https://github.com/auto-complete/auto-complete")
     (synopsis "Intelligent auto-completion extension for Emacs")
     (description
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 10/45] gnu: emacs-shrink-path: Add missing input.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:994d879592a953979767e1f4dae803e15063eae3.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-shrink-path)[native-inputs]: Add
emacs-buttercup.
---
 gnu/packages/emacs-xyz.scm | 1 +
 1 file changed, 1 insertion(+)

Toggle diff (14 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index dd3e832ea3a..51fd5f4173a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -37660,6 +37660,7 @@ (define-public emacs-shrink-path
     (build-system emacs-build-system)
     (propagated-inputs
      (list emacs-s emacs-dash emacs-f))
+    (native-inputs (list emacs-buttercup))
     (home-page "https://gitlab.com/bennya/shrink-path.el")
     (synopsis "Fish-style path truncation in emacs-lisp")
     (description "This package provides utility functions that allow for
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 11/45] gnu: emacs-yasnippet: Fix build.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:07ab7ef20339c70cccbed23ddb3b280c0f4bc8e8.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-yasnippet)[#:test-command]: Adjust so as
to not run ‘yas-org-native-tab-in-source-block-emacs-lisp’.
---
 gnu/packages/emacs-xyz.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Toggle diff (23 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 51fd5f4173a..4181899783c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19767,9 +19767,13 @@ (define-public emacs-yasnippet
           (search-patches "emacs-yasnippet-fix-empty-snippet-next.patch"))))
       (build-system emacs-build-system)
       (arguments
-       `(#:test-command '("emacs" "--batch"
-                          "-l" "yasnippet-tests.el"
-                          "-f" "ert-run-tests-batch-and-exit")
+       `(#:test-command
+         '("emacs" "--batch"
+           "-l" "yasnippet-tests.el"
+           ;; XXX: one test is broken…
+           "--eval"
+           "(ert-run-tests-batch-and-exit
+             '(not yas-org-native-tab-in-source-block-emacs-lisp))")
          #:phases
          (modify-phases %standard-phases
            ;; Set HOME, otherwise test-rebindings fails.
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 12/45] gnu: emacs-elpy: Record failing tests for Emacs 30.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:b0e45df429db4d36973e8198fd572e4e86455c8a.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-elpy)[disable-broken-tests]: Update.

---

gnu/packages/emacs-xyz.scm | 12 ++++++++++++

1 file changed, 12 insertions(+)

Toggle diff (25 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4181899783c..28178a301d0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -16394,6 +16394,18 @@ (define-public emacs-elpy
                  (substitute* "elpy-folding-fold-blocks-test.el"
                    (("elpy-fold-at-point-should-NOT-fold-and-unfold-functions\
 -from-after.*" all)
+                    (string-append all "  :expected-result :failed\n")))
+                 ;; These tests started failing with Emacs 30.
+                 ;; (TODO: report upstream)
+                 (substitute* "elpy-company-backend-test.el"
+                   (("elpy-company-backend-should-find-.*-prefix-string.*" all)
+                    (string-append all "  :expected-result :failed\n")))
+                 (substitute* "elpy-shell-get-or-create-process-test.el"
+                   (("elpy-shell-get-or-create-process-should-add-project-root\
+-to-path.*" all)
+                    (string-append all "  :expected-result :failed\n")))
+                 (substitute* "elpy-format-code-test.el"
+                   (("elpy-should-format-code-with-default-formatter.*" all)
                     (string-append all "  :expected-result :failed\n"))))))
            ;; The default environment of the RPC uses Virtualenv to install
            ;; Python dependencies from PyPI.  We don't want/need this in Guix.
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 15/45] gnu: emacs-pug-mode: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:5be626f793711722aa0a5b1115bfd489cbc44c21.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-pug-mode): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Toggle diff (16 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index bf2d97aac9e..b06a3977a53 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1366,9 +1366,6 @@ (define-public emacs-pug-mode
                 "1f6bhdr1a72x94dlz2i1fwwln8crc2mbpc2iq23hvsbsfmj7xfzp"))))
     (native-inputs (list emacs-ert-runner))
     (build-system emacs-build-system)
-    (arguments
-     (list
-      #:test-command #~(list "ert-runner")))
     (home-page "https://github.com/hlissner/emacs-pug-mode")
     (synopsis "Pug support for Emacs")
     (description "Pug mode offers Emacs support for Pug.  Unlike Jade mode, it
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 16/45] gnu: emacs-graphql: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:4667caaeae1848bd3c4dccddb650702b62b3e294.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-graphql)[arguments]: Drop #:test-command.

---

gnu/packages/emacs-xyz.scm | 1 -

1 file changed, 1 deletion(-)

Toggle diff (14 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b06a3977a53..34999e61aa3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2569,7 +2569,6 @@ (define-public emacs-graphql
       (build-system emacs-build-system)
       (arguments
        (list
-        #:test-command #~(list "ert-runner")
         #:phases
         #~(modify-phases %standard-phases
             (add-after 'unpack 'skip-failing-test
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 17/45] gnu: emacs-relative-buffers: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:5c4a26746701c35e535782eee431e02ba9f8d9fe.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-relative-buffers): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Toggle diff (16 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 34999e61aa3..4d6e913af7e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3719,9 +3719,6 @@ (define-public emacs-relative-buffers
              ;; Delete the Cask test runners.
              (for-each delete-file '("Cask" "test/test-helper.el"))))))
       (build-system emacs-build-system)
-      (arguments
-       (list
-        #:test-command #~(list "ert-runner")))
       (native-inputs
        (list emacs-ert-runner))
       (propagated-inputs
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 18/45] gnu: emacs-go-mode: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:ade6150efab6c02ac1a809ef21ad746c65bb328c.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-go-mode)[arguments]: Drop #:test-command.

---

gnu/packages/emacs-xyz.scm | 1 -

1 file changed, 1 deletion(-)

Toggle diff (14 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4d6e913af7e..504a944b10a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -5877,7 +5877,6 @@ (define-public emacs-go-mode
                   "00qzn136d8cl3szbi44xf3iiv75r6n1m7wwgldmzn4i5mpz8dbq7"))))
       (arguments
        (list
-        #:test-command #~(list "ert-runner")
         #:phases
         #~(modify-phases %standard-phases
             (add-before 'check 'fix-tests
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 19/45] gnu: emacs-string-inflection : Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:4dbbead044a8c96796b3e76fcc9428b2e6217b52.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-string-inflection): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 2 --

1 file changed, 2 deletions(-)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 504a944b10a..f905675fbb4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -8451,8 +8451,6 @@ (define-public emacs-string-inflection
     (build-system emacs-build-system)
     (native-inputs
      (list emacs-ert-runner))
-    (arguments
-     `(#:test-command '("ert-runner")))
     (home-page "https://github.com/akicho8/string-inflection")
     (synopsis "Convert symbol names between different naming conventions")
     (description
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 13/45] gnu: emacs-elpy: Use imp licit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:c4e92f2789dc30f5f5e65b64e13f5c70b7408f14.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-elpy)[arguments]: Drop #:test-command.

---

gnu/packages/emacs-xyz.scm | 3 +--

1 file changed, 1 insertion(+), 2 deletions(-)

Toggle diff (16 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 28178a301d0..78171e505c0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -16428,8 +16428,7 @@ (define-public emacs-elpy
                       (man1 (string-append out "/share/man/man1")))
                  (mkdir-p man1)
                  (copy-file "docs/_build/man/elpy.1"
-                            (string-append man1 "/elpy.1"))))))
-         #:test-command '("ert-runner")))
+                            (string-append man1 "/elpy.1"))))))))
       (propagated-inputs
        (list emacs-company
              emacs-find-file-in-project
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 14/45] gnu: emacs-ac-php: Use i mplicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:5677200d9d9a921e7884c824f34e05123d4ce5d9.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-ac-php): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Toggle diff (16 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 78171e505c0..bf2d97aac9e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -363,9 +363,6 @@ (define-public emacs-ac-php
        (sha256
         (base32 "1yn5cc6cmj3hwqgmjj44dz847xn5k99kirj36qwc04q7vhl8z8k7"))))
     (build-system emacs-build-system)
-    (arguments
-     (list
-      #:test-command #~(list "ert-runner")))
     (inputs
      (list emacs-auto-complete
            emacs-company
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 20/45] gnu: emacs-elquery: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:5599d817392ab8d59e3ff403c9b92e463412d1cc.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-elquery)[arguments]: Drop #:test-command.

---

gnu/packages/emacs-xyz.scm | 1 -

1 file changed, 1 deletion(-)

Toggle diff (14 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f905675fbb4..4b4a0d55295 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11812,7 +11812,6 @@ (define-public emacs-elquery
     (arguments
      (list
       #:emacs emacs-no-x
-      #:test-command #~(list "ert-runner")
       #:phases #~(modify-phases %standard-phases
                    (add-after 'unpack 'fix-native-compilation
                      (lambda _
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 21/45] gnu: emacs-cov: Use impl icit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:1fe53304c1ced085cea95aa8130af0dc5e920433.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-cov)[arguments]: Drop #:test-command.

---

gnu/packages/emacs-xyz.scm | 1 -

1 file changed, 1 deletion(-)

Toggle diff (14 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4b4a0d55295..9a3c4c6cac8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11856,7 +11856,6 @@ (define-public emacs-cov
       (arguments
        (list
         #:emacs emacs-no-x              ;for libxml
-        #:test-command #~(list "ert-runner")
         #:phases
         #~(modify-phases %standard-phases
             (add-before 'check 'disable-failing-tests
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 22/45] gnu: emacs-skeletor: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:91db182176d76d8566aa91684cb2dd3dd009b6e6.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-skeletor)[arguments]: Drop #:test-command.

---

gnu/packages/emacs-xyz.scm | 1 -

1 file changed, 1 deletion(-)

Toggle diff (14 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 9a3c4c6cac8..07e5486f2b6 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -15796,7 +15796,6 @@ (define-public emacs-skeletor
       (arguments
        (list
         #:include #~(cons "^project-skeletons\\/" %default-include)
-        #:test-command #~(list "ert-runner")
         #:phases
         #~(modify-phases %standard-phases
             ;; XXX: one failing test involving initializing a git repo.
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 23/45] gnu: emacs-mocker: Use i mplicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:fadb1f566cca82b9bc09064810d8ad2b60dc0c8a.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-mocker): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 2 --

1 file changed, 2 deletions(-)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 07e5486f2b6..ccf74f43b80 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -16158,8 +16158,6 @@ (define-public emacs-mocker
        (sha256
         (base32 "1dc514cqbfmg33sb3j90s5jmw6jnm3wzvs0zhw3maz13bp7w6z48"))))
     (build-system emacs-build-system)
-    (arguments
-     `(#:test-command '("ert-runner")))
     (native-inputs
      (list emacs-ert-runner))
     (propagated-inputs
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 25/45] gnu: emacs-islisp-mode: Us e implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:23e0b28e91c0b27d8e3bc3360243d0d3631a84d0.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-islisp-mode): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 1 -

1 file changed, 1 deletion(-)

Toggle diff (14 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b71955c0039..c4ace28f720 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -17259,7 +17259,6 @@ (define-public emacs-islisp-mode
     (arguments
      (list
       #:include #~(cons "\\.lsp$" %default-include)
-      #:test-command #~(list "ert-runner")
       #:phases
       #~(modify-phases %standard-phases
           ;; Move the extensions source files to the top level, which is
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 26/45] gnu: emacs-ht: Use impli cit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:f502d34be9efb695d157a3ff4969643d1a64dfff.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-ht): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 2 --

1 file changed, 2 deletions(-)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c4ace28f720..ef933f9d6ce 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19045,8 +19045,6 @@ (define-public emacs-ht
     (propagated-inputs (list emacs-dash))
     (native-inputs
      (list emacs-ert-runner))
-    (arguments
-     `(#:test-command '("ert-runner")))
     (home-page "https://github.com/Wilfred/ht.el")
     (synopsis "Hash table library for Emacs")
     (description
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 27/45] gnu: emacs-json-reformat: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:e4cdce6797092ef2f84423b581cb821930aa49c3.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-json-reformat)[arguments]:
Drop #:test-command.
---
 gnu/packages/emacs-xyz.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Toggle diff (16 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ef933f9d6ce..64141d10850 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -21972,8 +21972,7 @@ (define-public emacs-json-reformat
        (patches (search-patches "emacs-json-reformat-fix-tests.patch"))))
     (build-system emacs-build-system)
     (arguments
-     `(#:test-command '("ert-runner")
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          (add-before 'check 'make-tests-writable
            (lambda _
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 28/45] gnu: emacs-browse-at-remote: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:36bb66d287faf2f98e49c6ea7156514fed2fd080.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-browse-at-remote): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 2 --

1 file changed, 2 deletions(-)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 64141d10850..5e3dc9ace85 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -23117,8 +23117,6 @@ (define-public emacs-browse-at-remote
        (sha256
         (base32 "0bx4ns0jb0sqrjk1nsspvl3mhz3n12925azf7brlwb1vcgnji09v"))))
     (build-system emacs-build-system)
-    (arguments
-     `(#:test-command '("ert-runner")))
     (native-inputs
      (list emacs-ert-runner))
     (propagated-inputs
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 29/45] gnu: emacs-groovy-modes: U se implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:302cf0467ee4bf316159d95862d917b2860f2579.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-groovy-modes): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 2 --

1 file changed, 2 deletions(-)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5e3dc9ace85..a1ddef83c3b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -23999,8 +23999,6 @@ (define-public emacs-groovy-modes
                (base32
                 "1jpfyqnqd8nj0g8xbiw4ar2qzxx3pvhwibr6hdzhyy9mmc4yzdgk"))))
     (build-system emacs-build-system)
-    (arguments
-     `(#:test-command '("ert-runner")))
     (native-inputs
      (list emacs-ert-runner emacs-undercover emacs-shut-up emacs-f))
     (propagated-inputs
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 30/45] gnu: emacs-loop: Use imp licit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:0506cb3135de7e23376a15942d984773e3241fbc.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-loop): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 2 --

1 file changed, 2 deletions(-)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a1ddef83c3b..7e84ff37653 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26318,8 +26318,6 @@ (define-public emacs-loop
     (build-system emacs-build-system)
     (native-inputs
      (list emacs-ert-runner emacs-undercover))
-    (arguments
-     `(#:test-command '("ert-runner")))
     (home-page "https://github.com/Wilfred/loop.el")
     (synopsis "Imperative loop structures for Emacs")
     (description "Loop structures familiar to users of other languages.  This
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 31/45] gnu: emacs-elisp-refs: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:7d145c3ba5ca89e7e19248893a8f842acff24d39.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-elisp-refs): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Toggle diff (16 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7e84ff37653..03898bfe2d8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -26348,9 +26348,6 @@ (define-public emacs-elisp-refs
            emacs-shut-up))
     (native-inputs
      (list emacs-ert-runner emacs-undercover))
-    (arguments
-     (list
-      #:test-command #~(list "ert-runner")))
     (home-page "https://github.com/Wilfred/elisp-refs")
     (synopsis "Find callers of elisp functions or macros")
     (description "@code{elisp-refs} finds references to functions, macros or
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 32/45] gnu: emacs-suggest: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:cd592c5369078583b6064f79c9a81e6cc63e42af.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-suggest): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 2 --

1 file changed, 2 deletions(-)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 03898bfe2d8..3d75b66b2f0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27501,8 +27501,6 @@ (define-public emacs-suggest
            emacs-shut-up))
     (native-inputs
      (list emacs-ert-runner emacs-undercover))
-    (arguments
-     `(#:test-command '("ert-runner")))
     (synopsis "Suggest Elisp functions that give the output requested")
     (description "Suggest.el will find functions that give the output
 requested.  It's a great way of exploring list, string and arithmetic
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 34/45] gnu: emacs-helm-company: U se implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:63733c39f01346935f31596ef7ffb571e2594934.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-helm-company): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 2 --

1 file changed, 2 deletions(-)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 30f19082c53..02c3314d80d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -29325,8 +29325,6 @@ (define-public emacs-helm-company
      (list emacs-helm emacs-company))
     (native-inputs
      (list emacs-ert-runner))
-    (arguments
-     (list #:test-command #~(list "ert-runner")))
     (home-page "https://github.com/Sodel-the-Vociferous/helm-company")
     (synopsis "Helm interface for Company mode")
     (description
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 33/45] gnu: emacs-dumb-jump: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:47840b737cd9eafa786b94f894b87d87e00703ff.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-dumb-jump)[arguments]: Drop #:test-command.

---

gnu/packages/emacs-xyz.scm | 1 -

1 file changed, 1 deletion(-)

Toggle diff (14 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 3d75b66b2f0..30f19082c53 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -28624,7 +28624,6 @@ (define-public emacs-dumb-jump
     (build-system emacs-build-system)
     (arguments
      `(#:tests? #f                      ; FIXME: Tests freeze when run.
-       #:test-command '("ert-runner")
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'set-shell
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 35/45] gnu: emacs-deadgrep: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:996b4e1e6a6bf4f5b0383db9e3fb8ac10c19d7d3.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-deadgrep)[arguments]: Drop #:test-command.

---

gnu/packages/emacs-xyz.scm | 1 -

1 file changed, 1 deletion(-)

Toggle diff (14 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 02c3314d80d..f4bdfe3dc1a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -29954,7 +29954,6 @@ (define-public emacs-deadgrep
     (build-system emacs-build-system)
     (arguments
      (list
-      #:test-command #~(list "ert-runner")
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'unpack 'configure
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 36/45] gnu: emacs-racer: Use im plicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:9a12be0c267e77a69b9af3ce443dc08e992c11c9.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-racer): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 2 --

1 file changed, 2 deletions(-)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f4bdfe3dc1a..3424499e18e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -30318,8 +30318,6 @@ (define-public emacs-racer
          (file-name (git-file-name name version))
          (sha256
           (base32 "12a429lajk09qp1jxgig54p8z6wndfgr4jwdmgkc9s2df9sw02d3"))))
-      (arguments
-       `(#:test-command '("ert-runner")))
       (native-inputs
        (list emacs-ert-runner emacs-undercover))
       (propagated-inputs
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 37/45] gnu: emacs-libmpdel: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:2cd5eb4833b2f2dc782365cd1ef3d9acf7a13f09.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-libmpdel): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Toggle diff (16 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 3424499e18e..16304385c5d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -32100,9 +32100,6 @@ (define-public emacs-libmpdel
                (base32
                 "03bavca89cf7dsjmg7hb48qnvca41ndiij33iw5yjjhbq1zyj8r4"))))
     (build-system emacs-build-system)
-    (arguments
-     (list
-      #:test-command #~(list "ert-runner")))
     (native-inputs
      (list emacs-ert-runner))
     (home-page "https://github.com/mpdel/libmpdel")
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 38/45] gnu: emacs-navigel: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:9776b6fc926650d0221883ce8e29da9a5d239741.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-navigel): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 3 ---

1 file changed, 3 deletions(-)

Toggle diff (16 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 16304385c5d..3411fbcae63 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -32175,9 +32175,6 @@ (define-public emacs-navigel
                (base32
                 "0fszhjf6bj8frvlnim86sfv6sab3qyignxqh8x6i4bqgwnb6svkf"))))
     (build-system emacs-build-system)
-    (arguments
-     (list
-      #:test-command #~(list "ert-runner")))
     (native-inputs
      (list emacs-ert-runner))
     (propagated-inputs
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 39/45] gnu: emacs-detached: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:2251e810225593f5b6ae84d6207f34cc79a420ed.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-detached)[arguments]: Drop #:test-command.

---

gnu/packages/emacs-xyz.scm | 1 -

1 file changed, 1 deletion(-)

Toggle diff (14 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 3411fbcae63..d98d1f4df8b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -32436,7 +32436,6 @@ (define-public emacs-detached
                 "0dvvyqc0nw9has54vps10f5iv831cb29vqvbvx0m2djv9pacqp17"))))
     (arguments
      (list
-      #:test-command #~(list "ert-runner")
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'unpack 'configure
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 40/45] gnu: emacs-bfuture: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:f70078ad26837fbf3be6ec204c40fd77eea68d28.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-bfuture): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 2 --

1 file changed, 2 deletions(-)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d98d1f4df8b..433c2b21689 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -33124,8 +33124,6 @@ (define-public emacs-bfuture
          "0604xgwrcvqsmk1vky8wdivsl43p6jgs5zchqssdmf22f5chxbzr"))
        (file-name (git-file-name name version))))
     (build-system emacs-build-system)
-    (arguments
-     (list #:test-command #~'("ert-runner")))
     (native-inputs (list emacs-ert-runner))
     (home-page "https://github.com/plattfot/bfuture.el")
     (synopsis "Basic future concept for Emacs with Tramp support")
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 41/45] gnu: emacs-tco-el: Use i mplicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:f8c0761fb1a55b31699178403eb17768817ba195.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-tco-el)[arguments]: Drop #:test-command.

---

gnu/packages/emacs-xyz.scm | 2 --

1 file changed, 2 deletions(-)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 433c2b21689..cec83cc513f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -33959,8 +33959,6 @@ (define-public emacs-tco-el
        (list emacs-dash))
       (native-inputs
        (list emacs-ert-runner emacs-undercover))
-      (arguments
-       `(#:test-command '("ert-runner")))
       (home-page "https://github.com/Wilfred/tco.el")
       (synopsis "Tail-call optimization for Emacs Lisp")
       (description "This package provides tail-call optimization for Emacs
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 24/45] gnu: emacs-pyvenv: Use i mplicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:1f724f04982585cd09d48fcdb0312d9ce6da9763.1740925543.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-pyvenv)[arguments]: Drop #:test-command.

---

gnu/packages/emacs-xyz.scm | 3 +--

1 file changed, 1 insertion(+), 2 deletions(-)

Toggle diff (16 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ccf74f43b80..b71955c0039 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -16246,8 +16246,7 @@ (define-public emacs-pyvenv
          (add-after 'unpack 'ert-number-tests
              (lambda _
                (ert-number-tests "test/pyvenv-hook-dir-test.el"
-                                 "pyvenv-hook-dir"))))
-       #:test-command '("ert-runner")))
+                                 "pyvenv-hook-dir"))))))
     (native-inputs
      (list emacs-ert-runner emacs-mocker))
     (home-page "https://github.com/jorgenschaefer/pyvenv")
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 42/45] gnu: emacs-dash-docs: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:ac9fbb0dd0a39f8a4bcae61b913ea4b5857f46e9.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-dash-docs)[arguments]: Drop #:test-command.

---

gnu/packages/emacs-xyz.scm | 3 +--

1 file changed, 1 insertion(+), 2 deletions(-)

Toggle diff (16 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index cec83cc513f..aa0216fb806 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -34663,8 +34663,7 @@ (define-public emacs-dash-docs
       (native-inputs
        (list emacs-undercover emacs-ert-runner))
       (arguments
-       `(#:test-command '("ert-runner")
-         #:phases
+       `(#:phases
          ;; this test requires network access, so remove it
          (modify-phases %standard-phases
            (add-before 'check 'make-tests-writable
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 43/45] gnu: emacs-doom-themes: Us e implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:87a12dd82c8669407e816a744452f7c8bb8b76b8.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-doom-themes)[arguments]:
Drop #:test-command.
---
 gnu/packages/emacs-xyz.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Toggle diff (16 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index aa0216fb806..b029a4170c1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -36820,8 +36820,7 @@ (define-public emacs-doom-themes
       (native-inputs
        (list emacs-ert-runner))
       (arguments
-       (list #:test-command #~(list "ert-runner")
-             #:modules '((guix build emacs-build-system)
+       (list #:modules '((guix build emacs-build-system)
                          (guix build utils)
                          (guix build emacs-utils)
                          (srfi srfi-1))
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 45/45] gnu: emacs-org-cliplink: U se implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:b8da65c85244b871d79378578ed5f424172957fb.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-org-cliplink)[arguments]:
Drop #:test-command.
---
 gnu/packages/emacs-xyz.scm | 1 -
 1 file changed, 1 deletion(-)

Toggle diff (14 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 274af3efc18..ac848eefb8a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -42001,7 +42001,6 @@ (define-public emacs-org-cliplink
       (build-system emacs-build-system)
       (arguments
        (list
-        #:test-command #~(list "ert-runner")
         #:phases
         #~(modify-phases %standard-phases
             (add-after 'unpack 'patch-curl-executable
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

[PATCH emacs-team 44/45] gnu: emacs-doom-modeline: Use implicit “ert-runner”.

Recipients:(address . 76686@debbugs.gnu.org)

Message-ID:e797a56f703233272ebfb343936f878b9507ea6e.1740925544.git.liliana.prikler@gmail.com

* gnu/packages/emacs-xyz.scm (emacs-doom-modeline): Drop arguments.

---

gnu/packages/emacs-xyz.scm | 2 --

1 file changed, 2 deletions(-)

Toggle diff (15 lines)diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b029a4170c1..274af3efc18 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -37504,8 +37504,6 @@ (define-public emacs-doom-modeline
         (base32 "0l7yyn8yxyxbsjbs52bp9wh66wdj828scb1gjbi6pk1hrx5x8g9v"))
        (file-name (git-file-name name version))))
     (build-system emacs-build-system)
-    (arguments
-     `(#:test-command '("ert-runner")))
     (native-inputs (list emacs-ert-runner))
     (propagated-inputs
      (list emacs-nerd-icons emacs-compat emacs-shrink-path))
-- 
2.48.1

Morgan Smith wrote 2 weeks ago

Re: [bug#76686] [PATCH emacs-team 00/45] Test emacs packages by default

Recipients:(name . Liliana Marie Prikler)(address . liliana.prikler@gmail.com)(address . 76686@debbugs.gnu.org)(address . ian@retrospec.tv)(address . cox.katherine.e+guix@gmail.com)(address . liliana.prikler@gmail.com)(address . andrew@trop.in)(address . divya@subvertising.org)

Message-ID:CH3PR84MB3424058F20A7E0CF95E2AC87C5C92@CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

Toggle quote (10 lines)> Hi folks,
>
> this patch adds code – similar to what we have in other ecosystems – to
> make an educated guess on what test framework is used and use it.  Newly
> packaged Emacs libraries should thus expect to be tested with tests
> needing to be explicitly disabled otherwise; just like in the rest of
> Guix.
>
> Cheers

Looks good to me just reading through them.  Some of the test commands
looks a little complicated though with a lot of boiler plate (like
emacs-list-utils).  Any thoughts on perhaps using a helper function like
the (untested) attached patch?

From 631833f951e52047a4b8ea3a5598ec0b377a67d4 Mon Sep 17 00:00:00 2001

Message-ID: <631833f951e52047a4b8ea3a5598ec0b377a67d4.1740961610.git.Morgan.J.Smith@outlook.com>

'emacs-batch-eval-command'.

* guix/build/emacs-utils.scm(emacs-batch-eval-command): New function.

(emacs-batch-eval): Define in terms of 'emacs-batch-eval-command'.

Change-Id: I27c10bc7a93be02385ad47cadd124379bcaaad52

---

guix/build/emacs-utils.scm | 16 +++++++++++++---

1 file changed, 13 insertions(+), 3 deletions(-)

Toggle diff (32 lines)diff --git a/guix/build/emacs-utils.scm b/guix/build/emacs-utils.scm
index aeb364133a..dea062897e 100644
--- a/guix/build/emacs-utils.scm
+++ b/guix/build/emacs-utils.scm
@@ -63,12 +63,22 @@ (define (expr->string expr)
       expr
       (format #f "~s" expr)))
 
+(define* (emacs-batch-eval-command expr #:key (load-directories '())
+                                   (load-files '()) dynamic?)
+  "Return a command to run Emacs in batch mode, and execute the Elisp code
+EXPR.  If LOAD-DIRECTORIES is a list of directories, add them to the load path
+before running EXPR.  If LOAD-FILES is a list of files, load them before
+running EXPR.  DYNAMIC? is true, evaluate using dynamic scoping."
+  `("emacs" "--quick" "--batch"
+    ,@(map (lambda file) (string-append "--directory=" file) load-files)
+    ,@(map (lambda file) (string-append "--load=" file) load-files)
+    (format #f "--eval=(eval '~a ~:[t~;nil~])"
+            (expr->string expr) dynamic?)))
+
 (define* (emacs-batch-eval expr #:key dynamic?)
   "Run Emacs in batch mode, and execute the Elisp code EXPR.  If DYNAMIC? is
 true, evaluate using dynamic scoping."
-  (invoke (%emacs) "--quick" "--batch"
-          (format #f "--eval=(eval '~a ~:[t~;nil~])"
-                  (expr->string expr) dynamic?)))
+  (invoke (%emacs) (cdr (emacs-batch-eval-command expr #:dynamic dynamic))))
 
 (define (emacs-batch-edit-file file expr)
   "Load FILE in Emacs using batch mode, and execute the elisp code EXPR."
-- 
2.48.1

Liliana Marie Prikler wrote 2 weeks ago

Recipients:(name . Morgan Smith)(address . Morgan.J.Smith@outlook.com)(address . cox.katherine.e+guix@gmail.com)(address . ian@retrospec.tv)(address . divya@subvertising.org)(address . 76686@debbugs.gnu.org)(address . andrew@trop.in)

Message-ID:6b2c2afe72674c7e2aabbf21d285190a27b684ca.camel@gmail.com

Am Sonntag, dem 02.03.2025 um 19:29 -0500 schrieb Morgan Smith:

Toggle quote (16 lines)> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> 
> > Hi folks,
> > 
> > this patch adds code – similar to what we have in other ecosystems
> > – to make an educated guess on what test framework is used and use
> > it. Newly packaged Emacs libraries should thus expect to be tested
> > with tests needing to be explicitly disabled otherwise; just like
> > in the rest of Guix.
> > 
> > Cheers
> 
> Looks good to me just reading through them.  Some of the test
> commands looks a little complicated though with a lot of boiler plate
> (like emacs-list-utils).  Any thoughts on perhaps using a helper
> function like the (untested) attached patch?

Most packages shouldn't have too complicated test commands and I think

it's beneficial to have them in code verbatim. If a pattern gets

overused, we can still try to simplify it later.

Cheers

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 76686@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 76686

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags

mumi command -t +confirmed -t +easy

Or, remove the moreinfo tag and set the help tag

mumi command -t -moreinfo -t +help

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date