Build python-cdflib.x86_64-linux on master is broken.

  • Open
  • quality assurance status badge
Details
3 participants
  • Eric Bavier
  • Maxim Cournoyer
  • Sharlatan Hellseher
Owner
unassigned
Submitted by
Maxim Cournoyer
Severity
normal
M
M
Maxim Cournoyer wrote on 20 Nov 20:02 +0100
(name . bug-guix)(address . bug-guix@gnu.org)
878r6sb63w.fsf@gmail.com
Hello!

cuirass@gnu.org (Cuirass) writes:

Toggle quote (5 lines)
> <p>The build <b>python-cdflib.x86_64-linux</b> for specification <b>master</b> is broken. You can find the detailed information about this build <a
> href="https://ci.guix.gnu.org/build/2635702/details">here</a>.</p>
>
> https://ci.guix.gnu.org/build/2635702/details

It seems something in the commits series
either broke the test, else it's flaky.

--
Thanks,
Maxim
E
E
Eric Bavier wrote on 20 Nov 20:25 +0100
Re: bug#67304: Build python-cdflib.x86_64-linux on master is broken.
(name . Sharlatan Hellseher)(address . sharlatanus@gmail.com)
a980741a13afa003c2329a6fcfeb642d21d053c1.camel@posteo.net
Hi Maxim, thanks for the report.

On Mon, 2023-11-20 at 14:02 -0500, Maxim Cournoyer wrote:
Toggle quote (6 lines)
>
> It seems something in the commits series
> https://git.savannah.gnu.org/cgit/guix.git/log/?qt=range&q=2ab5e449246f98b049888dde3c310f5b4a0a64a2..b7abea0fd6a146563830db1dc4ddd0cceb6fcf1c
> either broke the test, else it's flaky.
>

I have built the package locally many times without fail.

The failed test is one that checks fidelity of a rountrip time format
conversion for a randomly-generated time, so failure may indeed be
intermittent.

I will try to dig a bit further, and maybe Sharlatan can as well.

`~Eric
S
S
Sharlatan Hellseher wrote on 20 Nov 23:39 +0100
(name . Eric Bavier)(address . bavier@posteo.net)
CAO+9K5qXi=LwEiwmXWbh9VqS+NewXwst5gbtuVQ6noe3rVezkQ@mail.gmail.com
Hi Guix,
I've checked the cement to the test and it mentioned as a candidate to be
removed as it's not stable
# Unfortunately, currently there is a pretty big loss of
precision that comes with
# the compute function. Need to stop testing early.
We may consider to disable it to stabilize build.
Thanks,
Oleg
On Mon, 20 Nov 2023 at 19:25, Eric Bavier <bavier@posteo.net> wrote:
Toggle quote (19 lines)
>
> Hi Maxim, thanks for the report.
>
> On Mon, 2023-11-20 at 14:02 -0500, Maxim Cournoyer wrote:
> >
> > It seems something in the commits series
> > https://git.savannah.gnu.org/cgit/guix.git/log/?qt=range&q=2ab5e449246f98b049888dde3c310f5b4a0a64a2..b7abea0fd6a146563830db1dc4ddd0cceb6fcf1c
> > either broke the test, else it's flaky.
> >
>
> I have built the package locally many times without fail.
>
> The failed test is one that checks fidelity of a rountrip time format
> conversion for a randomly-generated time, so failure may indeed be
> intermittent.
>
> I will try to dig a bit further, and maybe Sharlatan can as well.
>
> `~Eric
--
… ??? ????? - ???????????? ?????????????? ?????? ??????? ????????
????? ????? ????? ? ??? ??????, ??????????? ????? ???????, ??
?????????? ?? ? ????????? ??????? ????? ? ?????????????????.
S
S
Sharlatan Hellseher wrote on 20 Nov 23:56 +0100
(address . 67304@debbugs.gnu.org)
CAO+9K5qWXfkh43YT+X5_XtGam4Q5Y6SD+5H0CPcwQFWWF=iYiw@mail.gmail.com
Hi,
I've open an issue in upstram.
Mean while please check the patch disabling the test.
Thanks,
Oleg
On Mon, 20 Nov 2023 at 22:39, Sharlatan Hellseher <sharlatanus@gmail.com> wrote:
Toggle quote (44 lines)
>
> Hi Guix,
>
> I've checked the cement to the test and it mentioned as a candidate to be
> removed as it's not stable
>
> https://github.com/MAVENSDC/cdflib/blob/master/tests/test_astropy_epochs.py#L116
> # Unfortunately, currently there is a pretty big loss of
> precision that comes with
> # the compute function. Need to stop testing early.
>
> We may consider to disable it to stabilize build.
>
> Thanks,
> Oleg
>
> On Mon, 20 Nov 2023 at 19:25, Eric Bavier <bavier@posteo.net> wrote:
> >
> > Hi Maxim, thanks for the report.
> >
> > On Mon, 2023-11-20 at 14:02 -0500, Maxim Cournoyer wrote:
> > >
> > > It seems something in the commits series
> > > https://git.savannah.gnu.org/cgit/guix.git/log/?qt=range&q=2ab5e449246f98b049888dde3c310f5b4a0a64a2..b7abea0fd6a146563830db1dc4ddd0cceb6fcf1c
> > > either broke the test, else it's flaky.
> > >
> >
> > I have built the package locally many times without fail.
> >
> > The failed test is one that checks fidelity of a rountrip time format
> > conversion for a randomly-generated time, so failure may indeed be
> > intermittent.
> >
> > I will try to dig a bit further, and maybe Sharlatan can as well.
> >
> > `~Eric
>
>
>
> --
>
> … ??? ????? - ???????????? ?????????????? ?????? ??????? ????????
> ????? ????? ????? ? ??? ??????, ??????????? ????? ???????, ??
> ?????????? ?? ? ????????? ??????? ????? ? ?????????????????.
--
… ??? ????? - ???????????? ?????????????? ?????? ??????? ????????
????? ????? ????? ? ??? ??????, ??????????? ????? ???????, ??
?????????? ?? ? ????????? ??????? ????? ? ?????????????????.
From 2f55a5ac236952ea24d81998da488cff4553c272 Mon Sep 17 00:00:00 2001
Message-ID: <2f55a5ac236952ea24d81998da488cff4553c272.1700520904.git.sharlatanus@gmail.com>
From: Sharlatan Hellseher <sharlatanus@gmail.com>
Date: Mon, 20 Nov 2023 22:52:52 +0000
Subject: [PATCH] gnu: python-cdflib: Disable shaky test.

* gnu/packages/astronomy.scm (python-cdflib): Disable one test which
causing random build failure.
[arguments]{test-flags}: Add it.

Change-Id: I05ee2feca3bc0f0139fa1a5f00b4fe260b42ec80
---
gnu/packages/astronomy.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

Toggle diff (20 lines)
diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index c063285b52..da15283ef3 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -1807,7 +1807,10 @@ (define-public python-cdflib
(base32 "0vpgcbc9pmx0qqfia1frnwq3jkgfp8y3ikqdnzs5bs1sr13p9p3w"))))
(build-system pyproject-build-system)
(arguments
- (list #:phases
+ ;; Disable shaky test.
+ ;; See https://github.com/MAVENSDC/cdflib/issues/234
+ (list #:test-flags #~(list "-k" "not test_compute_cdfepoch16")
+ #:phases
#~(modify-phases %standard-phases
(add-before 'build 'set-env-version
(lambda _

base-commit: d20ece07dbb09382f361c8bbf0bcab9e83d8b73e
--
2.41.0
?