Request for merging "rust-team" branch

Done

Details

3 participants

Efraim Flashner
Ludovic Courtès
Maxim Cournoyer

Owner: unassigned

Submitted by: Efraim Flashner

Severity: normal

Efraim Flashner wrote on 16 Oct 2023 14:30

Recipients:

Message-ID:4D6214A4-E59F-4166-B4D0-2CCCE42F5DB4@flashner.co.il

IMO rust-team branch is ready to merge. We've updated rust to 1.70,
librsvg to 2.56.4 and many new and updated packages. We've added a phase
to the cargo-build-system to fail if it detects pre-built files and
we've set the cargo-build-system to skip the test phase by default,
allowing us to make sure that the packages have the correct inputs. With
these changes I've gotten 100% of the packages built using the
cargo-build-system to build successfully.

We're looking forward to this merge so we can continue bumping the rust
version, work on cross-compilation and try to reduce the number of
packages which skip the build phase entirely.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Maxim Cournoyer wrote on 17 Oct 2023 17:41

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)

Message-ID:87y1g1tfxk.fsf@gmail.com

Hi Efraim,

Efraim Flashner <efraim@flashner.co.il> writes:

Toggle quote (8 lines)

> IMO rust-team branch is ready to merge. We've updated rust to 1.70,

> librsvg to 2.56.4 and many new and updated packages. We've added a phase

> to the cargo-build-system to fail if it detects pre-built files and

> we've set the cargo-build-system to skip the test phase by default,

> allowing us to make sure that the packages have the correct inputs. With

> these changes I've gotten 100% of the packages built using the

> cargo-build-system to build successfully.

This sounds good except I don't understand how disabling the tests by
default help to "make sure that the packages have the correct inputs" ?

You've explained the rationale here:
https://lists.gnu.org/archive/html/guix-devel/2023-10/msg00182.html,
saying we sometimes use a newer Rust than the package tests are
expecting; how does it work in the Rust world?  Don't they always build
even older versions against the most recent compiler?  What about the
test suites then?  Are these not typically run by users/distributions?

For one thing the 'guix lint' command would need to be told that
cargo-build-system has #:tests? set to #f by default to not warn without
reasons that '#:tests? #t' is unnecessary.

-- 
Thanks,
Maxim

Ludovic Courtès wrote on 18 Oct 2023 00:56

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)

Message-ID:871qds7t8m.fsf@gnu.org

Hello!

Efraim Flashner <efraim@flashner.co.il> skribis:

Toggle quote (8 lines)

> IMO rust-team branch is ready to merge. We've updated rust to 1.70,

> librsvg to 2.56.4 and many new and updated packages. We've added a phase

> to the cargo-build-system to fail if it detects pre-built files and

> we've set the cargo-build-system to skip the test phase by default,

> allowing us to make sure that the packages have the correct inputs. With

> these changes I've gotten 100% of the packages built using the

> cargo-build-system to build successfully.

The ‘rust-team’ jobset at https://ci.guix.gnu.orgis now at 78%, which

is actually better than ‘master’ (74%). There are still ~6K

aarch64-linux builds queued but from the numbers it seems ready to be

merged.

(Besides, I’m curious about the answers to the questions Maxim asked

earlier in this thread regarding skipping tests.)

Ludo’.

Efraim Flashner wrote on 18 Oct 2023 10:36

Recipients:(name . Ludovic Courtès)(address . ludo@gnu.org)

Message-ID:ZS-ZEhr-iXBTLIcv@pbp

On Wed, Oct 18, 2023 at 12:56:57AM +0200, Ludovic Courtès wrote:

Toggle quote (17 lines)> Hello!
> 
> Efraim Flashner <efraim@flashner.co.il> skribis:
> 
> > IMO rust-team branch is ready to merge. We've updated rust to 1.70,
> > librsvg to 2.56.4 and many new and updated packages. We've added a phase
> > to the cargo-build-system to fail if it detects pre-built files and
> > we've set the cargo-build-system to skip the test phase by default,
> > allowing us to make sure that the packages have the correct inputs. With
> > these changes I've gotten 100% of the packages built using the
> > cargo-build-system to build successfully.
> 
> The ‘rust-team’ jobset at https://ci.guix.gnu.org is now at 78%, which
> is actually better than ‘master’ (74%).  There are still ~6K
> aarch64-linux builds queued but from the numbers it seems ready to be
> merged.

I'm going to rebase it on master to get the changes over the past month

or so, including the qt-team branch, and let that build out a bit before

merging it.

Toggle quote (3 lines)

> (Besides, I’m curious about the answers to the questions Maxim asked

> earlier in this thread regarding skipping tests.)

I'm going to refer everyone back to the RFC thread on guix-devel to try
to keep everything in one place. I've reverted it for now while we
discuss it further.

-- 
Efraim Flashner   <efraim@flashner.co.il>   ????? ?????
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Efraim Flashner wrote on 18 Oct 2023 10:36

Recipients:(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)

Message-ID:ZS-ZGbsH0gx40DBU@pbp

On Tue, Oct 17, 2023 at 11:41:11AM -0400, Maxim Cournoyer wrote:

Toggle quote (22 lines)> Hi Efraim,
> 
> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > IMO rust-team branch is ready to merge. We've updated rust to 1.70,
> > librsvg to 2.56.4 and many new and updated packages. We've added a phase
> > to the cargo-build-system to fail if it detects pre-built files and
> > we've set the cargo-build-system to skip the test phase by default,
> > allowing us to make sure that the packages have the correct inputs. With
> > these changes I've gotten 100% of the packages built using the
> > cargo-build-system to build successfully.
> 
> This sounds good except I don't understand how disabling the tests by
> default help to "make sure that the packages have the correct inputs" ?
> 
> You've explained the rationale here:
> <https://lists.gnu.org/archive/html/guix-devel/2023-10/msg00182.html>,
> saying we sometimes use a newer Rust than the package tests are
> expecting; how does it work in the Rust world?  Don't they always build
> even older versions against the most recent compiler?  What about the
> test suites then?  Are these not typically run by users/distributions?

I've copied your questions to the thread above and answered them there

so we can keep the discussion in one place.

Toggle quote (4 lines)

> For one thing the 'guix lint' command would need to be told that

> cargo-build-system has #:tests? set to #f by default to not warn without

> reasons that '#:tests? #t' is unnecessary.

I've reverted it for now so we can get the rust-team branch merged and
continue discussing if this is a good idea or not.

-- 
Efraim Flashner   <efraim@flashner.co.il>   ????? ?????
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Maxim Cournoyer wrote on 18 Oct 2023 18:57

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)

Message-ID:87edhruav2.fsf@gmail.com

Hi Efraim,

Efraim Flashner <efraim@flashner.co.il> writes:

Toggle quote (26 lines)> On Tue, Oct 17, 2023 at 11:41:11AM -0400, Maxim Cournoyer wrote:
>> Hi Efraim,
>> 
>> Efraim Flashner <efraim@flashner.co.il> writes:
>> 
>> > IMO rust-team branch is ready to merge. We've updated rust to 1.70,
>> > librsvg to 2.56.4 and many new and updated packages. We've added a phase
>> > to the cargo-build-system to fail if it detects pre-built files and
>> > we've set the cargo-build-system to skip the test phase by default,
>> > allowing us to make sure that the packages have the correct inputs. With
>> > these changes I've gotten 100% of the packages built using the
>> > cargo-build-system to build successfully.
>> 
>> This sounds good except I don't understand how disabling the tests by
>> default help to "make sure that the packages have the correct inputs" ?
>> 
>> You've explained the rationale here:
>> <https://lists.gnu.org/archive/html/guix-devel/2023-10/msg00182.html>,
>> saying we sometimes use a newer Rust than the package tests are
>> expecting; how does it work in the Rust world?  Don't they always build
>> even older versions against the most recent compiler?  What about the
>> test suites then?  Are these not typically run by users/distributions?
>
> I've copied your questions to the thread above and answered them there
> so we can keep the discussion in one place.

OK!

Toggle quote (7 lines)

>> For one thing the 'guix lint' command would need to be told that

>> cargo-build-system has #:tests? set to #f by default to not warn without

>> reasons that '#:tests? #t' is unnecessary.

> I've reverted it for now so we can get the rust-team branch merged and

> continue discussing if this is a good idea or not.

OK, thanks for giving it some extra time.

Thanks,

Maxim

Efraim Flashner wrote on 21 Oct 2023 19:41

Re: bug#66576: Acknowledgement (Request for merging "rust-team" branch)

Recipients:(address . 66576-done@debbugs.gnu.org)

Message-ID:ZTQNQcJtYcByyggK@3900XT

Branch merged! On to the next round of rust updates!

-- 
Efraim Flashner   <efraim@flashner.co.il>   ????? ?????
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 66576@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 66576

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date