[PATCH] gnu: password-store: Fix program name in usage and tmpdir.

  • Done
  • quality assurance status badge
Details
2 participants
  • Nicolas Goaziou
  • Tobias Kortkamp
Owner
unassigned
Submitted by
Tobias Kortkamp
Severity
normal
T
T
Tobias Kortkamp wrote on 22 May 2023 09:44
(address . guix-patches@gnu.org)(name . Tobias Kortkamp)(address . tobias.kortkamp@gmail.com)
a03c745b48e828793352c74235103d12f0e18487.1684740818.git.tobias.kortkamp@gmail.com
* gnu/packages/password-utils.scm (password-store): Fix program name in
usage and tmpdir.
---
gnu/packages/password-utils.scm | 6 ++++++
1 file changed, 6 insertions(+)

Hi,

pass from password-store uses the wrong programn name in its usage. The
program name is also used when creating temporary directories/files during
'pass edit'. It doesn't break anything though AFAICT, so this is purely a
cosmetic issue:

#+begin_src
$ pass help
[...]
Usage:
.pass-real init [--path=subfolder,-p subfolder] gpg-id...
Initialize new password storage and use gpg-id for encryption.
Selectively reencrypt existing passwords using new gpg-id.
[...]
#+end_src

Thanks.

Toggle diff (21 lines)
diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index f5f301308a..b4cd866514 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -563,6 +563,12 @@ (define-public password-store
"${PASSWORD_STORE_SYSTEM_EXTENSION_DIR:-"
extension-dir
"}\"\n"))))))
+ (add-before 'install 'patch-program-name
+ ;; Use pass not .pass-real in tmpdir and cmd_usage
+ (lambda _
+ (substitute* "src/password-store.sh"
+ (("^PROGRAM=.*$")
+ "PROGRAM=\"pass\"\n"))))
(add-before 'install 'patch-passmenu-path
;; FIXME Wayland support requires ydotool and dmenu-wl packages
;; We are ignoring part of the script that gets executed if

base-commit: 849286ba66c96534bddc04df1a47d5692cbc977e
--
2.40.1
N
N
Nicolas Goaziou wrote on 1 Jul 2023 13:15
(name . Tobias Kortkamp)(address . tobias.kortkamp@gmail.com)(address . 63639-done@debbugs.gnu.org)
87y1jzj311.fsf@nicolasgoaziou.fr
Hello,

Tobias Kortkamp <tobias.kortkamp@gmail.com> writes:

Toggle quote (3 lines)
> * gnu/packages/password-utils.scm (password-store): Fix program name in
> usage and tmpdir.

Applied. Thank you.

Regards,
--
Nicolas Goaziou
Closed
?