[PATCH] services: configuration: Fix garbage output in configuration->documentation.

  • Done
  • quality assurance status badge
Details
2 participants
  • Maxim Cournoyer
  • Bruno Victal
Owner
unassigned
Submitted by
Bruno Victal
Severity
normal
B
B
Bruno Victal wrote on 29 Mar 2023 18:06
(address . guix-patches@gnu.org)
4285a8b38718d19543bd47b4c4987efa3c494028.1680105954.git.mirai@makinata.eu

* gnu/services/configuration.scm (define-configuration-helper): Remove call
to display within default-value-thunk.
---
gnu/services/configuration.scm | 1 -
1 file changed, 1 deletion(-)

Toggle diff (14 lines)
diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
index 174c2f20d2..ed9d95f906 100644
--- a/gnu/services/configuration.scm
+++ b/gnu/services/configuration.scm
@@ -264,7 +264,6 @@ (define (define-configuration-helper serialize? serializer-prefix syn)
(serializer field-serializer)
(default-value-thunk
(lambda ()
- (display '#,(id #'stem #'% #'stem))
(if (maybe-value-set? (syntax->datum field-default))
field-default
(configuration-missing-default-value
--
2.39.1
M
M
Maxim Cournoyer wrote on 30 Mar 2023 04:41
(name . Bruno Victal)(address . mirai@makinata.eu)(address . 62525-done@debbugs.gnu.org)
87h6u30xlp.fsf@gmail.com
Hello,

Bruno Victal <mirai@makinata.eu> writes:

Toggle quote (21 lines)
>
> * gnu/services/configuration.scm (define-configuration-helper): Remove call
> to display within default-value-thunk.
> ---
> gnu/services/configuration.scm | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
> index 174c2f20d2..ed9d95f906 100644
> --- a/gnu/services/configuration.scm
> +++ b/gnu/services/configuration.scm
> @@ -264,7 +264,6 @@ (define (define-configuration-helper serialize? serializer-prefix syn)
> (serializer field-serializer)
> (default-value-thunk
> (lambda ()
> - (display '#,(id #'stem #'% #'stem))
> (if (maybe-value-set? (syntax->datum field-default))
> field-default
> (configuration-missing-default-value

This one also :-).

--
Thanks,
Maxim
Closed
?