'guix style' sometimes makes poor indentation choices

  • Open
  • quality assurance status badge
Details
One participant
  • Maxim Cournoyer
Owner
unassigned
Submitted by
Maxim Cournoyer
Severity
normal

Debbugs page

Maxim Cournoyer wrote 2 years ago
(name . bug-guix)(address . bug-guix@gnu.org)
87wn39ilpb.fsf@gmail.com
Hi,

Looking at #61263, there's an example of some indentation choice gone
wrong:

Toggle snippet (29 lines)
@@ -705,59 +705,63 @@ (define-public dbacl
(package
(name "dbacl")
(version "1.14.1")
- (source
- (origin
- (method url-fetch)
- (uri (string-append "mirror://sourceforge/dbacl/dbacl/" version "/"
- "dbacl-" version ".tar.gz"))
- (sha256
- (base32 "1gas0112wqjvwn9qg3hxnawk7h3prr0w9b2h68f3p1ifd1kzn3gz"))
- (patches (search-patches "dbacl-include-locale.h.patch"))))
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://sourceforge/dbacl/dbacl/"
+ version
+ "/"
+ "dbacl-"
+ version
+ ".tar.gz"))
+ (sha256
+ (base32
+ "1gas0112wqjvwn9qg3hxnawk7h3prr0w9b2h68f3p1ifd1kzn3gz"))
+ (patches (search-patches "dbacl-include-locale.h.patch"
+ "dbacl-icheck-multiple-definitions.patch"))))
(build-system gnu-build-system)
(arguments

The original was superior, at least for the URI part, which is now
overly broken into multiple lines, not making good use of the available
80 characters of width available.

--
Thanks,
Maxim
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send an email to 62365@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 62365
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help