[PATCH 00/25] gnu: golang: Add gopls

  • Open
  • quality assurance status badge
Details
2 participants
  • Katherine Cox-Buday
  • Tobias Geerinckx-Rice
Owner
unassigned
Submitted by
Katherine Cox-Buday
Severity
normal
Merged with
K
K
Katherine Cox-Buday wrote on 18 Jan 02:44 +0100
(address . guix-patches@gnu.org)(name . Katherine Cox-Buday)(address . cox.katherine.e@gmail.com)
20230118014510.19320-1-cox.katherine.e@gmail.com
This is a patch series to add the gopls package.

I haven't contributed to many projects which use the e-mail flow, so hopefully
I'm doing this correctly. Please feel free to make suggestions if not!

Some of the diffs are a little busier than I'd like for version bumps. This is
due to running `guix style` over everything.

For all of the packages I have:

. Run guix style
. Run guix lint
. Built 2x
. Checked that the change is in the correct branch
. Built all dependencies
. Built the repository

Katherine Cox-Buday (25):
gnu: go-golang-org-x-sync: Update to 0.1.0-1.8fcdb60.
gnu: go-golang-org-x-mod: Update to 0.7.0.
gnu: Add go-golang-org-x-exp.
gnu: Add go-github-com-jba-printsrc.
gnu: Add go-github-com-google-safehtml.
gnu: Add go-github-com-jba-templatecheck.
gnu: go-github-com-google-go-cmp-cmp: Update to 0.5.9.
gnu: go-github-com-pkg-diff: Update to
0.0.0-20210226163009-20ebb0f2a09e.
gnu: go-github-com-rogpeppe-go-internal: Update to 1.9.0.
gnu: gopkg-in-errgo-fmt-errors: Rename package to
go-gopkg-in-errgo-fmt-errors.
gnu: go-golang-org-x-tools: Update to 0.5.0.
gnu: Add xurls.
gnu: Add go-mvdan-cc-xurls.
gnu: Add misspell.
gnu: Add go-github-com-client9-misspell.
gnu: Add go-github-com-google-go-cmdtest.
gnu: Add unparam.
gnu: Add go-mvdan-cc-unparam.
gnu: Add govulncheck.
gnu: Add go-golang-org-x-vuln.
gnu: go-github-com-burntsushi-toml: Update to 1.2.1.
gnu: go-honnef-co-go-tools: Update to 0.3.3.
gnu: Add gofumpt.
gnu: Add go-mvdan-cc-gofumpt.
gnu: Add gopls.

gnu/packages/configuration-management.scm | 2 +-
gnu/packages/golang.scm | 695 ++++++++++++++++++----
2 files changed, 578 insertions(+), 119 deletions(-)


base-commit: 5c921977179489caef4a9e54ada6696fc86d2f0b
--
2.38.1
K
K
Katherine Cox-Buday wrote on 18 Jan 02:45 +0100
[PATCH 25/25] gnu: Add gopls.
(address . guix-patches@gnu.org)(name . Katherine Cox-Buday)(address . cox.katherine.e@gmail.com)
20230118014510.19320-26-cox.katherine.e@gmail.com
* gnu/packages/golang.scm (gopls): New variable.
---
gnu/packages/golang.scm | 45 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)

Toggle diff (58 lines)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 3dcd97a8c1..faa6c61bc4 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -3021,6 +3021,51 @@ (define-public go-golang-org-x-vuln
(native-inputs '())
(inputs '())))
+(define-public gopls
+ (package
+ (name "gopls")
+ (version "0.11.0")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://go.googlesource.com/tools")
+ (commit (string-append "gopls/v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1l9y1rp7x51s6dnjn227fhdlnz4z1h41jn3x1aq49qki241w7m73"))))
+ (build-system go-build-system)
+ (arguments
+ `(#:import-path "golang.org/x/tools/gopls"
+ #:unpack-path "golang.org/x/tools"
+ #:install-source? #f
+ #:phases (modify-phases %standard-phases
+ (add-before 'unpack 'override-tools
+ (lambda _
+ (delete-file-recursively "src/golang.org/x/tools"))))))
+ (propagated-inputs (list go-github-com-google-go-cmp-cmp
+ go-github-com-jba-printsrc
+ go-github-com-jba-templatecheck
+ go-github-com-sergi-go-diff
+ go-golang-org-x-mod
+ go-golang-org-x-sync
+ go-golang-org-x-sys
+ go-golang-org-x-text
+ go-gopkg-in-yaml-v3
+ go-honnef-co-go-tools
+ go-github-com-burntsushi-toml
+ go-github-com-google-safehtml
+ go-golang-org-x-exp
+ go-mvdan-cc-gofumpt
+ go-golang-org-x-vuln
+ go-mvdan-cc-xurls))
+ (home-page "https://golang.org/x/tools/gopls")
+ (synopsis "Official language server for the Go language")
+ (description
+ "Pronounced \"Go please\", this is the official Go language server developed by
+the Go team. It provides IDE features to any LSP-compatible editor.")
+ (license license:bsd-3)))
+
(define-public go-github-com-protonmail-go-crypto
(package
(name "go-github-com-protonmail-go-crypto")
--
2.38.1
T
T
Tobias Geerinckx-Rice wrote on 18 Jan 11:56 +0100
(no subject)
(address . control@debbugs.gnu.org)
542e82bcc0f385c117ba662c7dcf1dbf@tobias.gr
merge 60898 60899 60900 60901 60902
merge 60898 60903 60904 60905 60906
merge 60898 60907 60908 60909 60910
merge 60898 60911 60912 60913 60914
merge 60898 60915 60916 60917 60918
merge 60898 60919 60920
T
T
Tobias Geerinckx-Rice wrote on 18 Jan 12:43 +0100
(address . control@debbugs.gnu.org)
37de5823441633151229c783f2acfca3@tobias.gr
merge 60898 60921 60922
thanks

Weird: I got ‘Unknown command or malformed arguments to command.’ for
this obviously correct line.

Let's try again.
K
K
Katherine Cox-Buday wrote on 18 Jan 18:07 +0100
Merging erroneously opened bugs
(address . control@debbugs.gnu.org)
87zgafrct9.fsf@gmail.com
merge 60899 60904 60907 60908 60917 60920 60921 60919 60910 60903 60915 60914 60922 60909 60918 60913 60900 60899 60905 60901 60912 60898 60906 60902 60916 60911
--
Katherine
K
K
Katherine Cox-Buday wrote 13 hours ago
Request for review of: [bug#60899] [PATCH 00/25] gnu: golang: Add gopls
878rhkyney.fsf@gmail.com
Katherine Cox-Buday <cox.katherine.e@gmail.com> writes:

Toggle quote (54 lines)
> This is a patch series to add the gopls package.
>
> I haven't contributed to many projects which use the e-mail flow, so
> hopefully I'm doing this correctly. Please feel free to make
> suggestions if not!
>
> Some of the diffs are a little busier than I'd like for version bumps.
> This is due to running `guix style` over everything.
>
> For all of the packages I have:
>
> . Run guix style
> . Run guix lint
> . Built 2x
> . Checked that the change is in the correct branch
> . Built all dependencies
> . Built the repository
>
> Katherine Cox-Buday (25):
> gnu: go-golang-org-x-sync: Update to 0.1.0-1.8fcdb60.
> gnu: go-golang-org-x-mod: Update to 0.7.0.
> gnu: Add go-golang-org-x-exp.
> gnu: Add go-github-com-jba-printsrc.
> gnu: Add go-github-com-google-safehtml.
> gnu: Add go-github-com-jba-templatecheck.
> gnu: go-github-com-google-go-cmp-cmp: Update to 0.5.9.
> gnu: go-github-com-pkg-diff: Update to
> 0.0.0-20210226163009-20ebb0f2a09e.
> gnu: go-github-com-rogpeppe-go-internal: Update to 1.9.0.
> gnu: gopkg-in-errgo-fmt-errors: Rename package to
> go-gopkg-in-errgo-fmt-errors.
> gnu: go-golang-org-x-tools: Update to 0.5.0.
> gnu: Add xurls.
> gnu: Add go-mvdan-cc-xurls.
> gnu: Add misspell.
> gnu: Add go-github-com-client9-misspell.
> gnu: Add go-github-com-google-go-cmdtest.
> gnu: Add unparam.
> gnu: Add go-mvdan-cc-unparam.
> gnu: Add govulncheck.
> gnu: Add go-golang-org-x-vuln.
> gnu: go-github-com-burntsushi-toml: Update to 1.2.1.
> gnu: go-honnef-co-go-tools: Update to 0.3.3.
> gnu: Add gofumpt.
> gnu: Add go-mvdan-cc-gofumpt.
> gnu: Add gopls.
>
> gnu/packages/configuration-management.scm | 2 +-
> gnu/packages/golang.scm | 695 ++++++++++++++++++----
> 2 files changed, 578 insertions(+), 119 deletions(-)
>
>
> base-commit: 5c921977179489caef4a9e54ada6696fc86d2f0b

Hello Guix! Acknowledging that everyone are volunteers, and busy (guilty
myself), this is a humble request for a review of this patch-series I
made two weeks ago so that it doesn't bit-rot.

I have a `gopls` home service[1] waiting to be proposed after this
patch-series is merged.

Thank you very much!


P.S. I think I am following etiquette for review reminders (i.e. waiting
long enough, bringing this over to guix-devel), but I was having trouble
finding examples. If I haven't waited long enough, or have reminded in
the wrong way, please give me feedback.

--
Katherine
?