[PATCH] guix-install.sh: Source both profiles, default user's and home.

  • Done
  • quality assurance status badge
Details
2 participants
  • Andrew Tropin
  • Ludovic Courtès
Owner
unassigned
Submitted by
Andrew Tropin
Severity
normal
A
A
Andrew Tropin wrote on 13 Jan 2023 11:09
(address . guix-patches@gnu.org)
87pmbi20qy.fsf@trop.in
* etc/guix-install.sh (sys_create_init_profile): Source both profiles, default
user's and home.
---
Sourced both profiles and both added to GUIX_LOCPATH if they exist.

return outside of the function AFAIK doesn't make sense, removed it.

In some future we could make a dummy locale-consumer package, which will make
$GUIX_PROFILE/etc/profile export GUIX_LOCPATH, so special treatment in this
script won't be needed anymore.

etc/guix-install.sh | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)

Toggle diff (40 lines)
diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 3ce9affc06..79f5be66b1 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -11,6 +11,7 @@
# Copyright © 2021 Chris Marusich <cmmarusich@gmail.com>
# Copyright © 2021, 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
# Copyright © 2022 Prafulla Giri <prafulla.giri@protonmail.com>
+# Copyright © 2023 Andrew Tropin <andrew@trop.in>
#
# This file is part of GNU Guix.
#
@@ -534,15 +535,19 @@ export PATH="$_GUIX_PROFILE/bin${PATH:+:}$PATH"
# searches 'Info-default-directory-list'.
export INFOPATH="$_GUIX_PROFILE/share/info:$INFOPATH"

-# GUIX_PROFILE: User's default profile
-# Prefer the one from 'guix home' if it exists.
+# GUIX_PROFILE: User's default profile and home profile
+GUIX_PROFILE="$HOME/.guix-profile"
+[ -f "$GUIX_PROFILE/etc/profile" ] && . "$GUIX_PROFILE/etc/profile"
+[ -L $GUIX_PROFILE ] || \
+GUIX_LOCPATH="$GUIX_PROFILE/lib/locale:${GUIX_LOCPATH:+:}$GUIX_LOCPATH"
+
GUIX_PROFILE="$HOME/.guix-home/profile"
-[ -L $GUIX_PROFILE ] || GUIX_PROFILE="$HOME/.guix-profile"
-[ -L $GUIX_PROFILE ] || return
-GUIX_LOCPATH="$GUIX_PROFILE/lib/locale"
+[ -f "$GUIX_PROFILE/etc/profile" ] && . "$GUIX_PROFILE/etc/profile"
+[ -L $GUIX_PROFILE ] || \
+GUIX_LOCPATH="$GUIX_PROFILE/lib/locale:${GUIX_LOCPATH:+:}$GUIX_LOCPATH"
+
export GUIX_LOCPATH

-[ -f "$GUIX_PROFILE/etc/profile" ] && . "$GUIX_PROFILE/etc/profile"
EOF
}

--
2.38.1
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmPBMLUACgkQIgjSCVjB
3rDrqQ/+MzfgLFxKMU4k0qC+wDeKNvyjqQFG1unvW3M7Cm0Szedd42Sas52PzdDa
fnIUft2X8S09CUM5p3u/VEpXntEgcyl2WTcAZkaltnreyiPFL4h0EtVU5ksiOirh
MO+//dPVr5/JDO/u8rwT2brz5pg8eeUt2ji8Ehq8MTq1sWcyZKkGm57l4wLSIfqC
dD8r3t1GVnS4rVb4JgodUFxwNNkqxg7JOezsisMvKiEGYzqBgAK1UyHf1v/wS4iV
w9bvGkkSuhkYvRBKeicljMu4tUqUssjeKiNgecw2I97tdMA57entUkQ7h2mNRZgn
tWSvvR7a7s5vp8hrUL+7HCI9QpHWEq29dPuZAtpmoM1t5yGwpSUL224A0Np3DRbx
HRVs1uSHbunIv3FV+pQ8oDpr8OlhAJzLTnYfGgsv+N4PrAht5sHR/QNn9l3kFjgI
bvwB39uOJTq4CVi8Neq9cvAnnnvKDiospZY7oFM0KwxEU/kgm1fvdYhHmbQFP893
SePwcwpnYwSLIv9TeZUsdSHEYEavbPmxD+uMLOme1Ks+6hkI5TR5fHC/W5ljTXWK
ulS3lCENMF7dFkpPHuxt1DvFjZWM3Tfaf+eG5RkCE9JQfnelC3xO2wFWQFC/jUf1
CjTtCW8Rp17cGeGpfSHFha6UJkhgB0J5fmEob7WLgf0EU/2mXek=
=css4
-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 7 Apr 2023 17:24
(name . Andrew Tropin)(address . andrew@trop.in)(address . 60778@debbugs.gnu.org)
87a5zjd8bs.fsf@gnu.org
Hi,

Andrew Tropin <andrew@trop.in> skribis:

Toggle quote (3 lines)
> * etc/guix-install.sh (sys_create_init_profile): Source both profiles, default
> user's and home.

[...]

Toggle quote (2 lines)
> +[ -L $GUIX_PROFILE ] || \

[...]

Toggle quote (2 lines)
> +[ -L $GUIX_PROFILE ] || \

This should be enclosed in double quotes.

Otherwise LGTM, thanks!

Ludo’.
A
A
Andrew Tropin wrote on 9 Apr 2023 09:07
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 60778-done@debbugs.gnu.org)
87edotcz42.fsf@trop.in
On 2023-04-07 17:24, Ludovic Courtès wrote:

Toggle quote (21 lines)
> Hi,
>
> Andrew Tropin <andrew@trop.in> skribis:
>
>> * etc/guix-install.sh (sys_create_init_profile): Source both profiles, default
>> user's and home.
>
> [...]
>
>> +[ -L $GUIX_PROFILE ] || \
>
> [...]
>
>> +[ -L $GUIX_PROFILE ] || \
>
> This should be enclosed in double quotes.
>
> Otherwise LGTM, thanks!
>
> Ludo’.

Thank you for the review, adjusted, applied and pushed as

--
Best regards,
Andrew Tropin
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmQyZD4ACgkQIgjSCVjB
3rBIow/+N2BigEkRSbPS4n+gmk2Q8KdsMlpn+FXgeUn74QgOEEA/1fxV7cPtoVq0
kceX9DTx4UU/QD6dZ0Ov/g2/u7PQAf8LI1jPc+CM4MF9E1gUS9aLKmtMj9VOhydm
nE5H6XNMI263ywYhtfvIYrQw5+5SC6AtUF3dHqHFYqfaWP9QIZZRK8Q86fPxcb0u
/2Crmw0Jb7Hbf6DQs6x9tIwzVluNn738w+YSsi1/lVCp0JjJO3RoRTXQPY5qPxzo
3Vl1BTuI8SEzigJ5CNmxXOPrn1M+MhLufFf9JchwTlvsV/D36u517k9vK2JL2Jzt
AF32kmCIIMaVfyhQS80TySWSyOppaemWigVz94+L9Fn/av8BI5ABoBLISgbkf4+I
wbhI0hdqhYea3fS9cBMmUMKUmfEtCu9gC7Tvk+Lk51aRFkHpY8fzSszxNcnI09Xc
EY9McoH5droaBRdZG5JaDI4queVOY6hnxmv06XGlzmOVi3T/En1Y5KSqIXuSZHhW
QELcy9Hd2eeWX2OReu0rJEXsbJS7BzQu2PgihjyauQKOd+SNJkYyO4D7mx1Uav5x
UqISngr5tU/ZcEJzRY1lt+73EvkTaVEl19vL7euVP9n1XCEYWNr2LwnZ8W21LEPh
EusGsFphHVwiTRQg3WEzPQFLg0VGrLH6FrMEp/eSK2DzBAJ4ELo=
=mb6B
-----END PGP SIGNATURE-----

Closed
?