[PATCH] gnu: musescore: Fix build.

  • Done
  • quality assurance status badge
Details
3 participants
  • Liliana Marie Prikler
  • Nicolas Goaziou
  • Vivien Kraus
Owner
unassigned
Submitted by
Liliana Marie Prikler
Severity
normal
L
L
Liliana Marie Prikler wrote on 16 Dec 2022 00:31
(address . guix-patches@gnu.org)(name . Nicolas Goaziou)(address . mail@nicolasgoaziou.fr)
26ccc41a0b59e854f261e65cfee65803e78746f7.camel@gmail.com
* gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
associated install actions.
[arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.
---
gnu/packages/music.scm | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)

Toggle diff (28 lines)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 614eb57791..0d7fb21701 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4787,14 +4787,19 @@ (define-public musescore
(base32 "16rcwr6fzghv8100syzicabqg8jqvng3zzsi6h3ja4zkp9hcbkcr"))
(modules '((guix build utils)))
(snippet
- ;; Remove unused libraries.
'(begin
+ ;; Remove unused libraries...
(for-each delete-file-recursively
- '("thirdparty/freetype"))))))
+ '("thirdparty/freetype"))
+ ;; ... and precompiled binaries.
+ (delete-file-recursively "src/diagnostics/crashpad_handler")
+ (substitute* "src/diagnostics/CMakeLists.txt"
+ (("install") "#install"))))))
(build-system qt-build-system)
(arguments
`(#:configure-flags
`("-DDOWNLOAD_SOUNDFONT=OFF"
+ "-DBUILD_DIAGNOSTICS=OFF"
"-DMUSESCORE_BUILD_CONFIG=release"
"-DUSE_SYSTEM_FREETYPE=ON")
;; There are tests, but no simple target to run. The command used to
--
2.38.1
N
N
Nicolas Goaziou wrote on 16 Dec 2022 18:39
(name . Liliana Marie Prikler)(address . liliana.prikler@gmail.com)(address . 60108@debbugs.gnu.org)
87h6xvdz8o.fsf@nicolasgoaziou.fr
Hello,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

Toggle quote (4 lines)
> * gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
> associated install actions.
> [arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.

FWIW, qa.guix.gnu.org says it looks good to it.

Regards,
--
Nicolas Goaziou
V
V
Vivien Kraus wrote on 18 Dec 2022 17:27
[PATCH] gnu: musescore: Fix build.
(address . 60108@debbugs.gnu.org)
6dc5437d4353b9bd395ace241c9ad61dff18124a.camel@planete-kraus.eu
I tried this patch, but unfortunately MuseScore crashes on startup,
saying that: qrc:/qml/DevTools/Preferences/SettingsPage.qml:24:1:
module "QtQuick.Dialogs" is not installed

I checked the source, and QtQuick.Dialogs is indeed imported in a bunch
of QML files.

I don’t know much about qt, so I’m not sure how to proceed. I tried to
copy the package for qtquick-controls to qtquick-dialogs, but guix
can’t find any source for that.

Best regards,

Vivien
V
V
Vivien Kraus wrote on 18 Dec 2022 21:12
(address . 60108@debbugs.gnu.org)
7eb96002894637767d5a02f777b43e6bb74fd40c.camel@planete-kraus.eu
Le dimanche 18 décembre 2022 à 17:27 +0100, Vivien Kraus a écrit :
Toggle quote (4 lines)
> I tried this patch, but unfortunately MuseScore crashes on startup,
> saying that: qrc:/qml/DevTools/Preferences/SettingsPage.qml:24:1:
> module "QtQuick.Dialogs" is not installed

Adding both qtquickcontrols-5 and qtquickcontrols2-5 fixes the issue :)
N
N
Nicolas Goaziou wrote on 19 Dec 2022 16:40
Re: [bug#60108] [PATCH] gnu: musescore: Fix build.
(name . Vivien Kraus via Guix-patches via)(address . guix-patches@gnu.org)
87v8m7csgq.fsf@nicolasgoaziou.fr
Hello,

Vivien Kraus via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (8 lines)
> Le dimanche 18 décembre 2022 à 17:27 +0100, Vivien Kraus a écrit :
>> I tried this patch, but unfortunately MuseScore crashes on startup,
>> saying that: qrc:/qml/DevTools/Preferences/SettingsPage.qml:24:1:
>> module "QtQuick.Dialogs" is not installed
>
> Adding both qtquickcontrols-5 and qtquickcontrols2-5 fixes the
> issue :)

Would you mind sending a patch including this, so that we can apply it
and close the issue?

Regards,
--
Nicolas Goaziou
V
V
Vivien Kraus wrote on 16 Dec 2022 00:31
[PATCH v2] gnu: musescore: Fix build.
(address . 60108@debbugs.gnu.org)(name . Nicolas Goaziou)(address . mail@nicolasgoaziou.fr)
f5b6663812bd2158d398b00f44f68c1bd0644dfb.camel@planete-kraus.eu
From: Liliana Marie Prikler <liliana.prikler@gmail.com>

* gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
associated install actions.
[arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.
[inputs]: Add qtquickcontrols-5.
---
gnu/packages/music.scm | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

Toggle diff (38 lines)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 614eb57791..bde01cb312 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4787,14 +4787,19 @@ (define-public musescore
(base32 "16rcwr6fzghv8100syzicabqg8jqvng3zzsi6h3ja4zkp9hcbkcr"))
(modules '((guix build utils)))
(snippet
- ;; Remove unused libraries.
'(begin
+ ;; Remove unused libraries...
(for-each delete-file-recursively
- '("thirdparty/freetype"))))))
+ '("thirdparty/freetype"))
+ ;; ... and precompiled binaries.
+ (delete-file-recursively "src/diagnostics/crashpad_handler")
+ (substitute* "src/diagnostics/CMakeLists.txt"
+ (("install") "#install"))))))
(build-system qt-build-system)
(arguments
`(#:configure-flags
`("-DDOWNLOAD_SOUNDFONT=OFF"
+ "-DBUILD_DIAGNOSTICS=OFF"
"-DMUSESCORE_BUILD_CONFIG=release"
"-DUSE_SYSTEM_FREETYPE=ON")
;; There are tests, but no simple target to run. The command used to
@@ -4825,6 +4830,7 @@ (define-public musescore
qtdeclarative-5
qtgraphicaleffects
qtnetworkauth-5
+ qtquickcontrols-5
qtquickcontrols2-5
qtscript
qtsvg-5

base-commit: 05e4efe0c83c09929d15a0f5faa23a9afc0079e4
--
2.38.1
V
V
Vivien Kraus wrote on 19 Dec 2022 17:52
Re: [bug#60108] [PATCH] gnu: musescore: Fix build.
(address . 60108@debbugs.gnu.org)
1d693bdf11c8649841f9264c2000da9a9b32355a.camel@planete-kraus.eu
Le lundi 19 décembre 2022 à 16:40 +0100, Nicolas Goaziou a écrit :
Toggle quote (4 lines)
> Would you mind sending a patch including this, so that we can apply
> it
> and close the issue?

I think I messed things up and the original "From:" header is now in
the commit message, sorry.

Can you fix it on your end? I’m not sure I know how to keep the patch
author information while still being able to send it.

Vivien
N
N
Nicolas Goaziou wrote on 19 Dec 2022 18:19
Re: [bug#60108] [PATCH v2] gnu: musescore: Fix build.
(name . Vivien Kraus via Guix-patches via)(address . guix-patches@gnu.org)
87r0wvcnw3.fsf@nicolasgoaziou.fr
Hello,

Vivien Kraus via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (7 lines)
> From: Liliana Marie Prikler <liliana.prikler@gmail.com>
>
> * gnu/packages/music.scm (musescore)[snippet]: Remove crashpad_handler and
> associated install actions.
> [arguments]<#:configure-flags>: Add “-DBUILD_DIAGNOSTICS=OFF”.
> [inputs]: Add qtquickcontrols-5.

Thanks to you both.

I added Vivien as a co-author and applied the patch. I'm closing this
issue. Feel free to re-open it if you think something is missing.

Regards,
--
Nicolas Goaziou
?