[PATCH] gnu: Add emacs-pdb-capf.

  • Done
  • quality assurance status badge
Details
2 participants
  • jgart
  • Nicolas Goaziou
Owner
unassigned
Submitted by
jgart
Severity
normal
J
J
jgart wrote on 7 Aug 2022 02:00
(address . guix-patches@gnu.org)(name . jgart)(address . jgart@dismail.de)
20220807000058.19106-1-jgart@dismail.de
* gnu/packages/emacs-xyz.scm (emacs-pdb-capf): New variable.
---
gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)

Toggle diff (39 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5e60d4fafd..b73383431f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -31947,6 +31947,32 @@ (define-public emacs-consult-lsp
by leveraging @code{emacs-consult} APIs.")
(license license:expat)))
+(define-public emacs-pdb-capf
+ (let ((commit "2f4099aa1330f87df4e9cd526de057ee9b71de6c")
+ (revision "0"))
+ (package
+ (name "emacs-pdb-capf")
+ (version (git-version "1.0" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/muffinmad/emacs-pdb-capf")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0fdzhsz3784lf50mdabz9h2b6992cab2nnn4xv7rx2a8hsyyq1mq"))))
+ (build-system emacs-build-system)
+ (propagated-inputs
+ (list emacs-imgur-el))
+ (home-page "https://github.com/muffinmad/emacs-pdb-capf")
+ (synopsis "Completion-at-point function for pdb")
+ (description
+"@code{emacs-pdb-capf} provides a @code{completion-at-point} function
+for pdb allowing completion in a @code{*gud-pdb*} buffer.")
+ (license license:gpl3+))))
+
(define-public emacs-bitbake-modes
(package
(name "emacs-bitbake-modes")
--
2.37.1
N
N
Nicolas Goaziou wrote on 25 Aug 2022 13:48
(name . jgart via Guix-patches via)(address . guix-patches@gnu.org)
877d2wsfvd.fsf@nicolasgoaziou.fr
Hello,

jgart via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (2 lines)
> * gnu/packages/emacs-xyz.scm (emacs-pdb-capf): New variable.

Thank you.

Toggle quote (3 lines)
> + (propagated-inputs
> + (list emacs-imgur-el))

You need to package this first.

Regards,
--
Nicolas Goaziou
J
J
jgart wrote on 25 Aug 2022 15:36
(name . Nicolas Goaziou)(address . mail@nicolasgoaziou.fr)
20220825083651.GB11540@gac
On Thu, 25 Aug 2022 13:48:54 +0200 Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
Toggle quote (11 lines)
> Hello,
>
> jgart via Guix-patches via <guix-patches@gnu.org> writes:
>
> > * gnu/packages/emacs-xyz.scm (emacs-pdb-capf): New variable.
>
> Thank you.
>
> > + (propagated-inputs
> > + (list emacs-imgur-el))

Oh, that's a mistake. emacs-pdb-capf doesn't need that package. Not sure how that happened. I'll send an updated patch.
J
J
jgart wrote on 25 Aug 2022 15:48
[PATCH v2] gnu: Add emacs-pdb-capf.
(address . 57024@debbugs.gnu.org)
20220825134802.12423-1-jgart@dismail.de
* gnu/packages/emacs-xyz.scm (emacs-pdb-capf): New variable.

Hi Nicolas,

Here is v2 with the spurious dependency removed. I also bumped the package.

Thanks for the review and for looking at this.

all best,

jgart
---
gnu/packages/emacs-xyz.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)

Toggle diff (37 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f01af98c7c..325a366fc9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -32003,6 +32003,30 @@ (define-public emacs-consult-lsp
by leveraging @code{emacs-consult} APIs.")
(license license:expat)))
+(define-public emacs-pdb-capf
+ (let ((commit "31602ccab53aa7dcf26a1af222c7da2bcc1390ed")
+ (revision "0"))
+ (package
+ (name "emacs-pdb-capf")
+ (version (git-version "1.0" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/muffinmad/emacs-pdb-capf")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "0x2pg03csf25vj8y2zb5sv493dk3n0s4xbkihii2mzhkx82vgpxg"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/muffinmad/emacs-pdb-capf")
+ (synopsis "Completion-at-point function for pdb")
+ (description
+"@code{emacs-pdb-capf} provides a @code{completion-at-point} function
+for pdb allowing completion in a @code{*gud-pdb*} buffer.")
+ (license license:gpl3+))))
+
(define-public emacs-bitbake-modes
(package
(name "emacs-bitbake-modes")
--
2.37.2
N
N
Nicolas Goaziou wrote on 25 Aug 2022 19:00
(name . jgart)(address . jgart@dismail.de)(address . 57024-done@debbugs.gnu.org)
87k06wqmut.fsf@nicolasgoaziou.fr
Hello,

jgart <jgart@dismail.de> writes:

Toggle quote (2 lines)
> * gnu/packages/emacs-xyz.scm (emacs-pdb-capf): New variable.

Applied. Thank you.

Regards,
--
Nicolas Goaziou
Closed
?