GUIX Image API: wrong fs type and flag

I have a scheme code like

(define rpi-boot-partition

(partition

(size (* 128 (expt 2 20)))

(label "BOOT")

(file-system "vfat")

(flags '())

(initializer (gexp initialize-efi-partition))))

(define rpi-root-partition

(partition

(size 'guess)

(label "RASPIROOT")

(file-system "ext4")

(flags '(boot))

(initializer (gexp initialize-root-partition))))

(define raspberry-pi-image

(image

(format 'disk-image)

(partitions (list rpi-boot-partition rpi-root-partition))))

The output is like that:

$ fdisk -l /gnu/store/hnsfs5a161f5hvymg7ar541qrml62yvv-raspberry-pi-barebones-raw-image

Device Boot Start End Sectors Size Id Type

/gnu/store/hnsfs5a161f5hvymg7ar541qrml62yvv-raspberry-pi-barebones-raw-image1 1 262144 262144 128M 83 Linux

/gnu/store/hnsfs5a161f5hvymg7ar541qrml62yvv-raspberry-pi-barebones-raw-image2 262145 3583688 3321544 1.6G 83 Linux

No boot flag is set on the first partition. The file system seems to be incorrect (ext* instead of vfat)

merge 55405 55406

merge 55405 55406

thanks

(duplicate)

I found it. It blows my mind. Let me just cry out here.

(define (partition->dos-type partition)

;; Return the MBR partition type corresponding to the given PARTITION.

;; See: https://en.wikipedia.org/wiki/Partition_type.

(let ((flags (partition-flags partition)))

(cond

((member 'esp flags) "0xEF")

(else "0x83"))))

(define (partition->gpt-type partition)

;; Return the genimage GPT partition type code corresponding to PARTITION.

;; See https://github.com/pengutronix/genimage/blob/master/README.rst

(let ((flags (partition-flags partition)))

(cond

((member 'esp flags) "U")

(else "L"))))

It looks like setting esp flag with (flags '(esp)) also sets file system to vfat. However,

1. I still cannot resolve boot flag issue

2. I do not need that flag and I’d be glad getting correct partition without it

I have written a small patch to partially fix the issue. Flags are still not set. GPT is still not fixed. There’s no need to return file systems that are not supported in make-partition-image function in gnu/build/image.scm

This patch fixes GPT support for fat partitions. Should be applied after gpt-support-vfat-partitions.patch

Here’s the last patch in the set that adds support for the boot flag. It should be merged after mbr-support-vfat-partitions.patch and gpt-support-vfat-partitions.patch

The issue can be closed as soon as all three patches are merged.

Have a nice day!

Hello Pavel,

Thanks for those three patches. At first sight, they look fine :) It

would be great if you could resend them using "git format-patch",

following the guidelines available here:

Could you also add your copyright on top of the edited files?

Mathieu

Ok, I tried to format them :)

Hello Pavel,

Thanks, I added commit messages following our guidelines, fixed the

indentation and a few other small details.

Pushed on master!

Mathieu