guix home reconfigure fails with “rmdir: No such file or directory”

Done

Details

4 participants

Brian Cully
Ludovic Courtès
Madhavan Krishnan
Christopher Rodriguez

Owner: unassigned

Submitted by: Brian Cully

Severity: normal

Brian Cully wrote on 10 Apr 2022 01:53

Recipients:(address . bug-guix@gnu.org)

Message-ID:878rsdbygd.fsf@ditto.jhoto.spork.org

For the last few days, attempting to issue a home reconfigure fails:

---[snip]---
$ guix home reconfigure ./guix-home/config-new.scm
substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
substitute: updating substitutes from 'https://bordeaux.guix.gnu.org'... 100.0%
The following derivations will be built:
  /gnu/store/rbnri9gpvh98qagyk7ws4y5xdvz4skg7-home.drv
  /gnu/store/hg5whdfsq2ldibfsikhbwppr9pms5vc8-provenance.drv
  /gnu/store/rsil5s5fs14y2jvysbiv7vi2f0i3gnw2-activate.drv
  /gnu/store/j85krrfbnc7x6s5wdn0wnp8ikah9gl46-update-symlinks.drv

building /gnu/store/hg5whdfsq2ldibfsikhbwppr9pms5vc8-provenance.drv...
building /gnu/store/j85krrfbnc7x6s5wdn0wnp8ikah9gl46-update-symlinks.drv...
building /gnu/store/rsil5s5fs14y2jvysbiv7vi2f0i3gnw2-activate.drv...
building /gnu/store/rbnri9gpvh98qagyk7ws4y5xdvz4skg7-home.drv...
Cleaning up symlinks from previous home at /gnu/store/zmp2brsdr0nvrhpbk4kqqc6y8jx90kb1-home.

guix home: error: rmdir: No such file or directory
---[snip]---

This fails in the same way even when using a previously working
configuration:

---[snip]---
$ guix home list-generations
	⋮
Generation 27	Apr 05 2022 19:44:03	(current)
  file name: /var/guix/profiles/per-user/bjc/guix-home-27-link
  canonical file name: /gnu/store/zmp2brsdr0nvrhpbk4kqqc6y8jx90kb1-home
  channels:
    guix:
      repository URL: https://git.savannah.gnu.org/git/guix.git
      branch: master
      commit: 3b3cc9dfed30afec70a6feaced3710bf79f8b2bc
  configuration file: /gnu/store/k90xv2x75nfc1wyxbw4171m6wxykqck6-configuration.scm

$ guix home reconfigure /gnu/store/k90xv2x75nfc1wyxbw4171m6wxykqck6-configuration.scm
Cleaning up symlinks from previous home at /gnu/store/zmp2brsdr0nvrhpbk4kqqc6y8jx90kb1-home.

guix home: error: rmdir: No such file or directory
---[snip]---

-bjc

Madhavan Krishnan wrote on 10 Apr 2022 14:12

guix home: error: rmdir: No such file or directory

Recipients:(address . 54831@debbugs.gnu.org)

Message-ID:CAEqKSu1dJbMCR0THUB9n60sbNXchmYRaK+LNqej+ZTFZBNwkuw@mail.gmail.com

I am facing the same issue on ec6a585ee2fd91c857276479411eedd0756e0093; and

would like to add to this

The *build* command for the said config works ie)

guix home build config.scm

Whereas the reconfigure fails with

guix home: error: rmdir: No such file or directory

--Madhavan

Attachment: file

Christopher Rodriguez wrote on 10 Apr 2022 17:47

Unhandled ENOENT exception

Recipients:(address . 54831@debbugs.gnu.org)

Message-ID:pkmp4ezgktgc83.fsf@crane.ant.amazon.com

Christopher Rodriguez

Table of Contents

?????????????????

I'd like to add my $0.02 as well.

Seems like the issue is during the deployment, as Madhavan

said. Specifically, the error message in that form only appears in

`gnu/home/services/symlink-manager.scm', in the function

`cleanup-symlinks'.

It seems that, right now, the issue is that `ENOTEMPTY' and `ENOTDIR'

are tested for and handled, but `ENOENT' is not. Ideally, this should be

handled and tell the user /which/ file or directory is missing, not halt

the entire process. And, since we are testing for a missing file (and

thus have no chance of overwriting a user's data), it would probably

make the most sense to just create the file that is missing in the next

step, without stopping at all.

I'll throw together a patch real quick to test with. I could be very off

base, but I think this should fix this issue.

Attachment: file

Christopher Rodriguez

Christopher Rodriguez wrote on 10 Apr 2022 17:47

Recipients:(address . 54831@debbugs.gnu.org)

Message-ID:pkmp4ewnfxgc6o.fsf@crane.ant.amazon.com

Christopher Rodriguez

Table of Contents

?????????????????

I'd like to add my $0.02 as well.

Seems like the issue is during the deployment, as Madhavan

said. Specifically, the error message in that form only appears in

`gnu/home/services/symlink-manager.scm', in the function

`cleanup-symlinks'.

It seems that, right now, the issue is that `ENOTEMPTY' and `ENOTDIR'

are tested for and handled, but `ENOENT' is not. Ideally, this should be

handled and tell the user /which/ file or directory is missing, not halt

the entire process. And, since we are testing for a missing file (and

thus have no chance of overwriting a user's data), it would probably

make the most sense to just create the file that is missing in the next

step, without stopping at all.

I'll throw together a patch real quick to test with. I could be very off

base, but I think this should fix this issue.

Attachment: file

Christopher Rodriguez

Ludovic Courtès wrote on 11 Apr 2022 22:46

Re: bug#54831: guix home reconfigure fails with “rmdir: No such file or directory”

Recipients:(address . 54831-done@debbugs.gnu.org)

Message-ID:87bkx7fiv3.fsf@gnu.org

Hi all,

Brian Cully <bjc@spork.org> skribis:

Toggle quote (21 lines)> For the last few days, attempting to issue a home reconfigure fails:
>
> ---[snip]---
> $ guix home reconfigure ./guix-home/config-new.scm
> substitute: updating substitutes from 'https://ci.guix.gnu.org'... 100.0%
> substitute: updating substitutes from 'https://bordeaux.guix.gnu.org'... 100.0%
> The following derivations will be built:
>   /gnu/store/rbnri9gpvh98qagyk7ws4y5xdvz4skg7-home.drv
>   /gnu/store/hg5whdfsq2ldibfsikhbwppr9pms5vc8-provenance.drv
>   /gnu/store/rsil5s5fs14y2jvysbiv7vi2f0i3gnw2-activate.drv
>   /gnu/store/j85krrfbnc7x6s5wdn0wnp8ikah9gl46-update-symlinks.drv
>
> building /gnu/store/hg5whdfsq2ldibfsikhbwppr9pms5vc8-provenance.drv...
> building /gnu/store/j85krrfbnc7x6s5wdn0wnp8ikah9gl46-update-symlinks.drv...
> building /gnu/store/rsil5s5fs14y2jvysbiv7vi2f0i3gnw2-activate.drv...
> building /gnu/store/rbnri9gpvh98qagyk7ws4y5xdvz4skg7-home.drv...
> Cleaning up symlinks from previous home at /gnu/store/zmp2brsdr0nvrhpbk4kqqc6y8jx90kb1-home.
>
> guix home: error: rmdir: No such file or directory
> ---[snip]---

Christopher Rodriguez <yewscion@gmail.com> skribis:

Toggle quote (16 lines)> Seems like the issue is during the deployment, as Madhavan
> said. Specifically, the error message in that form only appears in
> `gnu/home/services/symlink-manager.scm', in the function
> `cleanup-symlinks'.
>
> It seems that, right now, the issue is that `ENOTEMPTY' and `ENOTDIR'
> are tested for and handled, but `ENOENT' is not. Ideally, this should be
> handled and tell the user /which/ file or directory is missing, not halt
> the entire process. And, since we are testing for a missing file (and
> thus have no chance of overwriting a user's data), it would probably
> make the most sense to just create the file that is missing in the next
> step, without stopping at all.
>
> I'll throw together a patch real quick to test with. I could be very off
> base, but I think this should fix this issue.

You were right.

This is fixed by commit 435e1cef0025fbe6cbb71b472218e8d132d1681c, pushed

yesterday. The patch had been submitted as part of

https://issues.guix.gnu.org/52808 but had not been applied. Apologies

for the breakage.

Thanks,

Ludo’.

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 54831@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date