[PATCH] gnu: murmur-shepherd-service: Fix binary name

DoneSubmitted by fesoj000.
Details
3 participants
  • fesoj000
  • Liliana Marie Prikler
  • Ludovic Courtès
Owner
unassigned
Severity
normal
F
F
fesoj000 wrote on 21 Mar 22:42 +0100
(address . guix-patches@gnu.org)
12a1c44d-a9b8-d15e-9574-5e899260f66b@gmail.com
* gnu/services/telephony.scm: murmur-shepherd-service (start): fixed
binary path of mumble server, which is now called mumble-server instead
of murmurd since version 1.4.x
---
gnu/services/telephony.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/services/telephony.scm b/gnu/services/telephony.scm
index e678bae87c..d09877aedf 100644
--- a/gnu/services/telephony.scm
+++ b/gnu/services/telephony.scm
@@ -961,7 +961,7 @@ (define (murmur-shepherd-service config)
           (requirement '(networking))
           (start #~(make-forkexec-constructor
                     '(#$(file-append (murmur-configuration-package config)
-                                    "/bin/murmurd")
+                                    "/bin/mumble-server")
                       "-ini"
                       #$(or (murmur-configuration-file config)
                             (default-murmur-config config)))
-- 
2.34.0
L
L
Liliana Marie Prikler wrote on 23 Mar 21:01 +0100
ac56f3484b7d919182acbfd1dac4bb55cc7e7ec3.camel@gmail.com
Am Montag, dem 21.03.2022 um 22:42 +0100 schrieb fesoj000:
Toggle quote (3 lines)
> * gnu/services/telephony.scm: murmur-shepherd-service (start): fixed
> binary path of mumble server, which is now called mumble-server
> instead of murmurd since version 1.4.x
Nice catch, but perhaps we should rename the entire service and place a
deprecation notice at the appropriate location.
L
L
Ludovic Courtès wrote on 24 Mar 12:47 +0100
Re: bug#54513: [PATCH] gnu: murmur-shepherd-service: Fix binary name
(name . fesoj000)(address . fesoj000@gmail.com)(address . 54513-done@debbugs.gnu.org)
8735j7d12y.fsf@gnu.org
Hi,

fesoj000 <fesoj000@gmail.com> skribis:

Toggle quote (4 lines)
> * gnu/services/telephony.scm: murmur-shepherd-service (start): fixed
> binary path of mumble server, which is now called mumble-server instead
> of murmurd since version 1.4.x

[...]

Toggle quote (5 lines)
> (start #~(make-forkexec-constructor
> '(#$(file-append (murmur-configuration-package config)
> - "/bin/murmurd")
> + "/bin/mumble-server")

There was a second instance of this that I fixed; I adjusted the commit
log and commit that.

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

Toggle quote (3 lines)
> Nice catch, but perhaps we should rename the entire service and place a
> deprecation notice at the appropriate location.

Yes, that would be a welcome change.

Thanks,
Ludo’.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 54513@debbugs.gnu.org