[PATCH] gnu: sbcl-printv: Update to e717a7f.

DoneSubmitted by jgart.
Details
3 participants
  • Guillaume Le Vaillant
  • jgart
  • Maxime Devos
Owner
unassigned
Severity
normal
J
(address . guix-patches@gnu.org)(name . jgart)(address . jgart@dismail.de)
20220319065509.13137-1-jgart@dismail.de
* gnu/packages/lisp-xyz.scm (sbcl-printv): Update to e717a7f.
---
gnu/packages/lisp-xyz.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Toggle diff (26 lines)
diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 0c99518e82..7c952ddcab 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -5039,8 +5039,8 @@ (define-public ecl-log4cl
   (sbcl-package->ecl-package sbcl-log4cl))
 
 (define-public sbcl-printv
-  (let ((commit "646d31978dbbb460fffb160fd65bb2be9a5a434e")
-        (revision "1"))
+  (let ((commit "e717a7fe076dae861a96117b2f9af29db8d2294d")
+        (revision "2"))
     (package
       (name "sbcl-printv")
       (version (git-version "0.1.0" revision commit))
@@ -5052,7 +5052,7 @@ (define-public sbcl-printv
                (commit commit)))
          (file-name (git-file-name "printv" version))
          (sha256
-          (base32 "08jvy82abm7qi3wrxh6gvmwg9gy0zzhg4cfqajdwrggbah8mj5a6"))))
+          (base32 "07agyzkwp3w2r4d2anrmr8h00yngpr5dq9mjd3m4kzhn1jcmilfb"))))
       (build-system asdf-build-system/sbcl)
       (home-page "https://github.com/danlentz/printv")
       (synopsis "Common Lisp tracing and debug-logging macro")
-- 
2.34.0
J
[PATCH v2] gnu: sbcl-printv: Update to e717a7f.
(address . 54460@debbugs.gnu.org)(name . jgart)(address . jgart@dismail.de)
20220319074735.27780-1-jgart@dismail.de
* gnu/packages/lisp-xyz.scm (sbcl-printv): Update to e717a7f.
[inputs]: Add missing figlet input.
[arguments]: Patch figlet executable.

Hi,

Here is v2.

I discovered that sbcl-printv calls figlet so I patched figlet.

all best,

jgart

---
gnu/packages/lisp-xyz.scm | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)

Toggle diff (44 lines)
diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 0c99518e82..21958528bc 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -69,6 +69,7 @@ (define-module (gnu packages lisp-xyz)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages enchant)
+  #:use-module (gnu packages figlet)
   #:use-module (gnu packages file)
   #:use-module (gnu packages fonts)
   #:use-module (gnu packages fontutils)
@@ -5039,8 +5040,8 @@ (define-public ecl-log4cl
   (sbcl-package->ecl-package sbcl-log4cl))
 
 (define-public sbcl-printv
-  (let ((commit "646d31978dbbb460fffb160fd65bb2be9a5a434e")
-        (revision "1"))
+  (let ((commit "e717a7fe076dae861a96117b2f9af29db8d2294d")
+        (revision "2"))
     (package
       (name "sbcl-printv")
       (version (git-version "0.1.0" revision commit))
@@ -5052,8 +5053,17 @@ (define-public sbcl-printv
                (commit commit)))
          (file-name (git-file-name "printv" version))
          (sha256
-          (base32 "08jvy82abm7qi3wrxh6gvmwg9gy0zzhg4cfqajdwrggbah8mj5a6"))))
+          (base32 "07agyzkwp3w2r4d2anrmr8h00yngpr5dq9mjd3m4kzhn1jcmilfb"))))
       (build-system asdf-build-system/sbcl)
+      (inputs
+        (list figlet))
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'patch-figlet-executable
+             (lambda* (#:key inputs #:allow-other-keys)
+               (substitute* "printv.lisp"
+                 (("\"figlet") (string-append "\"" (which "figlet")))))))))
       (home-page "https://github.com/danlentz/printv")
       (synopsis "Common Lisp tracing and debug-logging macro")
       (description
-- 
2.34.0
M
M
Maxime Devos wrote on 19 Mar 10:58 +0100
e6708a5252add19d40aa078a08a9ba237baebdd2.camel@telenet.be
jgart via Guix-patches via schreef op za 19-03-2022 om 03:47 [-0400]:
Toggle quote (6 lines)
> +         (modify-phases %standard-phases
> +           (add-after 'unpack 'patch-figlet-executable
> +             (lambda* (#:key inputs #:allow-other-keys)
> +               (substitute* "printv.lisp"
> +                 (("\"figlet") (string-append "\"" (which "figlet")))))))))

'which' looks in 'native-inputs', not 'inputs', so when cross-
compilation this is probably broken. I suggest
(search-input-file inputs "bin/figlet") instead.

Greetings,
Maxime.
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjWpNhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7sD1AQCOowbV5PuZnQV7dJ+NWutXSLfU
WlY4LQ/hpRaRK+hKtgEA6Zm7ku3y7jNPYI/G3uQjgBiw8RumC+slukZFiTWA7A0=
=P3KI
-----END PGP SIGNATURE-----


G
G
Guillaume Le Vaillant wrote on 21 Mar 10:00 +0100
(name . jgart)(address . jgart@dismail.de)
871qyv8yqp.fsf@kitej
Patch pushed as a47b4da09945610080ed9f436e8717a3a4c02664 with Maxime's
suggestion.
Thanks.
-----BEGIN PGP SIGNATURE-----

iIUEAREKAC0WIQTLxZxm7Ce5cXlAaz5r6CCK3yH+PwUCYjg/Hg8cZ2x2QHBvc3Rl
by5uZXQACgkQa+ggit8h/j/0LQD/Y7OvEXbzCDxeEaxWbvNwX4UpMretmXznOnHc
2A1KgUUBAIVa7dEQnD0JAbwnod5r61dyTf3aLdw9Vap2MK2r5Y7+
=gIUl
-----END PGP SIGNATURE-----

Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 54460@debbugs.gnu.org