Mutter test-suite is flaky

  • Done
  • quality assurance status badge
Details
2 participants
  • Liliana Marie Prikler
  • Maxim Cournoyer
Owner
unassigned
Submitted by
Liliana Marie Prikler
Severity
normal
L
L
Liliana Marie Prikler wrote on 26 Jan 2022 21:27
(address . bug-guix@gnu.org)
ee6a52f7564ba159fbd99d9f4d3d0f052b5971e2.camel@gmail.com
Hi Guix,

ever since the merge of core-updates-frozen, I've been unable to build
mutter locally, while fetching it from CI is usually fine. Attached is
a build log -- note, that the traceback is generated by me killing the
process with a SIGSEGV, it would otherwise go on for several days.

Cheers
Attachment: nx8rx7gy5xbra7060arkwmwks5lpw3-mutter-41.0.drv.bz2
L
L
Liliana Marie Prikler wrote on 27 Jan 2022 21:47
[PATCH] gnu: mutter: Disable timeline tests.
(address . 53559@debbugs.gnu.org)
2d54086914eff8218918dad8a43772339177729a.camel@gmail.com
* gnu/packages/gnome.scm (mutter)[disable-problematic-tests]: Also disable
timeline tests.
---
gnu/packages/gnome.scm | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

Toggle diff (19 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index e3fac534c4..b341fb4c97 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -7477,7 +7477,11 @@ (define-public mutter
;; expression paragraph. For an explanation, see: info '(sed)
;; Multiline techniques'.
(invoke "sed" "/./{H;$!d} ; x ; s/^.*native-headless.*$//"
- "-i" "src/tests/meson.build")))
+ "-i" "src/tests/meson.build")
+ ;; Timeline tests may unexpectedly fail on missed frames, so
+ ;; let's disable them as well.
+ (substitute* "src/tests/clutter/conform/meson.build"
+ (("'timeline.*',") ""))))
(replace 'check
(lambda* (#:key tests? test-options parallel-tests?
#:allow-other-keys)
--
2.34.0
M
M
Maxim Cournoyer wrote on 31 Jan 2022 06:27
Re: bug#53559: Mutter test-suite is flaky
(name . Liliana Marie Prikler)(address . liliana.prikler@gmail.com)(address . 53559@debbugs.gnu.org)
8735l4o4ov.fsf_-_@gmail.com
Hello Liliana,

Liliana Marie Prikler <liliana.prikler@gmail.com> writes:

Toggle quote (24 lines)
> * gnu/packages/gnome.scm (mutter)[disable-problematic-tests]: Also disable
> timeline tests.
> ---
> gnu/packages/gnome.scm | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index e3fac534c4..b341fb4c97 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -7477,7 +7477,11 @@ (define-public mutter
> ;; expression paragraph. For an explanation, see: info '(sed)
> ;; Multiline techniques'.
> (invoke "sed" "/./{H;$!d} ; x ; s/^.*native-headless.*$//"
> - "-i" "src/tests/meson.build")))
> + "-i" "src/tests/meson.build")
> + ;; Timeline tests may unexpectedly fail on missed frames, so
> + ;; let's disable them as well.
> + (substitute* "src/tests/clutter/conform/meson.build"
> + (("'timeline.*',") ""))))
> (replace 'check
> (lambda* (#:key tests? test-options parallel-tests?
> #:allow-other-keys)

You'd want to let upstream know about these flaky tests, and add the
reference to the upstream issue in a comment so we can track progress.

Otherwise, LGTM.

Thanks,

Maxim
L
L
Liliana Marie Prikler wrote on 11 Feb 2022 21:25
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)(address . 53559-done@debbugs.gnu.org)
66e99c2551e1da5e6286deb056e95745181af25d.camel@gmail.com
Am Montag, dem 31.01.2022 um 00:27 -0500 schrieb Maxim Cournoyer:
Toggle quote (3 lines)
> You'd want to let upstream know about these flaky tests, and add the
> reference to the upstream issue in a comment so we can track
> progress.
Pushed with said reference.

Cheers
Closed
?