[PATCH] gnu: mda-lv2: Remove unnecessary search-path-specification.

  • Open
  • quality assurance status badge
Details
2 participants
  • Maxime Devos
  • Thorsten Wilms
Owner
unassigned
Submitted by
Thorsten Wilms
Severity
normal
T
T
Thorsten Wilms wrote on 25 Oct 2021 21:15
(address . guix-patches@gnu.org)(name . Thorsten Wilms)(address . t_w_@freenet.de)
20211025191514.9850-1-t_w_@freenet.de
---
gnu/packages/audio.scm | 4 ----
1 file changed, 4 deletions(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index faf106fc68..f43964a804 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -5556,10 +5556,6 @@ (define-public mda-lv2
`(("lv2" ,lv2)))
(native-inputs
`(("pkg-config" ,pkg-config)))
- (native-search-paths
- (list (search-path-specification
- (variable "LV2_PATH")
- (files '("lib/lv2")))))
(home-page "https://drobilla.net/software/mda-lv2")
(synopsis "Audio plug-in pack for LV2")
(description
--
2.33.1
M
M
Maxime Devos wrote on 23 Apr 2022 14:45
Re: bug#55069: Add some means to find LV2 plugins
12b95f88fd08ad5d5ca4ab8ce07eac9a8015501e.camel@telenet.be
Toggle quote (2 lines)
> [PATCH] gnu: mda-lv2: Remove unnecessary search-path-specification.

Isn't it currently necessary? Because lv2 doesn't have a LV2_PATH
search path yet.

Nathan Dehnel schreef op vr 22-04-2022 om 17:13 [-0500]:
Toggle quote (4 lines)
> It seems DAWs and plugins can't find each other because there is no
> way to find the plugins outside of the store because there is no
> directory where the plugins are aggregated, and $LV2_PATH isn't set.

I think this would be resolved by adding the search path to the 'lv2'
package (and removing it from lv2-mda-piano, mda-lv2 and calf).

Toggle quote (5 lines)
> [PATCH] gnu: Add invada-studio-plugins-lv2.
> [PATCH] gnu: Add distrho-ports-lv2.
> [PATCH] gnu: Add omins-lv2.
> [PATCH] Add drumgizmo

The convention is to add the search paths to the users of the plugins,
not the plugins theirselves. Cf. GUILE_LOAD_PATH, LIBRARY_PATH,
MINETEST_MOD_PATH, EMACSLOADPATH, INFOPATH ... See

The benefit is that this avoids forgetting LV2_PATH for some plugins,
as it only needs to be added to relatively few places (lv2 itself,
maybe guitarix, maybe ir, arour ...).

Greetings,
Maxime
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmP1AhccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7h+eAP49mWmaho4w9vOh+7fFYDXFvQD1
KG3WRZSoOgbk/eEjFQD/Z2mBpR/uc2eFo+5y/S+/+wh/TVNHXtWJffrmesex7AQ=
=rtun
-----END PGP SIGNATURE-----


?