[PATCH] gnu: Add valeronoi.

  • Done
  • quality assurance status badge
Details
3 participants
  • Nicolas Goaziou
  • phodina
  • Xinglu Chen
Owner
unassigned
Submitted by
phodina
Severity
normal
P
P
phodina wrote on 18 Sep 2021 15:25
(name . guix-patches@gnu.org)(address . guix-patches@gnu.org)
OG0urOiNmZ7man9nMWB8mp6IscIoLD0iYkw9U8hue5zaCcMEjnzgOx8eQg-Tsc9vmmJzV7mUiJjgBxPxgS_y6Xnc2-Co9Sm2KXzHXMHtfdo=@protonmail.com
* gnu/packages/engineering.scm (valeronoi): New variable.

Toggle diff (53 lines)
diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 46622f3a1f..37f927a7a3 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -24,6 +24,7 @@
;;; Copyright © 2021 qblade <qblade@protonmail.com>
;;; Copyright © 2021 Gerd Heber <gerd.heber@gmail.com>
;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
+;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -127,6 +128,7 @@
#:use-module (gnu packages xml)
#:use-module (gnu packages xiph)
#:use-module (gnu packages openkinect)
+ #:use-module (gnu packages xdisorg)
#:use-module (gnu packages xorg))

(define-public librecad
@@ -1168,6 +1170,32 @@ educational use. As such, there is an emphasis on capabilities that improve
the 'showing the effect of'-style of operation.")
(license license:gpl2+)))

+(define-public valeronoi
+(package
+ (name "valeronoi")
+ (version "v0.1.3")
+ (source (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/ccoors/Valeronoi")
+ (commit version)))
+ (sha256
+ (base32
+ "1a866h37xmhrnl7hnkhdzjjm8dpjwhq0va2g6hdcp7y949d82ipp"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (replace 'check
+ (lambda* (#:key outputs #:allow-other-keys)
+ (invoke "./valeronoi-tests"))))))
+ (inputs `(("qtbase" ,qtbase-5) ("qtsvg" ,qtsvg) ("openssl" ,openssl) ("libxkbcommon" ,libxkbcommon) ("cgal" ,cgal) ("gmp" ,gmp) ("mpfr" ,mpfr) ("boost" ,boost)))
+ (synopsis "WiFi mapping companion app for Valetudo")
+ (description "Valeronoi (Valetudo + Voronoi) is a companion for Valetudo for generating WiFi signal strength maps. It visualizes them using a Voronoi diagram.")
+ (home-page "https://github.com/ccoors/Valeronoi")
+ (license license:gpl3)))
+
(define-public volk
(package
(name "volk")
--
2.32.0
P
P
phodina wrote on 18 Sep 2021 15:37
[PATCH v2] gnu: Add valeronoi.
(name . 50661@debbugs.gnu.org)(address . 50661@debbugs.gnu.org)
NxytQPoXMo3dJwVnfE3VBcmyZDccUmTF19s4_y6nLNQIq_NB4lCIi43s1dlC_dO_oOotYMGdAUgBq5kIsESEnyLD7INugwg7wg0heE9iv38=@protonmail.com
Fixed forgotten formatting issues.

Toggle snippet (69 lines)
* gnu/packages/engineering.scm (valeronoi): New variable.

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 46622f3a1f..f61fa04a43 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -24,6 +24,7 @@
;;; Copyright © 2021 qblade <qblade@protonmail.com>
;;; Copyright © 2021 Gerd Heber <gerd.heber@gmail.com>
;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
+;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -127,6 +128,7 @@
#:use-module (gnu packages xml)
#:use-module (gnu packages xiph)
#:use-module (gnu packages openkinect)
+ #:use-module (gnu packages xdisorg)
#:use-module (gnu packages xorg))

(define-public librecad
@@ -1168,6 +1170,42 @@ educational use. As such, there is an emphasis on capabilities that improve
the 'showing the effect of'-style of operation.")
(license license:gpl2+)))

+(define-public valeronoi
+(package
+ (name "valeronoi")
+ (version "v0.1.3")
+ (source (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/ccoors/Valeronoi")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1a866h37xmhrnl7hnkhdzjjm8dpjwhq0va2g6hdcp7y949d82ipp"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (replace 'check
+ (lambda* (#:key outputs #:allow-other-keys)
+ (invoke "./valeronoi-tests"))))))
+ (inputs `(("qtbase" ,qtbase-5)
+ ("qtsvg" ,qtsvg)
+ ("openssl" ,openssl)
+ ("libxkbcommon" ,libxkbcommon)
+ ("cgal" ,cgal)
+ ("gmp" ,gmp)
+ ("mpfr" ,mpfr)
+ ("boost" ,boost)))
+ (synopsis "WiFi mapping companion app for Valetudo")
+ (description "Valeronoi (Valetudo + Voronoi) is a companion for Valetudo
+for generating WiFi signal strength maps. It visualizes them using a Voronoi
+diagram.")
+ (home-page "https://github.com/ccoors/Valeronoi")
+ (license license:gpl3)))
+
(define-public volk
(package
(name "volk")
--
2.32.0
X
X
Xinglu Chen wrote on 22 Sep 2021 18:27
87ilyslgng.fsf@yoctocell.xyz
On Sat, Sep 18 2021, phodina via Guix-patches via wrote:

Toggle quote (35 lines)
> Fixed forgotten formatting issues.
>
> --8<---------------cut here---------------start------------->8--
>
> * gnu/packages/engineering.scm (valeronoi): New variable.
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index 46622f3a1f..f61fa04a43 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -24,6 +24,7 @@
> ;;; Copyright © 2021 qblade <qblade@protonmail.com>
> ;;; Copyright © 2021 Gerd Heber <gerd.heber@gmail.com>
> ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
> +;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -127,6 +128,7 @@
> #:use-module (gnu packages xml)
> #:use-module (gnu packages xiph)
> #:use-module (gnu packages openkinect)
> + #:use-module (gnu packages xdisorg)
> #:use-module (gnu packages xorg))
>
> (define-public librecad
> @@ -1168,6 +1170,42 @@ educational use. As such, there is an emphasis on capabilities that improve
> the 'showing the effect of'-style of operation.")
> (license license:gpl2+)))
>
> +(define-public valeronoi
> +(package
> + (name "valeronoi")
> + (version "v0.1.3")

The version string should not contain the “v”, and the latest version
seems to be 0.1.4.

Toggle quote (18 lines)
> + (source (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/ccoors/Valeronoi")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1a866h37xmhrnl7hnkhdzjjm8dpjwhq0va2g6hdcp7y949d82ipp"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (replace 'check
> + (lambda* (#:key outputs #:allow-other-keys)
> + (invoke "./valeronoi-tests"))))))

The ‘outputs’ argument isn’t used, and the ‘check’ phase doesn’t respect
the ‘--without-tests’ package transformation. The following snippet
would fix this.

(lambda* (#:key tests? #:allow-other-keys)
(when tests?
(invoke "./valeronoi-tests")))

Toggle quote (15 lines)
> + (inputs `(("qtbase" ,qtbase-5)
> + ("qtsvg" ,qtsvg)
> + ("openssl" ,openssl)
> + ("libxkbcommon" ,libxkbcommon)
> + ("cgal" ,cgal)
> + ("gmp" ,gmp)
> + ("mpfr" ,mpfr)
> + ("boost" ,boost)))
> + (synopsis "WiFi mapping companion app for Valetudo")
> + (description "Valeronoi (Valetudo + Voronoi) is a companion for Valetudo
> +for generating WiFi signal strength maps. It visualizes them using a Voronoi
> +diagram.")
> + (home-page "https://github.com/ccoors/Valeronoi")
> + (license license:gpl3)))

The ‘COPYING’ file says gpl3+.
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFLWXMVHHB1YmxpY0B5
b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5ywMQAKEIrsOoEvrVwgX11gzDwSE7UWpd
v60arhC9uiCgH6nG5Ui9z3FL7wsTpMlVH1EjXpkzEct7KvNreaQ+wujsK06mvU7h
WcOQBKZuYgC8i57e+m3b/W0qGSN7ValVyBVq20z2Vv4l4nIYOL5qkOlmWpxd5T8Y
9Xk/oDj+xK10mputUez/zxa0XFOuFwRXXWROb2+e/s04wbwNxv0Wb8hLfjHWz2dh
it7wOWzkRMCGWnGBEsnfjvo9J4yvcV/0gMsfu4ImJv45aEgZqTKKuBDZsMxoro+k
XTjt3OjP4VYjlkiyakNb2i3vHv0IGCuIKuDbvqJ9ijVzSMz1TJf2nRjO+C80ndxL
nl9njzHUCv1PG9dju7nnPJsaGxHC1y20RTFX2xrgjdaR+eCynXu+kWDuslHkyYk8
HzvqLw+iSFGnNl1lc5vywrEUmbKLtvKPAxa+Cj5P8c9alEkZKAo1f4T6KBh2w0N3
GMoIwXaG4+xizJ0R7BwUrkybpCHavmRrEzJvRoILcGHfLcD8x0LUwzqkRwAncYdB
/6ofZodVgWydnOMUPXRQ4qV6NN+bujkwh1EechKh4E6Z2wBe35kg6l/+YbFcI8xa
YNCLTH9QkgEShWtNSL6Ao70qO6fleT6LkVSn9u0VHlOnZPRF5D0ykVImTIWSSQgc
z+eXF8tcHg5entv/
=Q040
-----END PGP SIGNATURE-----

P
P
phodina wrote on 28 Sep 2021 00:52
[PATCH v3] gnu: Add valeronoi.
(name . Xinglu Chen)(address . public@yoctocell.xyz)(name . 50661@debbugs.gnu.org)(address . 50661@debbugs.gnu.org)
FFUI6LHF_Ifa_LxK0vmjOqIKdXlA5tJfWfiXvr2iQC0s7K7dWvH2Wf_iVQMKHkLllpYkkivs_sBbVvETKAjgVaQ2sRn2R-y2erUtWwreywQ=@protonmail.com
* gnu/packages/engineering.scm (valeronoi): New variable.

Toggle diff (64 lines)
diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 46622f3a1f..9dacc6c948 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -24,6 +24,7 @@
;;; Copyright © 2021 qblade <qblade@protonmail.com>
;;; Copyright © 2021 Gerd Heber <gerd.heber@gmail.com>
;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
+;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -127,6 +128,7 @@
#:use-module (gnu packages xml)
#:use-module (gnu packages xiph)
#:use-module (gnu packages openkinect)
+ #:use-module (gnu packages xdisorg)
#:use-module (gnu packages xorg))

(define-public librecad
@@ -1168,6 +1170,43 @@ educational use. As such, there is an emphasis on capabilities that improve
the 'showing the effect of'-style of operation.")
(license license:gpl2+)))

+(define-public valeronoi
+(package
+ (name "valeronoi")
+ (version "0.1.4")
+ (source (origin
+ (method git-fetch)
+ (uri
+ (git-reference
+ (url "https://github.com/ccoors/Valeronoi")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "1zp653bjqsyixa5j1pp9k12iqsl8dz72yyi38asxmcym1wngsjcd"))))
+ (build-system cmake-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (when tests?
+ (invoke "./valeronoi-tests")))))))
+ (inputs `(("qtbase" ,qtbase-5)
+ ("qtsvg" ,qtsvg)
+ ("openssl" ,openssl)
+ ("libxkbcommon" ,libxkbcommon)
+ ("cgal" ,cgal)
+ ("gmp" ,gmp)
+ ("mpfr" ,mpfr)
+ ("boost" ,boost)))
+ (synopsis "WiFi mapping companion app for Valetudo")
+ (description "Valeronoi (Valetudo + Voronoi) is a companion for Valetudo
+for generating WiFi signal strength maps. It visualizes them using a Voronoi
+diagram.")
+ (home-page "https://github.com/ccoors/Valeronoi")
+ (license license:gpl3+)))
+
(define-public volk
(package
(name "volk")
--
2.32.0
P
P
phodina wrote on 3 Dec 2021 16:36
(name . Xinglu Chen)(address . public@yoctocell.xyz)(name . 50661@debbugs.gnu.org)(address . 50661@debbugs.gnu.org)
VPVDJI60_gz4MqddK2AmdU5lD5pzKTDUFFSvE3abp796Ui8suoEA1Sk9-2YtGWEU7au5R-FzwpVBJNqTz3ONUiry-E6YB9l_8ft7GVDFUE8=@protonmail.com
ping
N
N
Nicolas Goaziou wrote on 3 Dec 2021 21:39
Re: [bug#50661] [PATCH v3] gnu: Add valeronoi.
(name . phodina via Guix-patches via)(address . guix-patches@gnu.org)
87lf11qv6u.fsf@nicolasgoaziou.fr
Hello,

phodina via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (2 lines)
> * gnu/packages/engineering.scm (valeronoi): New variable.

Applied, with the changes below:

Toggle quote (9 lines)
> + (inputs `(("qtbase" ,qtbase-5)
> + ("qtsvg" ,qtsvg)
> + ("openssl" ,openssl)
> + ("libxkbcommon" ,libxkbcommon)
> + ("cgal" ,cgal)
> + ("gmp" ,gmp)
> + ("mpfr" ,mpfr)
> + ("boost" ,boost)))

I sorted inputs alphabetically.

Toggle quote (2 lines)
> + (synopsis "WiFi mapping companion app for Valetudo")

I replace "app" with "application"

Note: there is a new release. You may want to update it.

Thank you.

Regards,
--
Nicolas Goaziou
?