[PATCH] gnu: Add vpn-slice.

  • Done
  • quality assurance status badge
Details
5 participants
  • Allan Adair
  • Nicolas Goaziou
  • phodina
  • Xinglu Chen
  • Vagrant Cascadian
Owner
unassigned
Submitted by
phodina
Severity
normal
P
P
phodina wrote on 18 Sep 2021 12:23
(name . guix-patches@gnu.org)(address . guix-patches@gnu.org)
ORACe3vNVei78749NpMdTd9U8KD6zmRH5NjY1E44BWRMPXaJfe3DQjujYWbCWvIbAV3hTQtTby3MuSA1qapkoaPaxTo2OP-G0HSSr8zyD_s=@protonmail.com
* gnu/packages/vpn.scm (vpn-slice): New variable.

Toggle diff (44 lines)
diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
index 330a3271b4..4d49597564 100644
--- a/gnu/packages/vpn.scm
+++ b/gnu/packages/vpn.scm
@@ -18,6 +18,7 @@
;;; Copyright © 2021 Domagoj Stolfa <ds815@gmx.com>
;;; Copyright © 2021 Raghav Gururajan <rg@raghavgururajan.name>
;;; Copyright © 2021 jgart <jgart@dismail.de>
+;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -432,6 +433,31 @@ file for more details.")
;; src/libstrongswan/plugins/des/des_crypter.c
license:bsd-4))))

+(define-public vpn-slice
+ (package
+ (name "vpn-slice")
+ (version "0.15")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "vpn-slice" version))
+ (sha256
+ (base32
+ "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))
+ (build-system python-build-system)
+ (native-inputs `(("python-pytest" ,python-pytest)))
+ (propagated-inputs
+ `(("python-dnspython" ,python-dnspython)
+ ("python-setproctitle" ,python-setproctitle)))
+ (home-page
+ "https://github.com/dlenski/vpn-slice")
+ (synopsis
+ "Easy and secure split-tunnel VPN setup")
+ (description
+ "Minimize your contact with an intrusive VPN - split your traffic
+between the VPN tunnel and your normal network interfaces")
+ (license license:gpl3)))
+
(define-public vpnc
(package
(name "vpnc")
--
2.32.0
X
X
Xinglu Chen wrote on 20 Sep 2021 14:37
87sfxzfmnf.fsf@yoctocell.xyz
On Sat, Sep 18 2021, phodina via Guix-patches via wrote:

Toggle quote (37 lines)
> * gnu/packages/vpn.scm (vpn-slice): New variable.
>
> diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
> index 330a3271b4..4d49597564 100644
> --- a/gnu/packages/vpn.scm
> +++ b/gnu/packages/vpn.scm
> @@ -18,6 +18,7 @@
> ;;; Copyright © 2021 Domagoj Stolfa <ds815@gmx.com>
> ;;; Copyright © 2021 Raghav Gururajan <rg@raghavgururajan.name>
> ;;; Copyright © 2021 jgart <jgart@dismail.de>
> +;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -432,6 +433,31 @@ file for more details.")
> ;; src/libstrongswan/plugins/des/des_crypter.c
> license:bsd-4))))
>
> +(define-public vpn-slice
> + (package
> + (name "vpn-slice")
> + (version "0.15")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "vpn-slice" version))
> + (sha256
> + (base32
> + "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))
> + (build-system python-build-system)
> + (native-inputs `(("python-pytest" ,python-pytest)))
> + (propagated-inputs
> + `(("python-dnspython" ,python-dnspython)
> + ("python-setproctitle" ,python-setproctitle)))
> + (home-page
> + "https://github.com/dlenski/vpn-slice")

Please avoid unnecessary newlines.

Toggle quote (3 lines)
> + (synopsis
> + "Easy and secure split-tunnel VPN setup")

Likewise.

Toggle quote (4 lines)
> + (description
> + "Minimize your contact with an intrusive VPN - split your traffic
> +between the VPN tunnel and your normal network interfaces")

The sentence lacks a subject and a period, and the single “-” should be
replaced by “---”, which is the proper Texinfo syntax.

I noticed that the README says

It automatically looks up named hosts, using the VPN's DNS servers,
and adds entries for them to your /etc/hosts

I don’t know about Guix System, but on NixOS /etc/hosts is read-only, so
this wouldn’t work.

Toggle quote (2 lines)
> + (license license:gpl3)))

‘LICENSE.txt’ says gpl3+.
-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFIgJQVHHB1YmxpY0B5
b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x55csP+QF142JTPz+xrEtFL0T/SKBtkQFV
ouUKgU31JVsFIaia1OtXrnLuGtcA+lD3hF4SH9N5BaLaVIuesKm1jTzj+xedaI31
2hPw6R6uo0VcIJQ2wigEGtcA09MQrX25FSP/gu0ce/y5pM70/YKl7jPoADA4x9R1
POj1KsQ6MC2omC5RyBLxz7URpIA7EngbQziVLoacazwzH7dux6eb4ytbtO9zZJi6
UIo1uPVADcHHXU6J+zYPv1056WkbzkjMFv0TZP3NbICjZbkvyniY1Ln4K2RMKJWI
4OReEEZ2t/+tOteNxaFFUbm7OaJU+EEulu7RB/F4LZFLzL2W0yg6qn3YLdpJYroL
s/pOAf5KLfw1wA6Rz6NJpTLpDTiQjoWbzCwi6UoV1RafXTkrDxiFrynFz2PaoSUB
SJQwzQAQZRuaFqHGI+4YZbOy4D/MHzsnfxxWakBo3Xq/I9fd9Gb3dERA6hjn4jBv
qS1clYJ48A8aKlXhCEvJideOAhf93npD8dT3clm3Ln6X1o4HL1Ew6y2N/SFUYJJP
gyAWJxW41LJuO2TynvrK02cVmiKFztNYFvEdXNuLIKuDY52JfbHl2wTfmWcPoqX4
LnQqyAW2bOdpup1Z7KaUAjxEhDbR5Hn+muDLqQVbZLXrYPhnEpa0fgCmFMRx5zOV
73+43RcEoNT+93lO
=0F0+
-----END PGP SIGNATURE-----

P
P
phodina wrote on 28 Sep 2021 00:32
[PATCH v2] gnu: Add vpn-slice.
(name . Xinglu Chen)(address . public@yoctocell.xyz)(address . 50657@debbugs.gnu.org)
aYDmel23x5oNh6gRBLyPkVFB2bWi-Majf_BM80ce6eg4ilIZpNs4vpLe8vaEX933-z6fbN0KbGNDBGjCDP2OsowqBHSdXRNXBeJaPIiAyvk=@protonmail.com
Hi Xinglu,

I checked the /etc/hosts and seems that on Guix System there aren't symlink to the /gnu/store.

$ readlink -f /etc/hostname
/etc/hostname

Toggle snippet (48 lines)
* gnu/packages/vpn.scm (vpn-slice): New variable.

diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
index 330a3271b4..cf79bc07f8 100644
--- a/gnu/packages/vpn.scm
+++ b/gnu/packages/vpn.scm
@@ -18,6 +18,7 @@
;;; Copyright © 2021 Domagoj Stolfa <ds815@gmx.com>
;;; Copyright © 2021 Raghav Gururajan <rg@raghavgururajan.name>
;;; Copyright © 2021 jgart <jgart@dismail.de>
+;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -432,6 +433,29 @@ file for more details.")
;; src/libstrongswan/plugins/des/des_crypter.c
license:bsd-4))))

+(define-public vpn-slice
+ (package
+ (name "vpn-slice")
+ (version "0.15")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "vpn-slice" version))
+ (sha256
+ (base32
+ "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))
+ (build-system python-build-system)
+ (native-inputs `(("python-pytest" ,python-pytest)))
+ (propagated-inputs
+ `(("python-dnspython" ,python-dnspython)
+ ("python-setproctitle" ,python-setproctitle)))
+ (home-page "https://github.com/dlenski/vpn-slice")
+ (synopsis "Easy and secure split-tunnel VPN setup")
+ (description "This package allows you to minimize your contact with
+an intrusive VPN --- split your traffic between the VPN tunnel and your normal
+network interfaces")
+ (license license:gpl3)))
+
(define-public vpnc
(package
(name "vpnc")
--
2.32.0
A
A
Allan Adair wrote on 1 Nov 2021 15:04
[PATCH] gnu: Add vpn-slice.
(address . 50657@debbugs.gnu.org)
b415d76b1eb0b72ac75c5fbe46a44ea10c4416b4.camel@adair.no
Any progress on approving or denying this patch? Just a user wanting to
use this package ?
P
P
phodina wrote on 3 Dec 2021 16:35
Re: [PATCH v2] gnu: Add vpn-slice.
(name . Xinglu Chen)(address . public@yoctocell.xyz)(address . 50657@debbugs.gnu.org)
3S4c5zQbsNGxleyWX6NvSyf8TCvmhqaqgfcAvdxBLZViZ08vMjOGzbc9YsaVpgeLBqa9z-JSDlIEm0CUUNCNR2Y9kT8xLbX6M4aTQAmbWzo=@protonmail.com
ping
N
N
Nicolas Goaziou wrote on 5 Dec 2021 12:14
Re: [bug#50657] [PATCH v2] gnu: Add vpn-slice.
(name . phodina via Guix-patches via)(address . guix-patches@gnu.org)
87pmqbl2wh.fsf@nicolasgoaziou.fr
Hello,

phodina via Guix-patches via <guix-patches@gnu.org> writes:

Toggle quote (5 lines)
> I checked the /etc/hosts and seems that on Guix System there aren't symlink to the /gnu/store.
>
> $ readlink -f /etc/hostname
> /etc/hostname

But it is read-only, isn't it? If so, how can the program do its stuff,
since it is supposed to modify the file?

Toggle quote (4 lines)
> + (sha256
> + (base32
> + "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))

Nitpick: Hash string should be on the same line as base32

Toggle quote (4 lines)
> + (description "This package allows you to minimize your contact with
> +an intrusive VPN --- split your traffic between the VPN tunnel and your normal
> +network interfaces")

Nitpick: I think English does not add spaces between "---".

Toggle quote (2 lines)
> + (license license:gpl3)))

You forgot to change the license, as suggested by Xinglu Chen.

Regards,
--
Nicolas Goaziou
V
V
Vagrant Cascadian wrote on 1 Sep 2023 22:38
Re: [bug#50657] [PATCH] gnu: Add vpn-slice.
874jkdtyrd.fsf@wireframe
On 2021-09-18, phodina wrote:
Toggle quote (5 lines)
> +(define-public vpn-slice
> + (package
> + (name "vpn-slice")
> + (version "0.15")

vpn-slice 0.16.1 was added in commit
79415548f7acc3afd8a79fb8ca5d103ad065a2bf.

Marking as done.

live well,
vagrant
-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCZPJLxgAKCRDcUY/If5cW
qkLqAP0R2PDgu+tfxy6MgoC8pDjGgJREnv3w+H6lnu4r/JzrawEArQXgjAuNlwgx
y40Q070Bgdq4gYd8SGQB/KyIaH4JxA0=
=Dxl1
-----END PGP SIGNATURE-----

Closed
?