[PATCH] gnu: Add emacs-geiser-chez.

  • Done
  • quality assurance status badge
Details
2 participants
  • Maxim Cournoyer
  • Xinglu Chen
Owner
unassigned
Submitted by
Xinglu Chen
Severity
normal
X
X
Xinglu Chen wrote on 2 Aug 2021 11:23
(address . guix-patches@gnu.org)
9443b246c7d74a51435e7f0c5bbb9c6ac23af33c.1627896152.git.public@yoctocell.xyz
* gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
---
gnu/packages/emacs-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)

Toggle diff (65 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e3b94228e1..bbda1db614 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -138,6 +138,7 @@
#:use-module (gnu packages aspell)
#:use-module (gnu packages audio)
#:use-module (gnu packages bash)
+ #:use-module (gnu packages chez)
#:use-module (gnu packages cmake)
#:use-module (gnu packages code)
#:use-module (gnu packages cpp)
@@ -408,6 +409,48 @@ a generic Scheme interaction mode for the GNU Emacs editor.")
a generic Scheme interaction mode for the GNU Emacs editor.")
(license license:bsd-3)))
+(define-public emacs-geiser-chez
+ (package
+ (name "emacs-geiser-chez")
+ (version "0.16")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gitlab.com/emacs-geiser/chez")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0cc1z5z5cpvxa5f3n8kvms0wxlybzcg4l1bh3rwv1l1sb0lk1xzx"))))
+ (build-system emacs-build-system)
+ (arguments
+ '(#:include (cons "^src/" %default-include)
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'make-autoloads 'patch-autoloads
+ (lambda* (#:key outputs #:allow-other-keys)
+ (substitute* (string-append
+ (elpa-directory (assoc-ref outputs "out"))
+ "/geiser-chez-autoloads.el")
+ ;; Activating implementations fails when Geiser is not yet
+ ;; loaded, so let's defer that until it is.
+ (("\\(geiser-activate-implementation .*\\)" all)
+ (string-append
+ "(eval-after-load 'geiser-impl '" all ")"))
+ (("\\(geiser-implementation-extension .*\\)" all)
+ (string-append
+ "(eval-after-load 'geiser-impl '" all ")"))))))))
+ (inputs
+ `(("chez-scheme" ,chez-scheme)))
+ (propagated-inputs
+ `(("emacs-geiser" ,emacs-geiser)))
+ (home-page "https://nongnu.org/geiser/")
+ (synopsis "Support for Chez Scheme in Geiser")
+ (description
+ "This package adds support for using Chez Scheme in Emacs with Geiser.")
+ (license license:bsd-3)))
+
(define-public emacs-vc-hgcmd
(package
(name "emacs-vc-hgcmd")

base-commit: 536bec1ce5b3d68a6773f31e3788c63e8905ce98
--
2.32.0
M
M
Maxim Cournoyer wrote on 3 Aug 2021 21:01
(name . Xinglu Chen)(address . public@yoctocell.xyz)(address . 49819@debbugs.gnu.org)
87eeba9wun.fsf@gmail.com
Hello,

Xinglu Chen <public@yoctocell.xyz> writes:

Toggle quote (54 lines)
> * gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
> ---
> gnu/packages/emacs-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index e3b94228e1..bbda1db614 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -138,6 +138,7 @@
> #:use-module (gnu packages aspell)
> #:use-module (gnu packages audio)
> #:use-module (gnu packages bash)
> + #:use-module (gnu packages chez)
> #:use-module (gnu packages cmake)
> #:use-module (gnu packages code)
> #:use-module (gnu packages cpp)
> @@ -408,6 +409,48 @@ a generic Scheme interaction mode for the GNU Emacs editor.")
> a generic Scheme interaction mode for the GNU Emacs editor.")
> (license license:bsd-3)))
>
> +(define-public emacs-geiser-chez
> + (package
> + (name "emacs-geiser-chez")
> + (version "0.16")
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://gitlab.com/emacs-geiser/chez")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0cc1z5z5cpvxa5f3n8kvms0wxlybzcg4l1bh3rwv1l1sb0lk1xzx"))))
> + (build-system emacs-build-system)
> + (arguments
> + '(#:include (cons "^src/" %default-include)
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'make-autoloads 'patch-autoloads
> + (lambda* (#:key outputs #:allow-other-keys)
> + (substitute* (string-append
> + (elpa-directory (assoc-ref outputs "out"))
> + "/geiser-chez-autoloads.el")
> + ;; Activating implementations fails when Geiser is not yet
> + ;; loaded, so let's defer that until it is.
> + (("\\(geiser-activate-implementation .*\\)" all)
> + (string-append
> + "(eval-after-load 'geiser-impl '" all ")"))
> + (("\\(geiser-implementation-extension .*\\)" all)
> + (string-append
> + "(eval-after-load 'geiser-impl '" all ")"))))))))

Could you please report the above issue to upstream so that it can
properly be fixed? And then add a reference to it in a comment in the
above package definition.

Toggle quote (14 lines)
> + (inputs
> + `(("chez-scheme" ,chez-scheme)))
> + (propagated-inputs
> + `(("emacs-geiser" ,emacs-geiser)))
> + (home-page "https://nongnu.org/geiser/")
> + (synopsis "Support for Chez Scheme in Geiser")
> + (description
> + "This package adds support for using Chez Scheme in Emacs with Geiser.")
> + (license license:bsd-3)))
> +
> (define-public emacs-vc-hgcmd
> (package
> (name "emacs-vc-hgcmd")

The rest LGTM!

Thank you,

Maxim
X
X
Xinglu Chen wrote on 4 Aug 2021 10:14
Re: [bug#49819] [PATCH] gnu: Add emacs-geiser-chez.
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)(address . 49819@debbugs.gnu.org)
87k0l14oet.fsf@yoctocell.xyz
On Tue, Aug 03 2021, Maxim Cournoyer wrote:

Toggle quote (62 lines)
> Hello,
>
> Xinglu Chen <public@yoctocell.xyz> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
>> ---
>> gnu/packages/emacs-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 43 insertions(+)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index e3b94228e1..bbda1db614 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -138,6 +138,7 @@
>> #:use-module (gnu packages aspell)
>> #:use-module (gnu packages audio)
>> #:use-module (gnu packages bash)
>> + #:use-module (gnu packages chez)
>> #:use-module (gnu packages cmake)
>> #:use-module (gnu packages code)
>> #:use-module (gnu packages cpp)
>> @@ -408,6 +409,48 @@ a generic Scheme interaction mode for the GNU Emacs editor.")
>> a generic Scheme interaction mode for the GNU Emacs editor.")
>> (license license:bsd-3)))
>>
>> +(define-public emacs-geiser-chez
>> + (package
>> + (name "emacs-geiser-chez")
>> + (version "0.16")
>> + (source
>> + (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url "https://gitlab.com/emacs-geiser/chez")
>> + (commit version)))
>> + (file-name (git-file-name name version))
>> + (sha256
>> + (base32
>> + "0cc1z5z5cpvxa5f3n8kvms0wxlybzcg4l1bh3rwv1l1sb0lk1xzx"))))
>> + (build-system emacs-build-system)
>> + (arguments
>> + '(#:include (cons "^src/" %default-include)
>> + #:phases
>> + (modify-phases %standard-phases
>> + (add-after 'make-autoloads 'patch-autoloads
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (substitute* (string-append
>> + (elpa-directory (assoc-ref outputs "out"))
>> + "/geiser-chez-autoloads.el")
>> + ;; Activating implementations fails when Geiser is not yet
>> + ;; loaded, so let's defer that until it is.
>> + (("\\(geiser-activate-implementation .*\\)" all)
>> + (string-append
>> + "(eval-after-load 'geiser-impl '" all ")"))
>> + (("\\(geiser-implementation-extension .*\\)" all)
>> + (string-append
>> + "(eval-after-load 'geiser-impl '" all ")"))))))))
>
> Could you please report the above issue to upstream so that it can
> properly be fixed? And then add a reference to it in a comment in the
> above package definition.

Reported upstream; I will send a v2. :)

-----BEGIN PGP SIGNATURE-----

iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmEKTGoVHHB1YmxpY0B5
b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5BZgP/08Sa/IcTVBCya8IyqyLv0JaDf7T
fCPKUV1mXIXIK0+ZQdHkw+arVsbNuPwUOPfAfBcs98u11Yod3IyE3YnMPyeRGFkG
49ZSGygNMd7zF60Mv90zPbG2sogCXzd7ulMRs1rsc1kx34f8mwamQtYtDaWcqzyo
L3a/xym6K8+aYqXcy930dowQB4ZTj+pW/G2sqVbCjmCr9/YeejlROjjGsN9dg4sF
uiRsCBsW8skPGIKvkSdKGkJ5CMUH/ZlNkR3rA/kM/wY1yGdrndBj0/LfmrQBLZWU
Z9UybS1CxGJMGdpKMMWuW/PCflowvOyW1wc31CUSNgIvf1pT/cZ3KGRqgBODMaz8
GiRHrXj2iT9el4ukOor4d+guPe0zPNJnhSwJxLU+lUZi+NCzuj7mcm+i9vX0gYbA
ytlrGlKs9VJKm8w6h9e1bUsVyql92dNzk9OC9sqwnI59TYeN0NgGkTCDjUwB9/es
x0g9W95mRDIKSOJENTw00SdzbxYCuDaNnweM3o9WXQKaIxFeJXE/Kez9/eEqYVfP
+rGCup6YobYfjIvANXGZOR3plvFYSvrS6cuPBKuUgAyPM3+UmP2jgWBivUwb8epC
TBEVO6QsA18f4dMo2yC/PSzv0BBYjEFgcenyYrRv0zvbf1z3vB4SZaacLPPbz5Ky
bWPajmq8FHaTaLo0
=saGV
-----END PGP SIGNATURE-----

X
X
Xinglu Chen wrote on 4 Aug 2021 10:17
[PATCH v2] gnu: Add emacs-geiser-chez.
(address . 49819@debbugs.gnu.org)(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)
efb47f6834cf382ca6039890a6b84dbe61c01d73.1628065021.git.public@yoctocell.xyz
* gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
---
Changes since v1:

* Add link to upstream issue.

gnu/packages/emacs-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)

Toggle diff (66 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e3b94228e1..f7763c7889 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -138,6 +138,7 @@
#:use-module (gnu packages aspell)
#:use-module (gnu packages audio)
#:use-module (gnu packages bash)
+ #:use-module (gnu packages chez)
#:use-module (gnu packages cmake)
#:use-module (gnu packages code)
#:use-module (gnu packages cpp)
@@ -408,6 +409,49 @@ a generic Scheme interaction mode for the GNU Emacs editor.")
a generic Scheme interaction mode for the GNU Emacs editor.")
(license license:bsd-3)))
+(define-public emacs-geiser-chez
+ (package
+ (name "emacs-geiser-chez")
+ (version "0.16")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://gitlab.com/emacs-geiser/chez")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0cc1z5z5cpvxa5f3n8kvms0wxlybzcg4l1bh3rwv1l1sb0lk1xzx"))))
+ (build-system emacs-build-system)
+ (arguments
+ '(#:include (cons "^src/" %default-include)
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'make-autoloads 'patch-autoloads
+ (lambda* (#:key outputs #:allow-other-keys)
+ (substitute* (string-append
+ (elpa-directory (assoc-ref outputs "out"))
+ "/geiser-chez-autoloads.el")
+ ;; Activating implementations fails when Geiser is not yet
+ ;; loaded, so let's defer that until it is.
+ ;; See <https://gitlab.com/emacs-geiser/chez/-/issues/7>.
+ (("\\(geiser-activate-implementation .*\\)" all)
+ (string-append
+ "(eval-after-load 'geiser-impl '" all ")"))
+ (("\\(geiser-implementation-extension .*\\)" all)
+ (string-append
+ "(eval-after-load 'geiser-impl '" all ")"))))))))
+ (inputs
+ `(("chez-scheme" ,chez-scheme)))
+ (propagated-inputs
+ `(("emacs-geiser" ,emacs-geiser)))
+ (home-page "https://nongnu.org/geiser/")
+ (synopsis "Support for Chez Scheme in Geiser")
+ (description
+ "This package adds support for using Chez Scheme in Emacs with Geiser.")
+ (license license:bsd-3)))
+
(define-public emacs-vc-hgcmd
(package
(name "emacs-vc-hgcmd")

base-commit: 10f554700c417b84c22c56fdd007567a52c45d75
--
2.32.0
M
M
Maxim Cournoyer wrote on 4 Aug 2021 17:32
(name . Xinglu Chen)(address . public@yoctocell.xyz)(address . 49819-done@debbugs.gnu.org)
87v94l6x9n.fsf@gmail.com
Hello,

Xinglu Chen <public@yoctocell.xyz> writes:

Toggle quote (9 lines)
> * gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
> ---
> Changes since v1:
>
> * Add link to upstream issue.
>
> gnu/packages/emacs-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)

Pushed with commit dfb154e6d0.

Thanks!

Closing.

Maxim
Closed
?