[PATCH 1/2] gnu: emacs-org-roam: Update to 2.0.0.

  • Done
  • quality assurance status badge
Details
3 participants
  • Nicolas Goaziou
  • Vinicius Monego
  • Pierre Langlois
Owner
unassigned
Submitted by
Vinicius Monego
Severity
normal
V
V
Vinicius Monego wrote on 20 Jul 2021 21:31
(address . guix-patches@gnu.org)(name . Vinicius Monego)(address . monego@posteo.net)
20210720193129.24772-1-monego@posteo.net
* gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.0.0.
[propagated-inputs]: Add emacs-magit.
---
gnu/packages/emacs-xyz.scm | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Toggle diff (32 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 41608d71e0..8b188a1d3e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27846,7 +27846,7 @@ snippets for Emacs.")
(define-public emacs-org-roam
(package
(name "emacs-org-roam")
- (version "1.2.4")
+ (version "2.0.0")
(source
(origin
(method git-fetch)
@@ -27855,7 +27855,7 @@ snippets for Emacs.")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
- (base32 "10jrnjq65lpg1x8d7lqc537yai9m6pdnfbzwr87fcyv6f8yii8xn"))))
+ (base32 "0mslrdgd41czay3w7znz4qsv1h0p3zqfsq6bkyxmxfyd2w5z82zf"))))
(build-system emacs-build-system)
(arguments
`(#:phases
@@ -27878,6 +27878,7 @@ snippets for Emacs.")
`(("emacs-dash" ,emacs-dash)
("emacs-emacsql-sqlite3" ,emacs-emacsql-sqlite3)
("emacs-f" ,emacs-f)
+ ("emacs-magit" ,emacs-magit)
("emacs-org" ,emacs-org)
("emacs-s" ,emacs-s)))
(home-page "https://github.com/org-roam/org-roam/")
--
2.30.2
V
V
Vinicius Monego wrote on 20 Jul 2021 21:33
[PATCH 2/2] gnu: emacs-org-roam-bibtex: Update to 0.6.0.
(address . 49668@debbugs.gnu.org)(name . Vinicius Monego)(address . monego@posteo.net)
20210720193311.24912-1-monego@posteo.net
* gnu/packages/emacs-xyz.scm (emacs-org-roam-bibtex): Update to 0.6.0.
---
gnu/packages/emacs-xyz.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (24 lines)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8b188a1d3e..d3be38d065 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27893,7 +27893,7 @@ personal wiki.")
(define-public emacs-org-roam-bibtex
(package
(name "emacs-org-roam-bibtex")
- (version "0.6.0-pre.2")
+ (version "0.6.0")
(source
(origin
(method git-fetch)
@@ -27902,7 +27902,7 @@ personal wiki.")
(commit (string-append "v" version))))
(file-name (git-file-name name version))
(sha256
- (base32 "0cjj7lx73qg4yw84r3b8fqhp5r74bzi57nvnvbvbck4i33ywqwx5"))))
+ (base32 "04vc2w7x2lyamp0qa1y274smsf9x2qxr1igrpz9f4y5ha5332px5"))))
(build-system emacs-build-system)
(propagated-inputs
`(("emacs-helm-bibtex" ,emacs-helm-bibtex)
--
2.30.2
P
P
Pierre Langlois wrote on 20 Jul 2021 21:53
Re: [bug#49668] [PATCH 1/2] gnu: emacs-org-roam: Update to 2.0.0.
(name . Vinicius Monego)(address . monego@posteo.net)
87mtqgsqxb.fsf@gmx.com
Hi Vinicius,

Vinicius Monego writes:

Toggle quote (3 lines)
> * gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.0.0.
> [propagated-inputs]: Add emacs-magit.

Given the v1 -> v2 migration requires a manual process, it might be a
good idea to keep a v1 package for users that may want to stay on it for
a little bit longer, what do you think? The author has kept a
https://github.com/org-roam/org-roam-v1repository for this effect.

Otherwise I tested the update and it looks good to me! I was able to
migrate successfully, but I don't have that many notes.

Thanks,
Pierre
-----BEGIN PGP SIGNATURE-----

iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmD3KbAYHHBpZXJyZS5s
YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UEFIIAMJWUrNDQBxGm8sTbKD8aXGC
U827BJh54x6mk8J+4HiRtesAL21CjQbiLdPvtWKlfXweZKTZQxiF7ToyUZPxVmqA
nmqzY3i2SbDmPdZq+ax9Fje+ZIAYClEu449htCeu73yFUd9OA0kuOW41fyUarJ7Q
w+s/6SRP8AT3BgNwUK+ApaR/c8xZ5cjwfT+avpYnHiOZs9xee45av3irhpTbJsIr
JBF9y0q0/IcWQnePKEKAEBZ8cCUD+wcJOnccGFGQETGZfeG6OUDm01r0LBsGFSCb
DSfPKv7ampcobP/hdLzWZpCpjnDBGLCBDA1AvV2OcS70iz02lq5sYOIoMcKWt40=
=/Bc/
-----END PGP SIGNATURE-----

V
V
Vinicius Monego wrote on 21 Jul 2021 16:58
(name . Pierre Langlois)(address . pierre.langlois@gmx.com)(address . 49668@debbugs.gnu.org)
f4d0853c3a4de95127c33abef4d814926e1a1da2.camel@posteo.net
Hi Pierre,

Em ter, 2021-07-20 às 20:53 +0100, Pierre Langlois escreveu:
Toggle quote (6 lines)
> Given the v1 -> v2 migration requires a manual process, it might be a
> good idea to keep a v1 package for users that may want to stay on it
> for
> a little bit longer, what do you think? The author has kept a
> https://github.com/org-roam/org-roam-v1 repository for this effect.

The description of that repository says "No longer actively maintained.
" and the README recommends the migration. That is my main concern,
introducing a package that we know for a fact that is unmaintained and
don't have a schedule for removal. It feels more like a use case for a
custom channel.

Another option is to hold this update until 2.0.1 after v2 is more
widely used, though Guix users who wish to migrate now would have to
update manually in that case.

I will wait for more feedback on this.

Vinicius
P
P
Pierre Langlois wrote on 21 Jul 2021 18:01
(name . Vinicius Monego)(address . monego@posteo.net)
87y29zlkp4.fsf@gmx.com
Hi Vinicius,

Vinicius Monego writes:

Toggle quote (15 lines)
> Hi Pierre,
>
> Em ter, 2021-07-20 às 20:53 +0100, Pierre Langlois escreveu:
>> Given the v1 -> v2 migration requires a manual process, it might be a
>> good idea to keep a v1 package for users that may want to stay on it
>> for
>> a little bit longer, what do you think? The author has kept a
>> https://github.com/org-roam/org-roam-v1 repository for this effect.
>
> The description of that repository says "No longer actively maintained.
> " and the README recommends the migration. That is my main concern,
> introducing a package that we know for a fact that is unmaintained and
> don't have a schedule for removal. It feels more like a use case for a
> custom channel.

That's a fair point, we might forget to ever remove the old v1 package
:-). I don't have a strong opinion given I was able to migrate myself
without any trouble, there was many posts in the community about the
migration that made me feel we might want to be cautious.

But thinking about it more now, emacs makes it easy to install packages
manually, so if one really needs to stay on v1 for a bit, they can
always do it outside of Guix.

So you can consider my mind changed on this matter :-).

Thanks,
Pierre
-----BEGIN PGP SIGNATURE-----

iQFMBAEBCgA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAmD4RPgYHHBpZXJyZS5s
YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31U+0kH/0NXG3/v9DX1XOApM8T4GY+l
pVVxYrBorm6VXu9T2Ebf/heSx1k0q/txP6+BjQTuMP9Lc7kMgl2OuJ8WlGQl1Yv/
WLSMg+37l+/mhcl8AJs1jOYCRoKeb9voIkHqiiS40fAnJPMwt5VWGHTPU44/raTC
iYDcf/2RuhixGlHWgNg8ip0touUXOPJJJNBkdxVnkIvNytp2PIzX2Pc/lrcvxzDR
b1eJP/uIRijUsd5PCDAxYlIHG8x/8OwX8wwHtDU9IvFxDEqRDvGUdIPwlCIlj+iQ
NtlBrT1D7BLcddNFObBF0WA4BZRGBw/wP/qZII6CmtLK6qKwPi3aQ3MwfdbuXP0=
=8Mcn
-----END PGP SIGNATURE-----

N
N
Nicolas Goaziou wrote on 27 Jul 2021 19:11
(name . Vinicius Monego)(address . monego@posteo.net)(address . 49668-done@debbugs.gnu.org)
87czr3r8au.fsf@nicolasgoaziou.fr
Hello,

Vinicius Monego <monego@posteo.net> writes:

Toggle quote (3 lines)
> * gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.0.0.
> [propagated-inputs]: Add emacs-magit.

Applied both patches. Thank you.

Regards,
--
Nicolas Goaziou
Closed
?