[PATCH] gnu: Add cawbird.

DoneSubmitted by Raghav Gururajan.
Details
2 participants
  • Maxim Cournoyer
  • Raghav Gururajan
Owner
unassigned
Severity
normal
R
R
Raghav Gururajan wrote on 13 May 06:31 +0200
(address . guix-patches@gnu.org)(name . Raghav Gururajan)(address . rg@raghavgururajan.name)
20210513043153.2545-1-rg@raghavgururajan.name
* gnu/packages/syndication.scm (cawbird): New variable.--- gnu/packages/syndication.scm | 91 ++++++++++++++++++++++++++++++++++++ 1 file changed, 91 insertions(+)
Toggle diff (106 lines)diff --git a/gnu/packages/syndication.scm b/gnu/packages/syndication.scmindex 3d0b9c39c8..64ffcf2046 100644--- a/gnu/packages/syndication.scm+++ b/gnu/packages/syndication.scm@@ -59,8 +59,99 @@ #:use-module (gnu packages web) #:use-module (gnu packages webkit) #:use-module (gnu packages xml)+ #:use-module (gnu packages xorg) #:use-module (srfi srfi-1)) +(define-public cawbird+ (package+ (name "cawbird")+ (version "1.4.1")+ (source+ (origin+ (method git-fetch)+ (uri (git-reference+ (url "https://github.com/IBBoard/cawbird")+ (commit (string-append "v"version))))+ (file-name (git-file-name name version))+ (sha256+ (base32 "0lmrgcj1ky1vhzynl36k6ba3ws089x4qdrnkjk3lbr334kicx9na"))))+ (build-system meson-build-system)+ (arguments+ `(#:glib-or-gtk? #t+ #:configure-flags+ ;; Cawbirds's default key and secret for OAuth process with twitter.+ (list+ "-Dconsumer_key_base64=VmY5dG9yRFcyWk93MzJEZmhVdEk5Y3NMOA=="+ "-Dconsumer_secret_base64=MThCRXIxbWRESDQ2Y0podzVtVU13SGUyVGlCRXhPb3BFRHhGYlB6ZkpybG5GdXZaSjI=")+ #:phases+ (modify-phases %standard-phases+ (add-after 'unpack 'disable-failing-tests+ (lambda _+ ;; These tests require networking.+ (substitute* "tests/meson.build"+ (("[ \t]*.*avatardownload.*$") "")+ (("[ \t]*.*filters.*$") "")+ (("[ \t]*.*friends.*$") "")+ (("[ \t]*.*inlinemediadownloader.*$") "")+ (("[ \t]*.*tweetparsing.*$") "")+ (("[ \t]*.*usercounter.*$") ""))))+ (delete 'check)+ (add-after 'install 'custom-check+ (lambda* (#:key outputs tests? #:allow-other-keys)+ (when tests?+ ;; Tests require a running X server.+ (system "Xvfb :1 +extension GLX &")+ (setenv "DISPLAY" ":1")+ ;; Tests write to $HOME.+ (setenv "HOME" (getcwd))+ ;; Tests look for gsettings-schemas installed by the package.+ (setenv "XDG_DATA_DIRS"+ (string-append (getenv "XDG_DATA_DIRS")+ ":" (assoc-ref outputs "out") "/share"))+ (invoke "meson" "test"))+ #t))+ (add-after 'glib-or-gtk-wrap 'wrap-paths+ (lambda* (#:key outputs #:allow-other-keys)+ (let* ((out (assoc-ref outputs "out"))+ (bin (string-append out "/bin/"))+ (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH"))+ (gi-typelib-path (getenv "GI_TYPELIB_PATH")))+ (wrap-program (string-append bin "cawbird")+ `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path))+ `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))+ #t)))))+ (native-inputs+ `(("gettext" ,gettext-minimal)+ ("glib:bin" ,glib "bin")+ ("gobject-introspection" ,gobject-introspection)+ ("gtk+:bin" ,gtk+ "bin")+ ("pkg-config" ,pkg-config)+ ("vala" ,vala)+ ("xmllint" ,libxml2)+ ("xorg-server" ,xorg-server-for-tests)))+ (inputs+ `(("glib" ,glib)+ ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)+ ("gspell" ,gspell)+ ("gstreamer" ,gstreamer)+ ("gst-libav" ,gst-libav)+ ("gst-plugins-base" ,gst-plugins-base)+ ("gst-plugins-good" ,gst-plugins-good)+ ("gtk+" ,gtk+)+ ("json-glib" ,json-glib)+ ("liboauth" ,liboauth)+ ("libsoup" ,libsoup)+ ("rest" ,rest)+ ("sqlite" ,sqlite)+ ("x11" ,libx11)))+ (propagated-inputs+ `(("dconf" ,dconf)))+ (synopsis "Client for Twitter")+ (description "Cawbird is a twitter app, built with GTK. It supports all of+the main twitter features.")+ (home-page "https://ibboard.co.uk/cawbird/")+ (license license:gpl3+)))+ (define-public giara (package (name "giara")-- 2.31.1
R
R
Raghav Gururajan wrote on 14 May 00:08 +0200
[PATCH v2] gnu: Add cawbird.
(address . 48394@debbugs.gnu.org)(name . Raghav Gururajan)(address . rg@raghavgururajan.name)
20210513220854.15499-1-rg@raghavgururajan.name
* gnu/packages/syndication.scm (cawbird): New variable.--- gnu/packages/syndication.scm | 92 ++++++++++++++++++++++++++++++++++++ 1 file changed, 92 insertions(+)
Toggle diff (107 lines)diff --git a/gnu/packages/syndication.scm b/gnu/packages/syndication.scmindex 3d0b9c39c8..a6bd0c2ce5 100644--- a/gnu/packages/syndication.scm+++ b/gnu/packages/syndication.scm@@ -59,8 +59,100 @@ #:use-module (gnu packages web) #:use-module (gnu packages webkit) #:use-module (gnu packages xml)+ #:use-module (gnu packages xorg) #:use-module (srfi srfi-1)) +(define-public cawbird+ (package+ (name "cawbird")+ (version "1.4.1")+ (source+ (origin+ (method git-fetch)+ (uri (git-reference+ (url "https://github.com/IBBoard/cawbird")+ (commit (string-append "v"version))))+ (file-name (git-file-name name version))+ (sha256+ (base32 "0lmrgcj1ky1vhzynl36k6ba3ws089x4qdrnkjk3lbr334kicx9na"))))+ (build-system meson-build-system)+ (arguments+ `(#:glib-or-gtk? #t+ #:configure-flags+ ;; Cawbirds's default key and secret for OAuth process with twitter.+ (list+ "-Dconsumer_key_base64=VmY5dG9yRFcyWk93MzJEZmhVdEk5Y3NMOA=="+ "-Dconsumer_secret_base64=MThCRXIxbWRESDQ2Y0podzVtVU13SGUyVGlCRXhPb3BFRHhGYlB6ZkpybG5GdXZaSjI=")+ #:phases+ (modify-phases %standard-phases+ (add-after 'unpack 'disable-failing-tests+ (lambda _+ ;; These tests require networking.+ (substitute* "tests/meson.build"+ (("[ \t]*.*avatardownload.*$") "")+ (("[ \t]*.*filters.*$") "")+ (("[ \t]*.*friends.*$") "")+ (("[ \t]*.*inlinemediadownloader.*$") "")+ (("[ \t]*.*tweetparsing.*$") "")+ (("[ \t]*.*usercounter.*$") ""))))+ (delete 'check)+ (add-after 'install 'custom-check+ (lambda* (#:key outputs tests? #:allow-other-keys)+ (when tests?+ ;; Tests require a running X server.+ (system "Xvfb :1 +extension GLX &")+ (setenv "DISPLAY" ":1")+ ;; Tests write to $HOME.+ (setenv "HOME" (getcwd))+ ;; Tests look for gsettings-schemas installed by the package.+ (setenv "XDG_DATA_DIRS"+ (string-append (getenv "XDG_DATA_DIRS")+ ":" (assoc-ref outputs "out") "/share"))+ (invoke "meson" "test"))+ #t))+ (add-after 'glib-or-gtk-wrap 'wrap-paths+ (lambda* (#:key outputs #:allow-other-keys)+ (let* ((out (assoc-ref outputs "out"))+ (bin (string-append out "/bin/"))+ (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH"))+ (gi-typelib-path (getenv "GI_TYPELIB_PATH")))+ (wrap-program (string-append bin "cawbird")+ `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path))+ `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))+ #t)))))+ (native-inputs+ `(("gettext" ,gettext-minimal)+ ("glib:bin" ,glib "bin")+ ("gobject-introspection" ,gobject-introspection)+ ("gtk+:bin" ,gtk+ "bin")+ ("pkg-config" ,pkg-config)+ ("vala" ,vala)+ ("xmllint" ,libxml2)+ ("xorg-server" ,xorg-server-for-tests)))+ (inputs+ `(("glib" ,glib)+ ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)+ ("gspell" ,gspell)+ ("gstreamer" ,gstreamer)+ ("gst-libav" ,gst-libav)+ ("gst-plugins-bad" ,gst-plugins-bad)+ ("gst-plugins-base" ,gst-plugins-base)+ ("gst-plugins-good" ,gst-plugins-good)+ ("gtk+" ,gtk+)+ ("json-glib" ,json-glib)+ ("liboauth" ,liboauth)+ ("libsoup" ,libsoup)+ ("rest" ,rest)+ ("sqlite" ,sqlite)+ ("x11" ,libx11)))+ (propagated-inputs+ `(("dconf" ,dconf)))+ (synopsis "Client for Twitter")+ (description "Cawbird is a twitter app, built with GTK. It supports all of+the main twitter features.")+ (home-page "https://ibboard.co.uk/cawbird/")+ (license license:gpl3+)))+ (define-public giara (package (name "giara")-- 2.31.1
M
M
Maxim Cournoyer wrote on 14 May 05:40 +0200
Re: bug#48394: [PATCH] gnu: Add cawbird.
(name . Raghav Gururajan)(address . rg@raghavgururajan.name)(address . 48394@debbugs.gnu.org)
87sg2q6l0g.fsf_-_@gmail.com
Hello Raghav,
Raghav Gururajan <rg@raghavgururajan.name> writes:
Toggle quote (39 lines)> * gnu/packages/syndication.scm (cawbird): New variable.> ---> gnu/packages/syndication.scm | 92 ++++++++++++++++++++++++++++++++++++> 1 file changed, 92 insertions(+)>> diff --git a/gnu/packages/syndication.scm b/gnu/packages/syndication.scm> index 3d0b9c39c8..a6bd0c2ce5 100644> --- a/gnu/packages/syndication.scm> +++ b/gnu/packages/syndication.scm> @@ -59,8 +59,100 @@> #:use-module (gnu packages web)> #:use-module (gnu packages webkit)> #:use-module (gnu packages xml)> + #:use-module (gnu packages xorg)> #:use-module (srfi srfi-1))> > +(define-public cawbird> + (package> + (name "cawbird")> + (version "1.4.1")> + (source> + (origin> + (method git-fetch)> + (uri (git-reference> + (url "https://github.com/IBBoard/cawbird")> + (commit (string-append "v"version))))> + (file-name (git-file-name name version))> + (sha256> + (base32 "0lmrgcj1ky1vhzynl36k6ba3ws089x4qdrnkjk3lbr334kicx9na"))))> + (build-system meson-build-system)> + (arguments> + `(#:glib-or-gtk? #t> + #:configure-flags> + ;; Cawbirds's default key and secret for OAuth process with twitter.> + (list> + "-Dconsumer_key_base64=VmY5dG9yRFcyWk93MzJEZmhVdEk5Y3NMOA=="> +> "-Dconsumer_secret_base64=MThCRXIxbWRESDQ2Y0podzVtVU13SGUyVGlCRXhPb3BFRHhGYlB6ZkpybG5GdXZaSjI=")
I found that weird to put the secret key only base64-encoded here, butthat seems to be how it is intended for the "default key":https://github.com/IBBoard/cawbird/commit/9f0f3201ce866a8ad06f8ec4642790182642bb72.Weird also that it wants it at build time rather than at run time, buthey.
Toggle quote (67 lines)> + #:phases> + (modify-phases %standard-phases> + (add-after 'unpack 'disable-failing-tests> + (lambda _> + ;; These tests require networking.> + (substitute* "tests/meson.build"> + (("[ \t]*.*avatardownload.*$") "")> + (("[ \t]*.*filters.*$") "")> + (("[ \t]*.*friends.*$") "")> + (("[ \t]*.*inlinemediadownloader.*$") "")> + (("[ \t]*.*tweetparsing.*$") "")> + (("[ \t]*.*usercounter.*$") ""))))> + (delete 'check)> + (add-after 'install 'custom-check> + (lambda* (#:key outputs tests? #:allow-other-keys)> + (when tests?> + ;; Tests require a running X server.> + (system "Xvfb :1 +extension GLX &")> + (setenv "DISPLAY" ":1")> + ;; Tests write to $HOME.> + (setenv "HOME" (getcwd))> + ;; Tests look for gsettings-schemas installed by the package.> + (setenv "XDG_DATA_DIRS"> + (string-append (getenv "XDG_DATA_DIRS")> + ":" (assoc-ref outputs "out") "/share"))> + (invoke "meson" "test"))> + #t))> + (add-after 'glib-or-gtk-wrap 'wrap-paths> + (lambda* (#:key outputs #:allow-other-keys)> + (let* ((out (assoc-ref outputs "out"))> + (bin (string-append out "/bin/"))> + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH"))> + (gi-typelib-path (getenv "GI_TYPELIB_PATH")))> + (wrap-program (string-append bin "cawbird")> + `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path))> + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path))))> + #t)))))> + (native-inputs> + `(("gettext" ,gettext-minimal)> + ("glib:bin" ,glib "bin")> + ("gobject-introspection" ,gobject-introspection)> + ("gtk+:bin" ,gtk+ "bin")> + ("pkg-config" ,pkg-config)> + ("vala" ,vala)> + ("xmllint" ,libxml2)> + ("xorg-server" ,xorg-server-for-tests)))> + (inputs> + `(("glib" ,glib)> + ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)> + ("gspell" ,gspell)> + ("gstreamer" ,gstreamer)> + ("gst-libav" ,gst-libav)> + ("gst-plugins-bad" ,gst-plugins-bad)> + ("gst-plugins-base" ,gst-plugins-base)> + ("gst-plugins-good" ,gst-plugins-good)> + ("gtk+" ,gtk+)> + ("json-glib" ,json-glib)> + ("liboauth" ,liboauth)> + ("libsoup" ,libsoup)> + ("rest" ,rest)> + ("sqlite" ,sqlite)> + ("x11" ,libx11)))> + (propagated-inputs> + `(("dconf" ,dconf)))> + (synopsis "Client for Twitter")> + (description "Cawbird is a twitter app, built with GTK.
Perhaps: "Cawbird is a Twitter client that uses the GTK+ toolkit." ?
Toggle quote (1 lines)> +the main twitter features.")
^ Twitter
I'd expand a bit on what some of these main features might be (textmessages, sharing photos, ?).
I haven't tested, but after my above comments, if it passes 'guix lint',builds and runs, LGTM.
Thank you!
Maxim
R
R
Raghav Gururajan wrote on 14 May 06:21 +0200
(name . Maxim Cournoyer)(address . maxim.cournoyer@gmail.com)(address . 48394-done@debbugs.gnu.org)
03968187-e896-0e98-b2d0-d1f94065ab59@raghavgururajan.name
Hi Maxim,
Toggle quote (6 lines)> I found that weird to put the secret key only base64-encoded here, but> that seems to be how it is intended for the "default key":> https://github.com/IBBoard/cawbird/commit/9f0f3201ce866a8ad06f8ec4642790182642bb72.> Weird also that it wants it at build time rather than at run time, but> hey.
ikr. There is an alternative option for per-user key and secret as mentioned here (https://github.com/IBBoard/cawbird#preparation),but that would uniquely identify each user.
Toggle quote (12 lines)> Perhaps: "Cawbird is a Twitter client that uses the GTK+ toolkit." ?> >> +the main twitter features.")> ^> Twitter> > I'd expand a bit on what some of these main features might be (text> messages, sharing photos, ?).> > I haven't tested, but after my above comments, if it passes 'guix lint',> builds and runs, LGTM.
Made the suggested changes and pushed as 100281dd200d0a59958fb17dc6de75d3913e2b7a.
Thanks!
Regards,RG.
Attachment: OpenPGP_signature
Closed
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send email to 48394@debbugs.gnu.org