Hello! The first patch here addresses a locale warning coming from Bashthat I noticed while using 1.3.0rc1 on Debian. Concretely, withoutthis patch, users will see the Bash locale warning every time‘guix substitute’ starts (so at least once per session). The second patch is stylistic: it avoids missing phases, which Ifind more readable. Tested with a native x86_64-linux build and with‘--target=aarch64-linux-gnu’ from x86_64-linux. I’d like to have these in ‘version-1.3.0’. Thoughts? Ludo’. Ludovic Courtès (2): gnu: guix: Avoid Bash wrapper. gnu: guix: Phases refer to #:system and #:target. gnu/packages/package-management.scm | 74 +++++++++++++++-------------- 1 file changed, 38 insertions(+), 36 deletions(-) -- 2.31.1
The Bash wrapper created by 'wrap-program' creates an extraindirection and may annoyingly emit locale warnings: /gnu/store/…-bash-minimal-5.0.16/bin/bash: warning: setlocale: LC_ALL: cannot change locale (wtf) This warning would typically show up when running Guix, as produced by'guix pack guix', on a foreign distro, annihilating efforts made in1d4ab335b22a93e01c2eb1eb3e93fc6534157040 and8a973abc6f7eebfcd8a904bfbb99cb9f86f66ef0. * gnu/packages/package-management.scm (guix)[arguments]: In'wrap-program' phase, remove 'string-join' call for PATH and GOPATH.Replace 'wrap-program' call with a 'substitute*' form. Remove (whentarget ...) form.[inputs]: Remove "bash-minimal" added in commit38b9af7c92344a17b6680ebd2aeea14171f84a1c and no longer needed.--- gnu/packages/package-management.scm | 56 ++++++++++++++++------------- 1 file changed, 31 insertions(+), 25 deletions(-)
Why not simply ;; avahi is #f (not in 'inputs') when cross-compiling. ;; Remove it. (deps* (delete #f avahi))? Then, when guile-avahi becomes cross-compilable at some point, we onlyneed to adjust 'propagated-inputs' and not anything else. Also, was this code (deps* ,@(if (%current-target-system) '(deps) ...)) needed inthe first place? guile2.2-guix inherits its phases from guix, and guile2.2-guix doesnot have a guile-zlib or guile-lzlib input. Greetings,Maxime.