[PATCH] gnu: python-libtmux: Fix build by removing tests broken by tmux update

  • Done
  • quality assurance status badge
Details
5 participants
  • Edouard Klein
  • Edouard Klein
  • Hartmut Goebel
  • Maxime Devos
  • Tobias Geerinckx-Rice
Owner
unassigned
Submitted by
Edouard Klein
Severity
normal
E
E
Edouard Klein wrote on 27 Apr 2021 15:20
(address . guix-patches@gnu.org)(name . Edouard Klein)(address . edouard@hex.lan)
20210427132000.176985-1-edk@beaver-labs.com
From: Edouard Klein <edouard@hex.lan>

tmux update from 3.1c to 3.2 breaks two tests in this package by quoting the
returned value of a tmux call. No harm done, a fix upstream is unlikely.
---
gnu/packages/tmux.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/tmux.scm b/gnu/packages/tmux.scm
index f208fbfd93..9cd632f535 100644
--- a/gnu/packages/tmux.scm
+++ b/gnu/packages/tmux.scm
@@ -178,7 +178,9 @@ windows.")
;; https://github.com/tmux-python/libtmux/issues/281
(invoke "pytest" "-vv" "-k"
(string-append "not test_show_option_unknown "
- "and not test_show_window_option_unknown"))
+ "and not test_show_window_option_unknown "
+ "and not test_split_window_shell "
+ "and not test_new_session_shell"))
#t)))))
(home-page "https://github.com/tmux-python/libtmux")
(synopsis "Python API for tmux")
--
2.31.1
T
T
Tobias Geerinckx-Rice wrote on 27 Apr 2021 15:39
(name . Edouard Klein)(address . edk@beaver-labs.com)
8735vbsv7j.fsf@nckx
Edouard,

Edouard Klein ???
Toggle quote (5 lines)
> tmux update from 3.1c to 3.2 breaks two tests in this package by
> quoting the
> returned value of a tmux call. No harm done, a fix upstream is
> unlikely.

Hm... why's that? Does upstream not support their own test suite?

Thanks!

T G-R
-----BEGIN PGP SIGNATURE-----

iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYIgUAQ0cbWVAdG9iaWFz
LmdyAAoJEA2w/4hPVW15/ocA/RFiiU3M590j8UBh7rRmqxMAcsNX3A/1sGhhN51M
7LISAQDfHYpZJpznZZsI4ckx2lj4mMesQePBC6gNTjkAUYHUCg==
=rIOu
-----END PGP SIGNATURE-----

T
T
Tobias Geerinckx-Rice wrote on 27 Apr 2021 15:43
(name . Edouard Klein)(address . edk@beaver-labs.com)
87zgxjrgfh.fsf@nckx
Edouard,

Edouard Klein ???
Toggle quote (2 lines)
> From: Edouard Klein <edouard@hex.lan>

Oh, you should change this to a routable mail address ;-)

$ git config user.email edk@beaver-labs.com

Kind regards,

T G-R
-----BEGIN PGP SIGNATURE-----

iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYIgVEg0cbWVAdG9iaWFz
LmdyAAoJEA2w/4hPVW15dhsBAL40Y6oblC8vDq/XnvqzkOUGL5BM7eJfEwdZ0x6U
hIlVAP4rHSVvlZ02lXIferKHhf9MmFwcnS+aBgBAIywszQZyAQ==
=UhIG
-----END PGP SIGNATURE-----

E
E
Edouard Klein wrote on 27 Apr 2021 18:24
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)
87a6pjofuv.fsf@rdklein.fr
Tobias Geerinckx-Rice writes:

Toggle quote (9 lines)
> Edouard,
>
> Edouard Klein ???
>> tmux update from 3.1c to 3.2 breaks two tests in this package by quoting the
>> returned value of a tmux call. No harm done, a fix upstream is unlikely.
>
> Hm... why's that? Does upstream not support their own test suite?
>

The issue I opened last year about the two other tests failing is still
unresolved

There seems to be little ongoing development:

My suspicion is that the maintainer is using debian or another slow
distro that still use tmux 2, which I believe make the test pass (at
leat it did when I tested it last year)

There is no way in Python to specify which version of tmux this is
supposed to run against. This is one of the strength of GNU Guix :)

So:
- the change in behaviour between tmux 2 and 3 is not
important enough to be noticeable in any of my use cases,
- I have little time,
- the maintainer upstream is likely using tmux 2,


all-in-all, this makes me say that an upstream fix is unlikely because I
can't write it myself and nobody else is likely to, either.

Toggle quote (2 lines)
> Thanks!
>
Thank you for maintaining Guix :)

Toggle quote (1 lines)
> T G-R
E
E
Edouard Klein wrote on 27 Apr 2021 18:26
(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)
877dknofs2.fsf@rdklein.fr
Tobias Geerinckx-Rice writes:

Toggle quote (9 lines)
> Edouard,
>
> Edouard Klein ???
>> From: Edouard Klein <edouard@hex.lan>
>
> Oh, you should change this to a routable mail address ;-)
>
> $ git config user.email edk@beaver-labs.com
>
$ git config --get user.email
edk@beaver-labs.com

I don't know why git send-email is using my hostname. I'll have to
investigate. Thanks for pointing it out :)

Toggle quote (3 lines)
> Kind regards,
>
> T G-R
E
E
edk wrote on 28 May 2021 09:38
Re: bug#48059: Acknowledgement ([PATCH] gnu: python-libtmux: Fix build by removing tests broken by tmux update)
(address . 48059@debbugs.gnu.org)
87a6ofb94l.fsf@rdklein.fr
Sorry to be a bother, but could we please merge this ? We depend on this
package and we have to use guix time machine because it is broken. We
would very much like to enjoy the new 1.3 features.

Thanks in advance,

Cheers,

Edouard.
GNU bug Tracking System writes:

Toggle quote (16 lines)
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
> guix-patches@gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 48059@debbugs.gnu.org.
>
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
M
M
Maxime Devos wrote on 28 May 2021 09:56
Re: [bug#48059] Acknowledgement ([PATCH] gnu: python-libtmux: Fix build by removing tests broken by tmux update)
6c34ce5fed15d19552721daf323cd256f43de010.camel@telenet.be
edk@beaver-labs.com schreef op vr 28-05-2021 om 09:38 [+0200]:
Toggle quote (4 lines)
> Sorry to be a bother, but could we please merge this ? We depend on this
> package and we have to use guix time machine because it is broken. We
> would very much like to enjoy the new 1.3 features.

I guess it is good to merge, but someone else would have to actually commit
it! (I am not committer)

Sorry for the delay. Bugs and patches can easily get forgotten after a while.

Greetings,
Maxime
-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYLCiPBccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rdzAP9RgD9/y1lFe4/mo85SIKzn49wx
qS8OYnAfCi5/lGQPKAEA1MN4p5GeIe/T9Gprv0GTSnaKFmHukHTNGKn6eV8nSgI=
=Qc94
-----END PGP SIGNATURE-----


E
E
Edouard Klein wrote on 28 May 2021 18:17
(name . Maxime Devos)(address . maximedevos@telenet.be)(address . 48059@debbugs.gnu.org)
871r9qbzoa.fsf@rdklein.fr
Thanks, no worries, I understand :)
Maxime Devos writes:

Toggle quote (12 lines)
> edk@beaver-labs.com schreef op vr 28-05-2021 om 09:38 [+0200]:
>> Sorry to be a bother, but could we please merge this ? We depend on this
>> package and we have to use guix time machine because it is broken. We
>> would very much like to enjoy the new 1.3 features.
>
> I guess it is good to merge, but someone else would have to actually commit
> it! (I am not committer)
>
> Sorry for the delay. Bugs and patches can easily get forgotten after a while.
>
> Greetings,
> Maxime
H
H
Hartmut Goebel wrote on 22 Jun 2022 19:13
control message for bug #48059
(address . control@debbugs.gnu.org)
87k098y620.fsf@lenashee.goebel-consult.de
close 48059
quit
?