python2 variants made through (package-with-python2 (strip-python2-variant ...)) don't inherit grafts

  • Done
  • quality assurance status badge
Details
2 participants
  • Léo Le Bouter
  • Mark H Weaver
Owner
unassigned
Submitted by
Léo Le Bouter
Severity
normal
L
L
Léo Le Bouter wrote on 16 Mar 2021 09:32
(address . bug-guix@gnu.org)
a09511b42db842c4a3290ead13574f7f7fc77b64.camel@zaclys.net
As outlined by:
-
-

Two commits needed to be made to fix the issue both in the python2 and
python3 variants, if the package-with-python2 and strip-python2-variant
function could make so it inherits grafts it would make grafting python
packages with python2 variants less "forget"-prone.
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmBQbTIACgkQRaix6GvN
EKb6Yw//dl5VoBoqoUWalXp4SyosLWBWJ8RSHrn0lK+XPPuwn7uR8oFSMF3tiuiv
mw4mQYsXyow1SvOnhxgzOlC94ALiz1aI8pw8le7zhHUntROuSapO00M3lAqtSSDC
KnUaE4v2/T+hLgqCTUGm7j+IfXaL4rj3wkuV737sCM3p0LE2+jcFw7pjNl4gTpSW
YytC19yxdHOdiuVQjvZZEaMzFilsgMMfMiApvA+Aanf09chymTIG0yJvuCt7d1Bz
Hj3x63g1D47eDDAWI+IQ7MOSRJhzF0mZRyoGLBvY7grWaPV5CmSfRv++zrtZcIRm
CKEzuf4EuAML8k3FI+dA6uMYoFOj+BaisiSLcCO4ma00gFuECRHSDBpNow4Vp0mb
o4Su+sQoIUm8aklAf+ovGB77eDKi09ylzUs+MyAf/7xWAJhVGFfb0H9zhLpdaxtF
/nWg8iY9P6sL8JZf7JPKKvQt7BckVzdiP1s/2T8legYcBppgBpTljLr5aaVOBqup
mWGkHWwe+jsfZkML/Ij73O5fr8hG+eOOwBNTm7JYdc1QuqOVnyn1um4FE376bF7t
wp5i+OP1qG1b+vWXCHZRv2A64UldCTgxVRnEFiJ7LywzVgmhH1kRGwjThIpuOo2t
6Qw+s0H18wnKb1vwp5/lX7f9y70YB2crZF095XpcMpMeKGpoEFE=
=kPRi
-----END PGP SIGNATURE-----


M
M
Mark H Weaver wrote on 17 Mar 2021 09:05
87eegei4r4.fsf@netris.org
Hi Léo,

Léo Le Bouter via Bug reports for GNU Guix <bug-guix@gnu.org> writes:

Toggle quote (11 lines)
> As outlined by:
> -
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=a01bfa7deed1d556fc75ab5588517442054bc5a9
> -
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=db87d6ddafd26c5ad657178cf7fdab524d05c522
>
> Two commits needed to be made to fix the issue both in the python2 and
> python3 variants, if the package-with-python2 and strip-python2-variant
> function could make so it inherits grafts it would make grafting python
> packages with python2 variants less "forget"-prone.

I've made an attempt to improve this situation in commit
1a265842e634656411bc7304c4648273f174f65e on the 'master' branch.
Especially note the changes made in guix/build-system/python.scm.

You might find that commit db87d6ddafd26c5ad657178cf7fdab524d05c522 is
no longer needed. Would you like to check and report back?

Thanks,
Mark
L
L
Léo Le Bouter wrote on 18 Mar 2021 11:31
3424709cd8d65e203414361f54fe635af4af9f9b.camel@zaclys.net
On Wed, 2021-03-17 at 04:05 -0400, Mark H Weaver wrote:
Toggle quote (11 lines)
> I've made an attempt to improve this situation in commit
> 1a265842e634656411bc7304c4648273f174f65e on the 'master' branch.
> Especially note the changes made in guix/build-system/python.scm.
>
> You might find that commit db87d6ddafd26c5ad657178cf7fdab524d05c522
> is
> no longer needed. Would you like to check and report back?
>
> Thanks,
> Mark

That worked, reverted python2-specific commit as
45695cc8a7b56b711baf664ceedaa66124d6de26.

Thank you!
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmBTK+4ACgkQRaix6GvN
EKagchAAlRdgP7usYLyVcxeGrh3isaf9Al/kdr0u6AmXwPAgh62JwVZRThs+CYsk
meMr6JnswONgu5s2/fyV0bzKZ7cY3zEviqF4Oobs8R2qh4px2kWXTx7VPd0h1fQ8
YdVzmYMLmXoRX7r5VanQnyKf2SCn3p1dJ/059vCohdiiujESk4d44RxGg6uhZtJJ
B5+K/t0mJSESSbWUUn7lotD0vTTgcunYbmIlRK7OD8NdMn3RBHdFhP7SIyLnifKc
3Y9hh7kel0Ec2XeC8VqRAMw++rD4ude7Y1307ffgOh0JtKTYEUFhzzKPYXvOPAVy
8Epei2JV/kKljsTuDBHSd+H/+skUsqlyzbP2pLzh6JTr6z/7s6+wWJ1K1R3NsFeK
0WV3zgMBC33K2XUHE6WY9Mrz3cTlZK2ZTo8zPHdnh4Ivfy17ZmZCOt8OK6ObxhDh
SMgspzzQKVq0x0HExh7IR7vdVLEG8Lkss1Y4UlY52Pk4LJsgEAzpW2ll6MhnEjkE
VkjII+TNxKhqMvHXqKVKccF5/TXLdVXMYNnrTIlPT2UH8UZs4yg6bm5RgiNtaHFE
aPvx+V9M+Yv04mHS/JA7HsHqgPbftzZ853AU9xLTqYMW+1k8GOgWFCPai4aXTqs4
V8iahvNtJfFp5oL8SnBb2a3m3ZFJY7AioTHnU925nB/ItzMUJmw=
=sWK1
-----END PGP SIGNATURE-----


Closed
?