[PATCH] gnu: Return appropriate defconfig for ppc64 (non-LE)

  • Done
  • quality assurance status badge
Details
2 participants
  • Carl Dong
  • Efraim Flashner
Owner
unassigned
Submitted by
Carl Dong
Severity
normal
C
C
Carl Dong wrote on 24 Feb 2021 04:03
(address . guix-patches@gnu.org)(name . Carl Dong)(address . contact@carldong.me)
20210224030312.458470-1-contact@carldong.me
* gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
---
gnu/packages/linux.scm | 1 +
1 file changed, 1 insertion(+)

Toggle diff (14 lines)
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index c87c5ffb09..30cbebf849 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -181,6 +181,7 @@
defconfig. Return the appropriate make target if applicable, otherwise return
\"defconfig\"."
(cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
+ ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
(else "defconfig")))
--
2.30.1
E
E
Efraim Flashner wrote on 24 Feb 2021 09:17
(name . Carl Dong)(address . contact@carldong.me)(address . 46741@debbugs.gnu.org)
YDYLlo8Q4bISvwDF@3900XT
On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
Toggle quote (16 lines)
> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
> ---
> gnu/packages/linux.scm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index c87c5ffb09..30cbebf849 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -181,6 +181,7 @@
> defconfig. Return the appropriate make target if applicable, otherwise return
> \"defconfig\"."
> (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
> + ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
> ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")

would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?

Toggle quote (9 lines)
> (else "defconfig")))
>
> --
> 2.30.1
>
>
>
>

--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmA2C5MACgkQQarn3Mo9
g1G4kQ/+JNv3wEkZHGBFucSnnSUx/lBnSb9mfBQ7SOaQV7unkqQAC5Rr7jK06EPL
QbWb39uO7ZAYgKx+06b+9yIZw0TqgERLnZUprUknM8c8IsgqQOFFRteapt6zxjjT
f1gtnc+uvdyFUK18DCycmlBjxIi4m1VoewmaaWlCEI+StnCOEKN4rJsEVWN+NUsj
FibA5WnA5yjlVd8vHfWzqKmw1IbsioBANUfMj17GkAIfmG/2iaB4QkuJbyhwRyMR
rvDCrqUtDl5tNgjYvwhTTTdzFbh3HWFF7Jx+tzKviJ5Djn9wK5mI08cwA3yP4kGS
bKJSYjDmZg/xliEqN15/VF6rMZ3myCQh6MUX4wtng4pM4liPzFU5czOZWqbFTdpc
MzqcXOnBahbCGXeCys7oENE6GxJ8pwaVgf8qmOZ2qcdduQFo3ssy98GVS8IHroH8
FBfiGe9r+8P32M23VHWYIpr/h5lQ08nVZbwg81VvmAl3nD5DQTKNqbrLfq+Q6gj2
sXcoiBM44E5B/JjNhxw56uqgvvvGd7Aq2JQTAA+eKJa5Pjd/vwJ6eWXXhwyff7Xz
fcX3B97zM+I4c4eLQbqO9s/yKC7Yby/n3ZQqvBIRW0ggxwkdLAXgb4pkSBMqwHQB
QGKODDYioZ2Ju3nSSXShwl+6i/bGtX3L1/qvr0G5dXdO5kKNmSA=
=MbNN
-----END PGP SIGNATURE-----


C
C
Carl Dong wrote on 24 Feb 2021 21:30
(name . Efraim Flashner)(address . efraim@flashner.co.il)(address . 46741@debbugs.gnu.org)
976A5887-0DF5-48A6-A071-D7B3A9A51186@carldong.me
Hmmm does string-prefix? accept regex? And if so perhaps it should be "powerpc64(le)?-“?

Carl Dong
contact@carldong.me
"I fight for the users"

Toggle quote (34 lines)
> On Feb 24, 2021, at 3:17 AM, Efraim Flashner <efraim@flashner.co.il> wrote:
>
> On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
>> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
>> ---
>> gnu/packages/linux.scm | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
>> index c87c5ffb09..30cbebf849 100644
>> --- a/gnu/packages/linux.scm
>> +++ b/gnu/packages/linux.scm
>> @@ -181,6 +181,7 @@
>> defconfig. Return the appropriate make target if applicable, otherwise return
>> \"defconfig\"."
>> (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
>> + ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
>> ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
>
> would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?
>
>> (else "defconfig")))
>>
>> --
>> 2.30.1
>>
>>
>>
>>
>
> --
> Efraim Flashner <efraim@flashner.co.il> ????? ?????
> GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted
Attachment: signature.asc
E
E
Efraim Flashner wrote on 25 Feb 2021 07:09
(name . Carl Dong)(address . contact@carldong.me)(address . 46741@debbugs.gnu.org)
YDc/I184Mpng5trZ@3900XT
On Wed, Feb 24, 2021 at 03:30:00PM -0500, Carl Dong wrote:
Toggle quote (2 lines)
> Hmmm does string-prefix? accept regex? And if so perhaps it should be "powerpc64(le)?-“?

Definitely what I meant to write

Toggle quote (36 lines)
>
> Carl Dong
> contact@carldong.me
> "I fight for the users"
>
> > On Feb 24, 2021, at 3:17 AM, Efraim Flashner <efraim@flashner.co.il> wrote:
> >
> > On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
> >> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
> >> ---
> >> gnu/packages/linux.scm | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> >> index c87c5ffb09..30cbebf849 100644
> >> --- a/gnu/packages/linux.scm
> >> +++ b/gnu/packages/linux.scm
> >> @@ -181,6 +181,7 @@
> >> defconfig. Return the appropriate make target if applicable, otherwise return
> >> \"defconfig\"."
> >> (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
> >> + ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
> >> ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
> >
> > would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?
> >
> >> (else "defconfig")))
> >>
> >> --
> >> 2.30.1
> >>
> >>
>



--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmA3PyAACgkQQarn3Mo9
g1GRyg//QWxIomtWXzOwexlNgqQBh2Rmub4/YQ1ZIl6vgxRHFsX17N03rzymbcbr
vTYjAp+oqbRP/o5RB8e5fn0/pX88IGCTJCY/0vNoQhjtYc4dab2pV5+PM61f01EN
CGprL9bfjHLc/G5N/mD4/GOMjuAwxNxo2RQ0LsfRUOe1k9MH8RWyOENS272zysSR
sRhAbM4Mrc1dWgt28HdeZ2fR9ZRThBx6VDfvs1XEVnxUrZYiwLfWPVwol4/rYR/9
qFAE0dUeaF6LPl6wc825a2/HLDZywRyOhjZYueUXs8PO1LGkJbqdgwgZx/ssmPvE
65e2A6GvoUemwH7aqggUB5rIO2vIl0SHEJol08GWCWtifYtbFNlydEj3pmGLWM7Z
s3RAJcVrB6ChEHfiNnWfKO9ZBLnq7nBIm/uMor7DaUODRUgXs6A86jcDASj98JUC
5UcVMfe/lU/b7ffVFZi1kpF73ReTaS8mCWeG+mpUzY/7vUyQmiVW4DjnpxrggfT5
66+pMM7FW05yG3TNzaZBks9eFcNLiKU7dwXCQ+xEUa1dbcpG3yiRbZtYAXVEnpAF
/fGgRqRaIo6pJmkQSxDkEnMnQ4lvKyGfPTMI98brsE88RNeLWlbxu9+89T0JtLZf
kIMFubZof3FgmczBUxRhL32SLdJM+qwTxMlg3hiq3/6wutjGJPE=
=Bume
-----END PGP SIGNATURE-----


E
E
Efraim Flashner wrote on 25 Feb 2021 11:22
(name . Carl Dong)(address . contact@carldong.me)(address . 46741@debbugs.gnu.org)
YDd6ap224a+1Ey/r@3900XT
I did some quick testing from the guile repl and it looks like it
doesn't take a regex. I have no preference between two entries for
'powerpc64-' and 'powerpc64le-' vs 'powerpc64'.

On Wed, Feb 24, 2021 at 03:30:00PM -0500, Carl Dong wrote:
Toggle quote (44 lines)
> Hmmm does string-prefix? accept regex? And if so perhaps it should be "powerpc64(le)?-“?
>
> Carl Dong
> contact@carldong.me
> "I fight for the users"
>
> > On Feb 24, 2021, at 3:17 AM, Efraim Flashner <efraim@flashner.co.il> wrote:
> >
> > On Tue, Feb 23, 2021 at 10:03:12PM -0500, Carl Dong wrote:
> >> * gnu/packages/linux.scm (system->defconfig): Add "powerpc64-" prefix.
> >> ---
> >> gnu/packages/linux.scm | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> >> index c87c5ffb09..30cbebf849 100644
> >> --- a/gnu/packages/linux.scm
> >> +++ b/gnu/packages/linux.scm
> >> @@ -181,6 +181,7 @@
> >> defconfig. Return the appropriate make target if applicable, otherwise return
> >> \"defconfig\"."
> >> (cond ((string-prefix? "powerpc-" system) "pmac32_defconfig")
> >> + ((string-prefix? "powerpc64-" system) "ppc64_defconfig")
> >> ((string-prefix? "powerpc64le-" system) "ppc64_defconfig")
> >
> > would it make more sense to change it to "powerpc64" or "powerpc(64)?-"?
> >
> >> (else "defconfig")))
> >>
> >> --
> >> 2.30.1
> >>
> >>
> >>
> >>
> >
> > --
> > Efraim Flashner <efraim@flashner.co.il> ????? ?????
> > GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
> > Confidentiality cannot be guaranteed on emails sent or received unencrypted
>



--
Efraim Flashner <efraim@flashner.co.il> ????? ?????
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmA3emcACgkQQarn3Mo9
g1HfgA//WBLCRZvbccSEndgbA2Qne5vFF3zqFgEsrAXlI17/zPJ6MgYpqAw0YTnR
ArNNCjX8Vk+avLV3CYAmROWS7lID3QA5vn4gzS1KSTL+uD6I2C2HFTzWGiAIiByD
34VEagtjQsG4DgsE7DzpIttw51VbwrOQgmCoEVj8+jFvXbxgLDnn/xmzWLhbqfMy
Dun4aY0o+2wKB2fmg3CCDqXgUz+fR9g45mWMksVhtjl5EOERhK4WI/jCzPh33yRg
1M+GsREqsPIfw4M9YPPk7YKI2sdf9ikpui87yB9Qc8b9aOJjLAUSLI128uVNoucj
RwEDP6aMEsuwR65DHlFzAyP1FGike5/sk7rdTMYz8lusUkkT5ep8rJfmh6xqj0cj
qjsbUnRj76+y103XuEB9BndJcLXA2AQ4Ehc6BqT/5nWR+oN3bNVJoKEQNl4StbRA
rVNOgA8OGthHybjoQgm/67ukjmx7EFVpV0YXewbhbeJgEjGIMjZitlkZAxS/BPKp
fGB21eW2/HgXL2rETKGsCuiod9/2GWztInzu1lEdd8VRA4AQv+YBRINhsH7pmxrz
4dFyrrioMLNWB5kA2M7V7riVL2Cuf9kYBbwBLThYFmtQKyvfiof01yL+Nc6wBgN7
YFyFZheSjv0JaqpYKGSEmNt1wC425YJn/lx965COQ/3eTbLTXyY=
=IP/o
-----END PGP SIGNATURE-----


C
C
Carl Dong wrote on 26 Feb 2021 18:03
Closing 46741
(address . control@debbugs.gnu.org)
69DB6805-7F1E-42C5-BA73-48DBF3845CD7@carldong.me
close 46741
?