Godot fails to start

  • Done
  • quality assurance status badge
Details
4 participants
  • Leo Prikler
  • Leo Famulari
  • Maxime Devos
  • Vinicius Monego
Owner
unassigned
Submitted by
Vinicius Monego
Severity
normal
V
V
Vinicius Monego wrote on 21 Feb 2021 00:35
(address . bug-guix@gnu.org)
87mtvygvmw.fsf@posteo.net
Godot fails to start with the following message:

Toggle quote (5 lines)
> Godot Engine v3.2.3.stable.custom_build - https://godotengine.org
> Input method doesn't support any styles
> free(): invalid pointer
> Aborted

I read it's a bug in libx11 version 1.6.10. It should be fixed by
upgrading to 1.6.12:

L
L
Leo Famulari wrote on 21 Feb 2021 01:37
(name . Vinicius Monego)(address . monego@posteo.net)(address . 46669@debbugs.gnu.org)
YDGrS5qYOlg641pX@jasmine.lan
On Sat, Feb 20, 2021 at 08:35:51PM -0300, Vinicius Monego wrote:
Toggle quote (13 lines)
>
> Godot fails to start with the following message:
>
> > Godot Engine v3.2.3.stable.custom_build - https://godotengine.org
> > Input method doesn't support any styles
> > free(): invalid pointer
> > Aborted
>
> I read it's a bug in libx11 version 1.6.10. It should be fixed by
> upgrading to 1.6.12:
>
> https://github.com/godotengine/godot/issues/40966

It will be while before libx11 is updated in Guix, because changing it
causes a huge number of packages to be rebuilt:

$ guix refresh --list-dependent libx11
Building the following 5793 packages would ensure 12459 dependent packages are rebuilt:

Is there anything we can change in godot, in the meantime?
M
M
Maxime Devos wrote on 21 Feb 2021 10:05
(address . 46669@debbugs.gnu.org)
30e0568aea1af4e8f01b13259c5befe836c5db65.camel@telenet.be
Hi,

On Sat, 2021-02-20 at 19:37 -0500, Leo Famulari wrote:
Toggle quote (9 lines)
> [...]
> It will be while before libx11 is updated in Guix, because changing it
> causes a huge number of packages to be rebuilt:
>
> $ guix refresh --list-dependent libx11
> Building the following 5793 packages would ensure 12459 dependent packages are rebuilt:
>
> Is there anything we can change in godot, in the meantime?

Is there any reason the ("libx11" ,libx11) cannot simply be replaced with
("libx11" ,libx11-fixed) in the package inputs for godot, where libx11 is
the updated libx11? Or alternatively, could the ‘grafts’ mechanism be used?
Or is that reserved for security updates?

Commenting out the line in
might also work.

Greetings,
Maxime
-----BEGIN PGP SIGNATURE-----

iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYDIichccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qcTAQCRLu9vWqdEm8N94zdwRfwuBavW
4FAvO/2jQxfk4TCDuAEA3k6IFjKN6aPDg48R0LEKvxSANp87QItqgrGd5SeL1Qk=
=kehq
-----END PGP SIGNATURE-----


L
L
Leo Prikler wrote on 21 Feb 2021 12:07
(address . 46669@debbugs.gnu.org)
2a3cd989164732f2191ebddc5d32bef6c013f550.camel@student.tugraz.at
Hi,

Am Sonntag, den 21.02.2021, 10:05 +0100 schrieb Maxime Devos:
Toggle quote (21 lines)
> Hi,
>
> On Sat, 2021-02-20 at 19:37 -0500, Leo Famulari wrote:
> > [...]
> > It will be while before libx11 is updated in Guix, because changing
> > it
> > causes a huge number of packages to be rebuilt:
> >
> > $ guix refresh --list-dependent libx11
> > Building the following 5793 packages would ensure 12459 dependent
> > packages are rebuilt:
> >
> > Is there anything we can change in godot, in the meantime?
>
> Is there any reason the ("libx11" ,libx11) cannot simply be replaced
> with
> ("libx11" ,libx11-fixed) in the package inputs for godot, where
> libx11 is
> the updated libx11? Or alternatively, could the ‘grafts’ mechanism
> be used?
> Or is that reserved for security updates?
In my opinion we should graft libx11, as long as it doesn't
inadvertently introduce any issues (which could however be grafted
again once they become noticed). The way the original bug was fixed
previously caused similar issues in other applications, such as Emacs,
and fixes in those applications usually result in disabling XIM
altogether. This means, that for applications, which don't ship their
own input mechanisms writing anything other than Latin becomes hard.

Regards,
Leo
L
L
Leo Famulari wrote on 24 Feb 2021 18:03
(name . Maxime Devos)(address . maximedevos@telenet.be)
YDaG1zMf0cae99BR@jasmine.lan
On Sun, Feb 21, 2021 at 10:05:53AM +0100, Maxime Devos wrote:
Toggle quote (5 lines)
> Is there any reason the ("libx11" ,libx11) cannot simply be replaced with
> ("libx11" ,libx11-fixed) in the package inputs for godot, where libx11 is
> the updated libx11? Or alternatively, could the ‘grafts’ mechanism be used?
> Or is that reserved for security updates?

It's reserved for security updates, and other very serious problems. An
incompatibility with a single package — especially something
non-critical like a game engine — does not qualify.

One reason to limit the use of grafts is that they can mask other
compatibility problems. For example, we grafted FreeType in October
2020. In December, we "ungrafted" it, and this revealed that the new
grafted version of FreeType had never worked with our VTK package. But,
since we were still compiling VTK with the old FreeType, and then
patching the compiled VTK objects to refer to the new FreeType, the
problem was hidden for several months:

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmA2htcACgkQJkb6MLrK
fwjycBAA4z+X9M5NJey3wCTGUWZja9jujt16EvejGmsOL1dpi429iJSrW9X6xAaZ
VeguVy2QmgiS8ruUHnQV0bhj6N12cEDknd8rJAdNymDvQrrCXW5dnavO812YKdTY
UDQlUavXCwASqAEO2ylogwKM5h2bGfI8F+az/I/fSjc3RjKytvP+TUah8sSErNlE
YsRx8rJRva68LKW66uCUF+AxsY65dyfS2KYXh4Yc5rOV9SJkK+x+9r2tFstO4rHN
JKr+gnt1BonwrBjIuwa9pcpmlk2z1ADjRyo3d0ZpFEYht5/1yB7RWTMHTrrz5vFF
wHS1Yw9naMiIBKjBusmhKd7l/ileuFToajIhTqWZiQ16oN+ebBQ6ulE+ef+92+pk
eVX+PUolQUcCQI1PBN7ddckDUtAPN+HdFfZ42cVa66AZdVn7Rz84GuaEYe6HVJlq
32odbLJcqwKCrfoQVVZm6fMRA0l988s4VTXM46nKNbgkpXn954NPXp9id1xVsI2a
GwZOK5SYdyx7MKmwl8MN5pDbaaPpl85m+B409YBIkHbDYrFjb2lI5cZfJjwluGyy
8/loDf+8NUFT+7IsbPM0cyKyG7pWhFDkyL/543I8WcGmiNjc86iyh3Is8D39WDVC
LkqD8QLiG7mwfA9RzonqgZ0AEYyyMqCvnKyJl0V0rzNN2V8yxNo=
=Bnyd
-----END PGP SIGNATURE-----


M
M
Maxime Devos wrote on 24 Feb 2021 18:47
(name . Leo Famulari)(address . leo@famulari.name)(address . 46669@debbugs.gnu.org)
b4f9366be3bc0201657970814b522c8f1b141d1b.camel@telenet.be
On Wed, 2021-02-24 at 12:03 -0500, Leo Famulari wrote:
Toggle quote (8 lines)
> [...]
>
> It's reserved for security updates, and other very serious problems. An
> incompatibility with a single package — especially something
> non-critical like a game engine — does not qualify.
>
> [...]

Thank you for your response! This makes Guix a little clearer to me.
-----BEGIN PGP SIGNATURE-----

iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYDaRTxccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qQLAPwKMBojmSDL0HdKNBYEND7nU2ao
q2gMMKe38g3CrL9olwD/eW+VOIb9BcItJJWYMekcF2No//C4mpx74LGEtA5LsQg=
=X65c
-----END PGP SIGNATURE-----


L
L
Leo Famulari wrote on 24 Feb 2021 21:02
(name . Maxime Devos)(address . maximedevos@telenet.be)(address . 46669@debbugs.gnu.org)
YDaw6fityn15NOy0@jasmine.lan
On Wed, Feb 24, 2021 at 06:47:59PM +0100, Maxime Devos wrote:
Toggle quote (11 lines)
> On Wed, 2021-02-24 at 12:03 -0500, Leo Famulari wrote:
> > [...]
> >
> > It's reserved for security updates, and other very serious problems. An
> > incompatibility with a single package — especially something
> > non-critical like a game engine — does not qualify.
> >
> > [...]
>
> Thank you for your response! This makes Guix a little clearer to me.

To elaborate some more... the problem is that the version of Godot we
package is not compatible with the version of libx11 we package, right?

If that's so, it's basically a normal situation. There are lots of
packages for which we must delay updates until the rest of the distro
can support them.
V
V
Vinicius Monego wrote on 18 Mar 2021 15:10
Godot fails to start
(address . 46669-done@debbugs.gnu.org)
874kh8r1qo.fsf@posteo.net
Hello,

libx11 was grafted in 826428ab5bd347954ee6be70a6a6596000f8583 due to a
CVE, and as a side effect Godot is now working fine. I will close this
issue then. Thanks for the comments!
Closed
?