[PATCH] Make assert-valid-graph public

  • Done
  • quality assurance status badge
Details
2 participants
  • Andrew Tropin
  • Ludovic Courtès
Owner
unassigned
Submitted by
Andrew Tropin
Severity
normal
A
A
Andrew Tropin wrote on 18 Feb 2021 19:19
(address . guix-patches@gnu.org)
CABrWRW1FuzoCk-Apu5JWgS9bhuLDD5beFzBuiqEpEmGF257Vbw@mail.gmail.com
I would like to reuse assert-valid-graph function for home-shepherd-service
for `guix home` I'm currently implementing. It seems reasonable to make this
function public instead of copying or reimplementing it.

--
Best regards,
Andrew Tropin
Attachment: 0001-gnu-services-shepherd-Make-assert-valid-graph-public.patch
A
A
Andrew Tropin wrote on 18 Feb 2021 19:24
Retitle
(address . control@debbugs.gnu.org)
CABrWRW1FA3r6ajjZnV7E05pD4Z9XxXPxHh_-ffVvXSrA7nau6g@mail.gmail.com
retitle 46619 [PATCH] Make assert-valid-graph public

--
Best regards,
Andrew Tropin
L
L
Ludovic Courtès wrote on 3 Mar 2021 14:22
Re: bug#46619: [PATCH] Make assert-valid-graph public
(name . Andrew Tropin)(address . andrew@trop.in)(address . 46619-done@debbugs.gnu.org)
87sg5cs76v.fsf_-_@gnu.org
Hi Andrew,

Andrew Tropin <andrew@trop.in> skribis:

Toggle quote (9 lines)
> From ffc244f5845996bf4b0365024ac866c86cef81df Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew@trop.in>
> Date: Thu, 18 Feb 2021 13:30:22 +0300
> Subject: [PATCH] gnu: services: shepherd: Make assert-valid-graph public
>
> ---
> gnu/services/shepherd.scm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

I added a commit log and pushed as
63bee8f0addc95c81426199c9fbf1d0bcf7f1450.

As mentioned on IRC, note that this kind of procedure doesn’t make for a
great API, which is why it’s usually kept private. Second, if a
procedure like this one doesn’t have any user in Guix proper, it could
well be removed or changed incompatibly, so beware.

In this case, I think it’s acceptable to make it public though.

Thanks and apologies for the delay!

Ludo’.
Closed
A
A
Andrew Tropin wrote on 3 Mar 2021 15:40
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 46619-done@debbugs.gnu.org)
CABrWRW3zt0egUUheaJNXZUPANKv9rkUXrKXKdfDz_TOPLczVWg@mail.gmail.com
Toggle quote (5 lines)
> As mentioned on IRC, note that this kind of procedure doesn\u2019t make for a
> great API, which is why it's usually kept private. Second, if a
> procedure like this one doesn't have any user in Guix proper, it could
> well be removed or changed incompatibly, so beware.

Took into account. Hope, it will be used by one small guix's module
someday) Plan to propose to include `guix home` in guix

Toggle quote (7 lines)
>
> In this case, I think it's acceptable to make it public though.
>
> Thanks and apologies for the delay!
>
> Ludo'.

Thank you for all your work!

--
Best regards,
Andrew Tropin
Closed
?