import: pypi: Clearify docstring of parse-requires.txt

  • Done
  • quality assurance status badge
Details
2 participants
  • Leo Famulari
  • Rovanion Luckey
Owner
unassigned
Submitted by
Rovanion Luckey
Severity
minor
R
R
Rovanion Luckey wrote on 29 Dec 2020 23:54
(address . guix-patches@gnu.org)
CAAaf0CAUiNFpjqXgEEz17eYVV01fnp65-ZN8kPmGARjSEsAeEA@mail.gmail.com
When mucking about the codebase trying to figure out if it would be
possible to automatically import a Python project using Guix preexisting
functions I found a docstring I thought could be more explicit than it was.
Attachment: file
From 338ac21c68e757d94b8375cb42345a82488f1708 Mon Sep 17 00:00:00 2001
From: Rovanion Luckey <rovanion.luckey@gmail.com>
Date: Thu, 26 Nov 2020 20:59:19 +0100
Subject: [PATCH 1/2] import: pypi: Clearify docstring of parse-requires.txt

---
guix/import/pypi.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Toggle diff (15 lines)
diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
index bf4dc50138..6731d50891 100644
--- a/guix/import/pypi.scm
+++ b/guix/import/pypi.scm
@@ -229,8 +229,8 @@ the input field."
'("test" "dev")))

(define (parse-requires.txt requires.txt)
- "Given REQUIRES.TXT, a Setuptools requires.txt file, return a list of lists
-of requirements.
+ "Given REQUIRES.TXT, a path to a Setuptools requires.txt file, return a list
+of lists of requirements.

The first list contains the required dependencies while the second the
optional test dependencies. Note that currently, optional, non-test
--
2.29.2
L
L
Leo Famulari wrote on 23 Apr 2021 06:02
(name . Rovanion Luckey)(address . rovanion.luckey@gmail.com)(address . 45542-done@debbugs.gnu.org)
YIJG8yoZWFFjeCo+@jasmine.lan
On Tue, Dec 29, 2020 at 11:54:11PM +0100, Rovanion Luckey wrote:
Toggle quote (9 lines)
> When mucking about the codebase trying to figure out if it would be
> possible to automatically import a Python project using Guix preexisting
> functions I found a docstring I thought could be more explicit than it was.

> From 338ac21c68e757d94b8375cb42345a82488f1708 Mon Sep 17 00:00:00 2001
> From: Rovanion Luckey <rovanion.luckey@gmail.com>
> Date: Thu, 26 Nov 2020 20:59:19 +0100
> Subject: [PATCH 1/2] import: pypi: Clearify docstring of parse-requires.txt

Thanks! Pushed as 9215f35b78e40d31ebece54fb7938aa321ec9130
Closed
?