[PATCH] gnu: git-open: Remove unnecessary propagated input.

DoneSubmitted by EuAndreh.
Details
2 participants
  • EuAndreh
  • Leo Famulari
Owner
unassigned
Severity
normal
E
E
EuAndreh wrote on 4 Dec 2020 21:53
(address . guix-patches@gnu.org)(name . EuAndreh)(address . eu@euandre.org)
20201204205332.28505-1-eu@euandre.org
* gnu/packages/version-control.scm (git-open): Stop propagating xdg-utilspackage, and replace the runtime dependency by wrapping xdg-utils in thederivation. Also use copy-build-system instead of trivial-build-system.--- gnu/packages/version-control.scm | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-)
Toggle diff (47 lines)diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scmindex a8e6d2c4b9..eec57b3b6d 100644--- a/gnu/packages/version-control.scm+++ b/gnu/packages/version-control.scm@@ -55,6 +55,7 @@ #:use-module (guix git-download) #:use-module (guix hg-download) #:use-module (guix build-system cmake)+ #:use-module (guix build-system copy) #:use-module (guix build-system gnu) #:use-module (guix build-system go) #:use-module (guix build-system perl)@@ -2733,20 +2734,20 @@ file contents on a remote server.") (file-name (git-file-name name version)) (sha256 (base32 "11n46bngvca5wbdbfcxzjhjbfdbad7sgf7h9gf956cb1q8swsdm0"))))- (build-system trivial-build-system)- (propagated-inputs+ (build-system copy-build-system)+ (inputs `(("xdg-utils" ,xdg-utils))) (arguments- `(#:modules ((guix build utils))- #:builder- (begin- (use-modules (guix build utils))- (let ((source (assoc-ref %build-inputs "source"))- (out (assoc-ref %outputs "out")))- (mkdir-p (string-append out "/bin"))- (copy-file (string-append source "/git-open")- (string-append out "/bin/git-open"))- #t))))+ `(#:phases+ (modify-phases %standard-phases+ (add-after 'install 'wrap-program+ (lambda* (#:key outputs inputs #:allow-other-keys)+ (let ((out (assoc-ref outputs "out"))+ (xdg-utils (assoc-ref inputs "xdg-utils")))+ (wrap-program (string-append out "/bin/git-open")+ `("PATH" ":" prefix (,(string-append xdg-utils "/bin"))))))))+ #:install-plan+ '(("git-open" "bin/git-open")))) (home-page "https://github.com/paulirish/git-open") (synopsis "Open a Git repository's homepage from the command-line") (description-- 2.29.2
L
L
Leo Famulari wrote on 5 Dec 2020 05:42
(name . EuAndreh via Guix-patches via)(address . guix-patches@gnu.org)
X8sPx50mJ7Q/gSaP@jasmine.lan
On Fri, Dec 04, 2020 at 05:53:32PM -0300, EuAndreh via Guix-patches via wrote:
Toggle quote (4 lines)> * gnu/packages/version-control.scm (git-open): Stop propagating xdg-utils> package, and replace the runtime dependency by wrapping xdg-utils in the> derivation. Also use copy-build-system instead of trivial-build-system.
Thanks! I rewrote the commit to be more idiomatic and pushed as4cf3734c56d669ee2d78082e5d7c4d0a58e0f800.
About the commit message, we write them in the GNU ChangeLog format:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html
Basically, we describe changes to the code, organized by file andvariable. The linked chapter in the GNU coding manual is instructivewhen combined with `git log` of the Guix repo.
E
E
EuAndreh wrote on 5 Dec 2020 12:19
(address . 45043-done@debbugs.gnu.org)
87v9dgmrey.fsf@euandre.org
Leo Famulari <leo@famulari.name> writes:
Toggle quote (11 lines)> Thanks! I rewrote the commit to be more idiomatic and pushed as> 4cf3734c56d669ee2d78082e5d7c4d0a58e0f800.>> About the commit message, we write them in the GNU ChangeLog format:>> https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html>> Basically, we describe changes to the code, organized by file and> variable. The linked chapter in the GNU coding manual is instructive> when combined with `git log` of the Guix repo.
Hmm, makes sense. Thanks for the tip. I see my commit message was onlypartially compliant.
Closed
?
Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send email to 45043@debbugs.gnu.org