guix bash-completion -> add --profile to "package" completion

  • Done
  • quality assurance status badge
Details
2 participants
  • Fulbert
  • Ludovic Courtès
Owner
unassigned
Submitted by
Fulbert
Severity
normal
F
F
Fulbert wrote on 16 Sep 2020 20:48
(address . guix-patches@gnu.org)
20200916184855.GA17918@bluewin.ch
Hello!

I'm using a modified guix bash-completion as the upstream does not
complete for --profile for the "package" command.

… there probably is a good reason for this, but just in case…

Best regards and thanks for Guix,
Fulbert
From a8eb589640d1fc1757b3d91da73eea1c3e6fe9ba Mon Sep 17 00:00:00 2001
From: Fulbert <fulbert@bluewin.ch>
Date: Wed, 16 Sep 2020 18:10:56 +0200
Subject: [PATCH] =?UTF-8?q?=20Sur=20la=20branche=20for-patch=20=09modifi?=
=?UTF-8?q?=C3=A9=C2=A0:=20=20=20=20=20=20=20=20=20guix?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
etc/completion/bash/guix | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/etc/completion/bash/guix b/etc/completion/bash/guix
index 98d20484f7..aa217bd318 100644
--- a/etc/completion/bash/guix
+++ b/etc/completion/bash/guix
@@ -181,7 +181,7 @@ _guix_complete ()
*)
if _guix_is_command "package"
then
- if _guix_is_dash_L || _guix_is_dash_m
+ if _guix_is_dash_L || _guix_is_dash_m || _guix_is_dash_p
then
_guix_complete_file
elif _guix_is_removing
--
2.20.1
L
L
Ludovic Courtès wrote on 21 Sep 2020 23:36
(name . Fulbert)(address . fulbert@bluewin.ch)(address . 43456-done@debbugs.gnu.org)
87blhyizhf.fsf@gnu.org
Hi Fulbert,

Fulbert <fulbert@bluewin.ch> skribis:

Toggle quote (5 lines)
> I'm using a modified guix bash-completion as the upstream does not
> complete for --profile for the "package" command.
>
> & there probably is a good reason for this, but just in case&

No, there was no good reason. :-)

Toggle quote (12 lines)
>>From a8eb589640d1fc1757b3d91da73eea1c3e6fe9ba Mon Sep 17 00:00:00 2001
> From: Fulbert <fulbert@bluewin.ch>
> Date: Wed, 16 Sep 2020 18:10:56 +0200
> Subject: [PATCH] =?UTF-8?q?=20Sur=20la=20branche=20for-patch=20=09modifi?=
> =?UTF-8?q?=C3=A9=C2=A0:=20=20=20=20=20=20=20=20=20guix?=
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> ---
> etc/completion/bash/guix | 2 +-

I tweaked the commit message to match our conventions and applied it.

Thank you!

Ludo’.
Closed
?