[PATCH] gnu: Add ripmime.

  • Done
  • quality assurance status badge
Details
2 participants
  • Ludovic Courtès
  • Sébastien Lerique
Owner
unassigned
Submitted by
Sébastien Lerique
Severity
normal
Merged with
S
S
Sébastien Lerique wrote on 11 Sep 2020 15:54
(address . guix-patches@gnu.org)
87wo10fmgx.fsf@eauchat.org
* gnu/packages/mail.scm (ripmime): New variable.
---
gnu/packages/mail.scm | 44
+++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)

Toggle diff (62 lines)
diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 7af7e8a8d7..48e9a11522 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -627,6 +627,50 @@ Extension (MIME).")
(base32
"0slzlzcr3h8jikpz5a5amqd0csqh2m40gdk910ws2hnaf5m6hjbi"))))))

+(define-public ripmime
+ (let ((commit "a556ffe08d620602475c976732e8e1a82f3169e9")
+ (revision "1"))
+ (package
+ (name "ripmime")
+ (version (git-version "1.4.0.10" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/inflex/ripMIME")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+
"1z8ar8flvkd9q3ax4x28sj5pyq8ykk5pq249y967lj2406lxparh"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ ;; Source has no configure script
+ (delete 'configure)
+ ;; Buildcodes make the build non-reproducible; remove
them
+ (add-after 'unpack 'strip-buildcodes
+ (lambda _
+ (substitute* "generate-buildcodes.sh"
+ (("`date \\+%s`") "0")
+ (("`date`") "0")
+ (("`uname -a`") "Guix"))))
+ ;; https://github.com/inflex/ripMIME/pull/16 makes
`mkdir-p-bin-man unnecessary
+ (add-before 'install 'mkdir-p-bin-man
+ (lambda _
+ (mkdir-p (string-append (assoc-ref %outputs "out")
"/bin"))
+ (mkdir-p (string-append (assoc-ref %outputs "out")
"/man")))))
+ ;; Makefile has no tests
+ #:tests? #f
+ #:make-flags (list (string-append "LOCATION=" (assoc-ref
%outputs "out"))
+ "CC=gcc")))
+ (synopsis "Extract attachments from MIME-encoded email")
+ (description
+ "ripMIME is a small program which is used to extract the
attached files
+out of a MIME-encoded email package.")
+ (home-page "https://github.com/inflex/ripMIME")
+ (license license:bsd-3))))
+
(define-public bogofilter
(package
(name "bogofilter")
--
2.28.0

---

Hello Guix!

This is my first contribution -- please let me know if things
should be adapted!

Cheers,
Sébastien
L
L
Ludovic Courtès wrote on 13 Sep 2020 23:16
(name . Sébastien Lerique)(address . sl@eauchat.org)(address . 43338@debbugs.gnu.org)
87lfhd9y32.fsf@gnu.org
Hello Sébastien!

Sébastien Lerique <sl@eauchat.org> skribis:

Toggle quote (6 lines)
> * gnu/packages/mail.scm (ripmime): New variable.
> ---
> gnu/packages/mail.scm | 44
> +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)

Looks like your mail client mangled the patch. Could you send it as an
attachment or using ‘git send-email’? (See https://git-send-email.io/
for a tutorial.)

Toggle quote (15 lines)
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index 7af7e8a8d7..48e9a11522 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -627,6 +627,50 @@ Extension (MIME).")
> (base32
> "0slzlzcr3h8jikpz5a5amqd0csqh2m40gdk910ws2hnaf5m6hjbi"))))))
>
> +(define-public ripmime
> + (let ((commit "a556ffe08d620602475c976732e8e1a82f3169e9")
> + (revision "1"))
> + (package
> + (name "ripmime")
> + (version (git-version "1.4.0.10" revision commit))

In general we provide released versions, unless there’s a good reason to
pick a development snapshot. If it falls in this category, could you
add a short comment above the commit ID explaining why?

Toggle quote (7 lines)
> + (add-after 'unpack 'strip-buildcodes
> + (lambda _
> + (substitute* "generate-buildcodes.sh"
> + (("`date \\+%s`") "0")
> + (("`date`") "0")
> + (("`uname -a`") "Guix"))))

Please return #t at the end of the phase (it’s a convention).

Toggle quote (9 lines)
> `mkdir-p-bin-man unnecessary
> + (add-before 'install 'mkdir-p-bin-man
> + (lambda _
> + (mkdir-p (string-append (assoc-ref %outputs "out")
> "/bin"))
> + (mkdir-p (string-append (assoc-ref %outputs "out")
> "/man")))))

Likewise.

Toggle quote (5 lines)
> + (synopsis "Extract attachments from MIME-encoded email")
> + (description
> + "ripMIME is a small program which is used to extract the
> attached files

s/which is used//g

Toggle quote (2 lines)
> +out of a MIME-encoded email package.")

Could you send an updated patch?

Thanks for this first contribution! :-)

Ludo’.
S
S
Sébastien Lerique wrote on 14 Sep 2020 10:59
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 43338@debbugs.gnu.org)
87wo0wzqcc.fsf@eauchat.org
Hello,

On 13 Sep 2020 at 23:16, Ludovic Courtès <ludo@gnu.org> wrote:

Toggle quote (2 lines)
> Could you send an updated patch?

Thanks for the quick (and newcomer-friendly) feedback! The v2 I
just submitted hopefully fixes all the issues.

Toggle quote (2 lines)
> Thanks for this first contribution! :-)

Pretty excited as it's my first packaging experience anywhere.

Sébastien
L
L
Ludovic Courtès wrote on 14 Sep 2020 21:40
control message for bug #43338
(address . control@debbugs.gnu.org)
87363kb0zs.fsf@gnu.org
merge 43338 43399
quit
?