[PATCH] doc: Add note to 'udisks-service'.

DoneSubmitted by Brice Waegeneire.
Details
2 participants
  • Brice Waegeneire
  • Ludovic Courtès
Owner
unassigned
Severity
normal
B
B
Brice Waegeneire wrote on 3 Jun 2020 13:52
(address . guix-patches@gnu.org)
20200603115218.20513-1-brice@waegenei.re
* doc/guix.texi (Desktop Services): Specify how to add file-systems
utilities to 'udisks-service'.
---
doc/guix.texi | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

Toggle diff (24 lines)
diff --git a/doc/guix.texi b/doc/guix.texi
index 8335373145..12ed7923b3 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -16631,9 +16631,14 @@ Possible values are:
 
 @deffn {Scheme Procedure} udisks-service [#:udisks @var{udisks}]
 Return a service for @uref{https://udisks.freedesktop.org/docs/latest/,
-UDisks}, a @dfn{disk management} daemon that provides user interfaces with
-notifications and ways to mount/unmount disks.  Programs that talk to UDisks
-include the @command{udisksctl} command, part of UDisks, and GNOME Disks.
+UDisks}, a @dfn{disk management} daemon that provides user interfaces
+with notifications and ways to mount/unmount disks.  Programs that talk
+to UDisks include the @command{udisksctl} command, part of UDisks, and
+GNOME Disks.  Note that Udisks rely on the @command{mount} command, so
+it will only be able to use the file-system utilities which are
+installed in the system profile.  For example if you want to be able to
+mount NTFS file-systems in read and write fashion, you'll need to have
+@code{ntfs-3g} installed system-wide.
 @end deffn
 
 @deffn {Scheme Variable} colord-service-type
-- 
2.26.2
L
L
Ludovic Courtès wrote on 9 Jun 2020 09:39
(name . Brice Waegeneire)(address . brice@waegenei.re)(address . 41685@debbugs.gnu.org)
87lfkwofge.fsf@gnu.org
Hi!

Brice Waegeneire <brice@waegenei.re> skribis:

Toggle quote (3 lines)
> * doc/guix.texi (Desktop Services): Specify how to add file-systems
> utilities to 'udisks-service'.

[...]

Toggle quote (5 lines)
> +UDisks}, a @dfn{disk management} daemon that provides user interfaces
> +with notifications and ways to mount/unmount disks. Programs that talk
> +to UDisks include the @command{udisksctl} command, part of UDisks, and
> +GNOME Disks. Note that Udisks rely on the @command{mount} command, so

s/rely/relies/

Toggle quote (2 lines)
> +it will only be able to use the file-system utilities which are

s/which are//

Toggle quote (5 lines)
> +installed in the system profile. For example if you want to be able to
> +mount NTFS file-systems in read and write fashion, you'll need to have
> +@code{ntfs-3g} installed system-wide.
> @end deffn

LGTM!

Thanks,
Ludo’.
B
B
Brice Waegeneire wrote on 9 Jun 2020 10:35
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 41685-done@debbugs.gnu.org)
87eeqohc0w.fsf@waegenei.re
Hi Ludo',

Thank you for the review.

Ludovic Courtès <ludo@gnu.org> writes:

Toggle quote (31 lines)
> Hi!
>
> Brice Waegeneire <brice@waegenei.re> skribis:
>
>> * doc/guix.texi (Desktop Services): Specify how to add file-systems
>> utilities to 'udisks-service'.
>
> [...]
>
>> +UDisks}, a @dfn{disk management} daemon that provides user interfaces
>> +with notifications and ways to mount/unmount disks. Programs that talk
>> +to UDisks include the @command{udisksctl} command, part of UDisks, and
>> +GNOME Disks. Note that Udisks rely on the @command{mount} command, so
>
> s/rely/relies/
>
>> +it will only be able to use the file-system utilities which are
>
> s/which are//
>
>> +installed in the system profile. For example if you want to be able to
>> +mount NTFS file-systems in read and write fashion, you'll need to have
>> +@code{ntfs-3g} installed system-wide.
>> @end deffn
>
> LGTM!
>
> Thanks,
> Ludo’.
>

Pushed as 1b5d26c967b17b635c88a094e010cd42a9afb220 with the 2 fixes you
suggested.

-Brice
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 41685@debbugs.gnu.org