[PATCH 0/2 staging] dconf: Enable tests.

DoneSubmitted by Brice Waegeneire.
Details
2 participants
  • Brice Waegeneire
  • Marius Bakke
Owner
unassigned
Severity
normal
B
B
Brice Waegeneire wrote on 22 May 2020 10:15
Download
[PATCH 0/2] dconf: Enable tests.
(address . guix-patches@gnu.org)
20200522081514.29875-1-brice@waegenei.re
Download
Brice Waegeneire (2):
gnu: dconf: Appease 'guix lint'.
gnu: dconf: Enable tests.

gnu/packages/gnome.scm | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

--
2.26.2
B
B
Brice Waegeneire wrote on 22 May 2020 10:21
Download
[PATCH 2/2] gnu: dconf: Enable tests.
(address . guix-patches@gnu.org)
20200522082154.1376-2-brice@waegenei.re
Download
* gnu/packages/gnome.scm (dconf)[arguments]: Enable tests.
---
gnu/packages/gnome.scm | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

Toggle diff (17 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index e9d2965f70..803ac8fe5a 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -3432,9 +3432,7 @@ and RDP protocols.")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (arguments
-     `(#:tests? #f ; To contact dbus it needs to load /var/lib/dbus/machine-id
-                   ; or /etc/machine-id.
-       #:glib-or-gtk? #t
+     `(#:glib-or-gtk? #t
        #:configure-flags '("-Denable-gtk-doc=true")))
     (home-page "https://developer.gnome.org/dconf/")
     (synopsis "Low-level GNOME configuration system")
-- 
2.26.2
B
B
Brice Waegeneire wrote on 22 May 2020 10:21
Download
[PATCH 1/2] gnu: dconf: Appease 'guix lint'.
(address . guix-patches@gnu.org)
20200522082154.1376-1-brice@waegenei.re
Download
* gnu/packages/gnome.scm (dconf)[homepage]: Avoid permanent redirect.
---
gnu/packages/gnome.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index ed668c280b..e9d2965f70 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -3436,7 +3436,7 @@ and RDP protocols.")
                    ; or /etc/machine-id.
        #:glib-or-gtk? #t
        #:configure-flags '("-Denable-gtk-doc=true")))
-    (home-page "https://developer.gnome.org/dconf")
+    (home-page "https://developer.gnome.org/dconf/")
     (synopsis "Low-level GNOME configuration system")
     (description "Dconf is a low-level configuration system.  Its main purpose
 is to provide a backend to GSettings on platforms that don't already have
-- 
2.26.2
B
B
Brice Waegeneire wrote on 22 May 2020 10:46
Download
specify merge branch for #41446
(address . control@debbugs.gnu.org)
ddc0c24011f2b117e17c26b75b5941ad@waegenei.re
Download
# Merge it on staging: more than 400 packages will need to be rebuilt
retitle 41446 [PATCH 0/2 staging] dconf: Enable tests.
quit
M
M
Marius Bakke wrote on 23 May 2020 19:42
Download
Re: [bug#41446] [PATCH 2/2] gnu: dconf: Enable tests.
878shi8s5a.fsf@devup.no
Download
Brice Waegeneire <brice@waegenei.re> writes:

Toggle quote (2 lines)
> * gnu/packages/gnome.scm (dconf)[arguments]: Enable tests.

dconf has over 400 dependent packages, so this should wait for the next
'staging' branch. Can you fork off the current branch and push a
'staging-next' so it does not get forgotten?

Otherwise LGTM. The other patch can go directly on 'master'.

Thanks!
Download
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7JYIEACgkQoqBt8qM6
VPrWwAf/XY3rj50QgQ32VGzoSePNGWaJmy51bCh6byx1aSWC0CVrrdVnFrTEmFvs
ObYuafyL5i/gMKUIrz8EMeSmQClMkNueKndKBmI8Z0h7Mu7hDXaew++50kHtHXd7
yzeaNXg0R0PkuAyTYyCyTy0ncshpLqMD2hiGRaMR+NizynCIjFc63npKrLeTrkKP
890bGvEUpSEi8lgMeA/Qe3SxR9QrMcmFjOpQK6NZyu/ClT3rE4uGBYna44sEDvwa
H8tiiD00IgrF5A//Ln1RPloLnOiMjharFhHwkKvnim9hRjG+J927RI+51tfq2nqO
uSJhL3gXUyunynAssxW+U1Rg+ZhpMg==
=rzgc
-----END PGP SIGNATURE-----

B
B
Brice Waegeneire wrote on 23 May 2020 22:05
Download
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 41446-done@debbugs.gnu.org)
deeb83679634eb2af71b9964387a6f3b@waegenei.re
Download
On 2020-05-23 17:42, Marius Bakke wrote:
Toggle quote (12 lines)
> Brice Waegeneire <brice@waegenei.re> writes:
>
>> * gnu/packages/gnome.scm (dconf)[arguments]: Enable tests.
>
> dconf has over 400 dependent packages, so this should wait for the next
> 'staging' branch. Can you fork off the current branch and push a
> 'staging-next' so it does not get forgotten?
>
> Otherwise LGTM. The other patch can go directly on 'master'.
>
> Thanks!

Pushed the first patch on master as
79d7b5277f803d474f8934b1680ce598c9c27e2d.
And the second on staging-next as
27106f465382fc95f0f19e1cd3147cab5716a173.
Closed
?
Your comment

This issue is archived.

To comment on this conversation send email to 41446@debbugs.gnu.org