[PATCH] gnu: add glabels

DoneSubmitted by Vinicius Monego.
Details
3 participants
  • Ludovic Courtès
  • Nicolas Goaziou
  • Vinicius Monego
Owner
unassigned
Severity
normal
V
V
Vinicius Monego wrote on 18 May 2020 23:11
Download
(address . guix-patches@gnu.org)(name . Vinicius Monego)(address . monego@posteo.net)
20200518211144.64526-1-monego@posteo.net
Download
---
gnu/packages/gnome.scm | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)

Toggle diff (49 lines)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index d5a2032ccf..2f258089be 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2020 raingloom <raingloom@riseup.net>
 ;;; Copyright © 2020 Nicolas Goaziou <mail@nicolasgoaziou.fr>
 ;;; Copyright © 2020 Naga Malleswari <nagamalli@riseup.net>
+;;; Copyright © 2020 Vinicius Monego <monego@posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -10216,3 +10217,34 @@ communicating using the GVariant serialization format instead of JSON when
 both peers support it.  You might want that when communicating on a single
 host to avoid parser overhead and memory-allocator fragmentation.")
     (license license:lgpl2.1+)))
+
+(define-public glabels
+  (package
+   (name "glabels")
+   (version "3.4.1")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version)  "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "0f2rki8i27pkd9r0gz03cdl1g4vnmvp0j49nhxqn275vi8lmgr0q"))))
+   (build-system glib-or-gtk-build-system)
+   (native-inputs
+    `(("pkg-config" ,pkg-config)
+      ("glib:bin" ,glib "bin")
+      ("gettext" ,gettext-minimal)
+      ("intltool" ,intltool)
+      ("itstool" ,itstool)))
+   (inputs
+    `(("gtk+" ,gtk+)
+      ("librsvg" ,librsvg)
+      ("libxml2" ,libxml2)))
+   (home-page "http://glabels.org/")
+   (synopsis "Program for creating labels and business cards.")
+   (description
+    "gLabels is a program for creating labels and business cards.  It is
+designed to work with various laser/ink-jet peel-off label and business
+card sheets that you’ll find at most office supply stores.")
+   (license license:gpl3+)))
-- 
2.20.1
N
N
Nicolas Goaziou wrote on 20 May 2020 20:07
Download
(name . Vinicius Monego)(address . monego@posteo.net)(address . 41380@debbugs.gnu.org)
87zha2fpk1.fsf@nicolasgoaziou.fr
Download
Hello,

Vinicius Monego <monego@posteo.net> writes:

Toggle quote (5 lines)
> ---
> gnu/packages/gnome.scm | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>

Thank you! Could you use "git format-patch" and provide a commit message
in line with what we usually do for new packages? You may want to check
the commits in the repository to get an idea.

Toggle quote (6 lines)
> +(define-public glabels
> + (package
> + (name "glabels")
> + (version "3.4.1")
> + (source (origin

Nitpick: Could you move "(origin" on the next line?

Toggle quote (5 lines)
> + (method url-fetch)
> + (uri (string-append "mirror://gnome/sources/" name "/"
> + (version-major+minor version) "/"
> + name "-" version ".tar.xz"))

Could you replace "name" with "glabels"? We do not hard-code names
anymore in package definitions.

Toggle quote (4 lines)
> + (sha256
> + (base32
> + "0f2rki8i27pkd9r0gz03cdl1g4vnmvp0j49nhxqn275vi8lmgr0q"))))

Nitpick: Could you put the string on the same line as `base32'?

Toggle quote (8 lines)
> + (build-system glib-or-gtk-build-system)
> + (native-inputs
> + `(("pkg-config" ,pkg-config)
> + ("glib:bin" ,glib "bin")
> + ("gettext" ,gettext-minimal)
> + ("intltool" ,intltool)
> + ("itstool" ,itstool)))

Could you re-order alphabetically the native inputs?

Toggle quote (6 lines)
> + (inputs
> + `(("gtk+" ,gtk+)
> + ("librsvg" ,librsvg)
> + ("libxml2" ,libxml2)))
> + (home-page "http://glabels.org/")

The home-page should be using https

Toggle quote (2 lines)
> + (synopsis "Program for creating labels and business cards.")

Synopsis shouldn't end with a full stop. You may want to lint your
package definition with "guix lint".

Toggle quote (6 lines)
> + (description
> + "gLabels is a program for creating labels and business cards. It is
> +designed to work with various laser/ink-jet peel-off label and business
> +card sheets that you’ll find at most office supply stores.")
> + (license license:gpl3+)))

Could you send an updated patch?

Regards,

--
Nicolas Goaziou
L
L
Ludovic Courtès wrote on 3 Jun 2020 17:52
Download
control message for bug #41380
(address . control@debbugs.gnu.org)
87img8kuyt.fsf@gnu.org
Download
tags 41380 fixed
close 41380
quit
?
Your comment

This issue is archived.

To comment on this conversation send email to 41380@debbugs.gnu.org