[PATCH] doc: Specify the branch name in the title of a patch.

  • Done
  • quality assurance status badge
Details
2 participants
  • Brice Waegeneire
  • Leo Famulari
Owner
unassigned
Submitted by
Brice Waegeneire
Severity
normal
B
B
Brice Waegeneire wrote on 11 May 2020 20:42
(address . guix-patches@gnu.org)
20200511184254.21231-1-brice@waegenei.re
* doc/contributing.texi (Submitting Patches): Add branch name in the
title of a patch if different than master.
---
doc/contributing.texi | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)

Toggle diff (27 lines)
diff --git a/doc/contributing.texi b/doc/contributing.texi
index 9583120742..618d9008cc 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -1083,12 +1083,14 @@ guix pull --url=/path/to/your/checkout --profile=/tmp/guix.master
@end enumerate
When posting a patch to the mailing list, use @samp{[PATCH] @dots{}} as
-a subject. You may use your email client or the @command{git
-send-email} command (@pxref{Sending a Patch Series}). We prefer to get
-patches in plain text messages, either inline or as MIME attachments.
-You are advised to pay attention if your email client changes anything
-like line breaks or indentation which could potentially break the
-patches.
+a subject, if your patch is to be applied on a branch other than master,
+say @code{core-updates}, specify it in the subject like @samp{[PATCH
+core-updates] @dots{}}. You may use your email client or the
+@command{git send-email} command (@pxref{Sending a Patch Series}). We
+prefer to get patches in plain text messages, either inline or as MIME
+attachments. You are advised to pay attention if your email client
+changes anything like line breaks or indentation which could potentially
+break the patches.
When a bug is resolved, please close the thread by sending an email to
@email{@var{NNN}-done@@debbugs.gnu.org}.
--
2.26.2
L
L
Leo Famulari wrote on 11 May 2020 21:43
(name . Brice Waegeneire)(address . brice@waegenei.re)(address . 41191@debbugs.gnu.org)
20200511194341.GA15164@jasmine.lan
On Mon, May 11, 2020 at 08:42:54PM +0200, Brice Waegeneire wrote:
Toggle quote (3 lines)
> +a subject, if your patch is to be applied on a branch other than master,
> +say @code{core-updates}, specify it in the subject like @samp{[PATCH

Wrap both master and core-updates in @code? Or neither?

Otherwise LGTM!
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAl65quYACgkQJkb6MLrK
fwh5tBAAoX6sYFU1bSp7kDvCOtv6p2GI6MwJWRJ8HgWQqqoOBCT8FGMpurwQfHZ5
ewp28AHv4kEY0j/pcnVo8FKyE3jgu0TlVnR5A1rIUsygoq+mGCn8ZQV3OcXL7oNm
p2rDLAdVK2mQo3Q42CWxWXny16HsQRzJIC8xMOchtznv4j20Qsq+svPJzD2Mt2R6
VY6vCbiKE0FtY9TAouhqaViQcehWrBCgNJG9MfuMGEvwOkNQrGgc5ZtSF4PYzY2d
gGJhGcqkytqTgpwpZZA5p4Q4RWmNgXwip7vc1m6qomCaVkG/5agqtkWxi0eR7+YV
P1Py2rRW12q04XsdDw/zJEQthhd+AKvHX/GwMj/UeDThM5orQ6nLrKWIMOSAKadM
uoX14S4nfuJ/7VWSdq3sZFO9L2FYyCPsaTboP6Bw10JYPnPIFoOnQQDcvYvWztUW
8i6IgN4dyF4EVRSeMw9LgDioRtOrSr93vxP1iHOW1BeqR7SqYb39ZXSYgDw2RFEJ
XrmbR21NEZWZ2qiO0Z5QbSdGxGCKnPZFBWizDL31f79M+cJEcJMEHB43TvZAcdCh
unxRTIjI4ux5bvhqcWHmD2zR1Pm/WtP3ZMqaZbev+8rN86HYibzemq6kkDj7e/Dn
eVNgZxJVlJJO+yPVGgHDHXdD5cYZVLFn1h6a7eY5zqpZZMhdMn0=
=AcRw
-----END PGP SIGNATURE-----


B
B
Brice Waegeneire wrote on 12 May 2020 22:12
(name . Leo Famulari)(address . leo@famulari.name)(address . 41191-done@debbugs.gnu.org)
f179ae68794bd69fe8e46e4576c2a7bf@waegenei.re
On 2020-05-11 19:43, Leo Famulari wrote:
Toggle quote (9 lines)
> On Mon, May 11, 2020 at 08:42:54PM +0200, Brice Waegeneire wrote:
>> +a subject, if your patch is to be applied on a branch other than
>> master,
>> +say @code{core-updates}, specify it in the subject like @samp{[PATCH
>
> Wrap both master and core-updates in @code? Or neither?
>
> Otherwise LGTM!

I have wrapped master in @code, pushed as
a1891cbffb9909d4a74faf242f28f0f2e998eb2f.

Thank you for the review Leo!
Closed
?