[PATCH core-updates] gnu: libjpeg-turbo: Fix building on powerpc.

Efraim Flashner wrote on 27 Apr 2020 12:36

Recipients:(address . guix-patches@gnu.org)(name . Efraim Flashner)(address . efraim@flashner.co.il)

Message-ID:20200427103618.5696-1-efraim@flashner.co.il

* gnu/packages/image.scm (libjpeg-turbo)[arguments]: Add configure-flagsspecific to powerpc to fix building and cross-building.--- gnu/packages/image.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)

Toggle diff (36 lines)diff --git a/gnu/packages/image.scm b/gnu/packages/image.scmindex c900bd0eb9..96e207e940 100644--- a/gnu/packages/image.scm+++ b/gnu/packages/image.scm@@ -8,7 +8,7 @@ ;;; Copyright © 2015 Amirouche Boubekki <amirouche@hypermove.net> ;;; Copyright © 2014, 2017 John Darrington <jmd@gnu.org> ;;; Copyright © 2016, 2017, 2018, 2020 Leo Famulari <leo@famulari.name>-;;; Copyright © 2016, 2017, 2018, 2019 Efraim Flashner <efraim@flashner.co.il>+;;; Copyright © 2016, 2017, 2018, 2019, 2020 Efraim Flashner <efraim@flashner.co.il> ;;; Copyright © 2016, 2017, 2018, 2019, 2020 Tobias Geerinckx-Rice <me@tobias.gr> ;;; Copyright © 2016 Eric Bavier <bavier@member.fsf.org> ;;; Copyright © 2016, 2017 Arun Isaac <arunisaac@systemreboot.net>@@ -1532,6 +1532,10 @@ is hereby granted."))))     (arguments      `(#:configure-flags '("-DCMAKE_INSTALL_LIBDIR:PATH=lib"                            "-DENABLE_STATIC=0"+                           ;; djpeg-shared-3x2-float-prog-cmp fails on 32-bit PPC.+                           ,@(if (string=? "powerpc-linux" (%current-system))+                               `("-DFLOATTEST=NO")+                               '())                            ;; The build system probes for the current CPU, but                            ;; that fails when cross-compiling.                            ,@(let ((target (%current-target-system)))@@ -1545,6 +1549,9 @@ is hereby granted."))))                                      `("-DCMAKE_SYSTEM_PROCESSOR=x86"))                                     ((string-prefix? "x86_64" target)                                      `("-DCMAKE_SYSTEM_PROCESSOR=x86_64"))+                                    ;; 32-bit and 64-bit+                                    ((string-prefix? "powerpc" target)+                                     `("-DCMAKE_SYSTEM_PROCESSOR=powerpc"))                                     (else '()))                                    '())))        ,@(if (%current-target-system)-- 2.26.2

Marius Bakke wrote on 28 Apr 2020 15:54

Recipients:(name . Efraim Flashner)(address . efraim@flashner.co.il)

Message-ID:87k11z7m1q.fsf@devup.no

Efraim Flashner <efraim@flashner.co.il> writes:

Toggle quote (3 lines)

> * gnu/packages/image.scm (libjpeg-turbo)[arguments]: Add configure-flags> specific to powerpc to fix building and cross-building.

LGTM.

Efraim Flashner wrote on 28 Apr 2020 16:02

Recipients:(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 40898-done@debbugs.gnu.org)

Message-ID:20200428140228.GU5243@E5400

On Tue, Apr 28, 2020 at 03:54:41PM +0200, Marius Bakke wrote:

Toggle quote (7 lines)

> Efraim Flashner <efraim@flashner.co.il> writes:> > > * gnu/packages/image.scm (libjpeg-turbo)[arguments]: Add configure-flags> > specific to powerpc to fix building and cross-building.> > LGTM.

Thanks. Patch pushed. I tested on native hardware and cross building :)

-- Efraim Flashner <efraim@flashner.co.il> אפרים פלשנרGPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351Confidentiality cannot be guaranteed on emails sent or received unencrypted

Closed

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date