[PATCH] file-systems: mount the PID cgroup filesystem.

Jakub Kądziołka wrote on 26 Apr 2020 17:58

Recipients:(address . guix-patches@gnu.org)

Message-ID:20200426155858.15674-1-kuba@kadziolka.net

* gnu/system/file-systems.scm (%control-groups): Add "pids".* gnu/services/docker.scm (docker-shepherd-service): Resolve a TODO.
This has allowed me to make a specific configuration of nsjail work.--- gnu/services/docker.scm | 3 ++- gnu/system/file-systems.scm | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)

Toggle diff (42 lines)diff --git a/gnu/services/docker.scm b/gnu/services/docker.scmindex 04f9127346..d6dc792821 100644--- a/gnu/services/docker.scm+++ b/gnu/services/docker.scm@@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018 Danny Milosavljevic <dannym@scratchpost.org>+;;; Copyright © 2020 Jakub Kądziołka <kuba@kadziolka.net> ;;; ;;; This file is part of GNU Guix. ;;;@@ -94,7 +95,7 @@ loop-back communications.")                           file-system-/sys/fs/cgroup/cpuset                           file-system-/sys/fs/cgroup/devices                           file-system-/sys/fs/cgroup/memory-                          ; TODO: file-system-/sys/fs/cgroup/pids+                          file-system-/sys/fs/cgroup/pids                           networking                           udev))            (start #~(make-forkexec-constructordiff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scmindex 3b599efa8e..b41f66e943 100644--- a/gnu/system/file-systems.scm+++ b/gnu/system/file-systems.scm@@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès <ludo@gnu.org>+;;; Copyright © 2020 Jakub Kądziołka <kuba@kadziolka.net> ;;; ;;; This file is part of GNU Guix. ;;;@@ -389,7 +390,7 @@ TARGET in the other system."                    ;; parent directory.                    (dependencies (list parent))))                '("cpuset" "cpu" "cpuacct" "memory" "devices" "freezer"-                 "blkio" "perf_event")))))+                 "blkio" "perf_event" "pids")))))  (define %elogind-file-systems   ;; We don't use systemd, but these file systems are needed for elogind,-- 2.26.0

Mathieu Othacehe wrote on 27 Apr 2020 08:41

Recipients:(name . Jakub Kądziołka)(address . kuba@kadziolka.net)(address . 40871@debbugs.gnu.org)

Message-ID:87lfmhwhu9.fsf@gmail.com

Hello Jakub,
This looks good to me.
Thanks,
Mathieu

Jakub Kądziołka wrote on 27 Apr 2020 14:16

Recipients:(name . Mathieu Othacehe)(address . m.othacehe@gmail.com)(address . 40871@debbugs.gnu.org)

Message-ID:20200427121600.jgo7ailom5yklypk@gravity

On Mon, Apr 27, 2020 at 08:41:50AM +0200, Mathieu Othacehe wrote:

Toggle quote (9 lines)

> > Hello Jakub,> > This looks good to me.> > Thanks,> > Mathieu

Thanks for taking a look! I pushed the patch as commit2ef4d273d13faccbc9e11a74cfdbd0a9f4f1c898.
Cheers!

Jakub Kądziołka wrote on 27 Apr 2020 14:16

close 40871

Recipients:(address . control@debbugs.gnu.org)

Message-ID:20200427121621.qlotbgaefre5uner@gravity

close 40871thanks

Your comment

Commenting via the web interface is currently disabled.

To comment on this conversation send email to 40871@debbugs.gnu.org

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date